2015-08-11 05:11:27

by yalin wang

Subject: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

HWM_REVERSE() macro is unused, remove it.

Signed-off-by: yalin wang <[email protected]>
---
drivers/net/fddi/skfp/h/hwmtm.h | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h
index 5924d42..4ca2341 100644
--- a/drivers/net/fddi/skfp/h/hwmtm.h
+++ b/drivers/net/fddi/skfp/h/hwmtm.h
@@ -74,15 +74,6 @@
#define NULL 0
#endif

-#ifdef LITTLE_ENDIAN
-#define HWM_REVERSE(x) (x)
-#else
-#define HWM_REVERSE(x) ((((x)<<24L)&0xff000000L) + \
- (((x)<< 8L)&0x00ff0000L) + \
- (((x)>> 8L)&0x0000ff00L) + \
- (((x)>>24L)&0x000000ffL))
-#endif
-
#define C_INDIC (1L<<25)
#define A_INDIC (1L<<26)
#define RD_FS_LOCAL 0x80
--
1.9.1

2015-08-11 05:37:52

by David Miller

Subject: Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

From: yalin wang <[email protected]>
Date: Tue, 11 Aug 2015 13:11:22 +0800

> HWM_REVERSE() macro is unused, remove it.
>
> Signed-off-by: yalin wang <[email protected]>

You did not do as I asked you to, this patch is still corrupted
and there is no way you successfully applied what is in this patch.

> -#define HWM_REVERSE(x) ((((x)<<24L)&0xff000000L) + \
> - (((x)<< 8L)&0x00ff0000L) + \
> - (((x)>> 8L)&0x0000ff00L) + \
> - (((x)>>24L)&0x000000ffL))

This indentation here is spaces, whereas in the source files they
are TABS.

Your email client did this.

If you fail to properly verify that your outgoing patches are not
corrupted before submitting them here, I will stop reviewing and
considering your changes.

Thank you.

2015-08-11 05:51:01

by yalin wang

Subject: Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

> On Aug 11, 2015, at 13:37, David Miller <[email protected]> wrote:
>
> From: yalin wang <[email protected]>
> Date: Tue, 11 Aug 2015 13:11:22 +0800
>
>> HWM_REVERSE() macro is unused, remove it.
>>
>> Signed-off-by: yalin wang <[email protected]>
>
> You did not do as I asked you to, this patch is still corrupted
> and there is no way you successfully applied what is in this patch.
>
>> -#define HWM_REVERSE(x) ((((x)<<24L)&0xff000000L) + \
>> - (((x)<< 8L)&0x00ff0000L) + \
>> - (((x)>> 8L)&0x0000ff00L) + \
>> - (((x)>>24L)&0x000000ffL))
>
> This indentation here is spaces, whereas in the source files they
> are TABS.
>
> Your email client did this.
>
> If you fail to properly verify that your outgoing patches are not
> corrupted before submitting them here, I will stop reviewing and
> considering your changes.
>
> Thank you.
ouch, i am sorry that i am sending from windows PC,
let me check that .
Sorry for that .-

2015-08-11 06:57:15

by yalin wang

Subject: Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

HWM_REVERSE() macro is unused, remove it.

Signed-off-by: yalin wang <[email protected]>
---
drivers/net/fddi/skfp/h/hwmtm.h | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h
index 5924d42..4ca2341 100644
--- a/drivers/net/fddi/skfp/h/hwmtm.h
+++ b/drivers/net/fddi/skfp/h/hwmtm.h
@@ -74,15 +74,6 @@
#define NULL 0
#endif

-#ifdef LITTLE_ENDIAN
-#define HWM_REVERSE(x) (x)
-#else
-#define HWM_REVERSE(x) ((((x)<<24L)&0xff000000L) + \
- (((x)<< 8L)&0x00ff0000L) + \
- (((x)>> 8L)&0x0000ff00L) + \
- (((x)>>24L)&0x000000ffL))
-#endif
-
#define C_INDIC (1L<<25)
#define A_INDIC (1L<<26)
#define RD_FS_LOCAL 0x80
--
1.9.1