2017-12-26 14:09:30

by Mathieu Malaterre

Subject: [PATCH 3/3] perf/core: Move inline keyword at the beginning of declaration

Fix non-fatal warnings such as:

kernel/events/ring_buffer.c:116:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
static int __always_inline
^~~~~~

Signed-off-by: Mathieu Malaterre <[email protected]>
---
kernel/events/ring_buffer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c
index 141aa2ca8728..c59aba0e7236 100644
--- a/kernel/events/ring_buffer.c
+++ b/kernel/events/ring_buffer.c
@@ -102,7 +102,7 @@ static void perf_output_put_handle(struct perf_output_handle *handle)
preempt_enable();
}

-static bool __always_inline
+static __always_inline bool
ring_buffer_has_space(unsigned long head, unsigned long tail,
unsigned long data_size, unsigned int size,
bool backward)
@@ -113,7 +113,7 @@ ring_buffer_has_space(unsigned long head, unsigned long tail,
return CIRC_SPACE(tail, head, data_size) >= size;
}

-static int __always_inline
+static __always_inline int
__perf_output_begin(struct perf_output_handle *handle,
struct perf_event *event, unsigned int size,
bool backward)
@@ -413,7 +413,7 @@ void *perf_aux_output_begin(struct perf_output_handle *handle,
}
EXPORT_SYMBOL_GPL(perf_aux_output_begin);

-static bool __always_inline rb_need_aux_wakeup(struct ring_buffer *rb)
+static __always_inline bool rb_need_aux_wakeup(struct ring_buffer *rb)
{
if (rb->aux_overwrite)
return false;
--
2.11.0

2017-12-28 12:15:15

by Ingo Molnar

Subject: Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of declaration

* Mathieu Malaterre <[email protected]> wrote:

> Fix non-fatal warnings such as:
>
> kernel/events/ring_buffer.c:116:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
> static int __always_inline
> ^~~~~~
>
> Signed-off-by: Mathieu Malaterre <[email protected]>
> ---
> kernel/events/ring_buffer.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Hm, never saw this warning before - is this a newly default GCC warning, or some
distro CFLAGS build that enables it?

Thanks,

Ingo

2017-12-28 12:20:46

by Ingo Molnar

Subject: Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of declaration

BTW., your email "To:" header is horribly broken, for this and the other patches
you sent recently:

To: unlisted-recipients: no To-header on input <;

I manually fixed it up when replying, but please fix.

Thanks,

Ingo

2017-12-28 17:24:14

by Mathieu Malaterre

Subject: Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of declaration

Hi Ingo,

On Thu, Dec 28, 2017 at 1:15 PM, Ingo Molnar <[email protected]> wrote:
>
> * Mathieu Malaterre <[email protected]> wrote:
>
>> Fix non-fatal warnings such as:
>>
>> kernel/events/ring_buffer.c:116:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
>> static int __always_inline
>> ^~~~~~
>>
>> Signed-off-by: Mathieu Malaterre <[email protected]>
>> ---
>> kernel/events/ring_buffer.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Hm, never saw this warning before - is this a newly default GCC warning, or some
> distro CFLAGS build that enables it?

Nope. Just compiling vanilla kernel with default options, defconfig
was pmac32. I used W=1.

2017-12-28 17:25:51

by Mathieu Malaterre

Subject: Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of declaration

Hi again,

On Thu, Dec 28, 2017 at 1:20 PM, Ingo Molnar <[email protected]> wrote:
>
> BTW., your email "To:" header is horribly broken, for this and the other patches
> you sent recently:
>
> To: unlisted-recipients: no To-header on input <;
>
> I manually fixed it up when replying, but please fix.

Right. I copy/pasted a zsh command from the web which seems to be far
from perfect:

function kpatch () {
patch=$1
shift
git send-email \
--cc-cmd="./scripts/get_maintainer.pl --norolestats $patch" \
$@ $patch
}

I'll fix that.

Thanks

2017-12-29 12:50:01

by Ingo Molnar

Subject: Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of declaration

* Mathieu Malaterre <[email protected]> wrote:

> Hi Ingo,
>
> On Thu, Dec 28, 2017 at 1:15 PM, Ingo Molnar <[email protected]> wrote:
> >
> > * Mathieu Malaterre <[email protected]> wrote:
> >
> >> Fix non-fatal warnings such as:
> >>
> >> kernel/events/ring_buffer.c:116:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
> >> static int __always_inline
> >> ^~~~~~
> >>
> >> Signed-off-by: Mathieu Malaterre <[email protected]>
> >> ---
> >> kernel/events/ring_buffer.c | 6 +++---
> >> 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > Hm, never saw this warning before - is this a newly default GCC warning, or some
> > distro CFLAGS build that enables it?
>
> Nope. Just compiling vanilla kernel with default options, defconfig
> was pmac32. I used W=1.

"W=1" is not a default build variant - it enables -Wall...

This absolutely needs to be spelled out in the changelog!

Thanks,

Ingo