2022-04-22 21:05:25

by Greg Kroah-Hartman

Subject: Re: [PATCH v4 7/7] staging: r8188eu: remove unused else condition

On Thu, Apr 21, 2022 at 03:20:32PM -0400, Jaehee Park wrote:
> s_ret cannot return '2' so this else condition is unused. Remove this
> unnecessary else statement.

s_ret is not a function, it is a value.
rtw_select_and_join_from_scanned_queue() is the function here.

Can you fix up the wording in this changelog text and resubmit?

thanks,

greg k-h

2022-04-27 16:05:34

by Jaehee Park

Subject: Re: [PATCH v4 7/7] staging: r8188eu: remove unused else condition

On Fri, Apr 22, 2022 at 10:45 AM Greg KH <[email protected]> wrote:
>
> On Thu, Apr 21, 2022 at 03:20:32PM -0400, Jaehee Park wrote:
> > s_ret cannot return '2' so this else condition is unused. Remove this
> > unnecessary else statement.
>
> s_ret is not a function, it is a value.
> rtw_select_and_join_from_scanned_queue() is the function here.
>
> Can you fix up the wording in this changelog text and resubmit?
>
> thanks,
>
> greg k-h

Sorry about the delay! I've sent the revised patch just now.
Thanks,
Jaehee