Hi Gary,
On Mon, Jan 2, 2017 at 4:20 PM, Gary Bisson
<[email protected]> wrote:
> Now using group_desc structure instead of imx_pin_group.
>
> Also leveraging generic functions to retrieve groups count/name/pins.
>
> The imx_free_pingroups function can be removed since it is now handled by
> the core driver during unregister.
>
> Finally the device tree parsing is moved after the pinctrl driver registration
> since this latter initializes the radix trees.
>
> Signed-off-by: Gary Bisson <[email protected]>
This patch is in 4.11-rc1 now and it causes a regression on the hog group:
[ 0.061005] imx6q-pinctrl 20e0000.iomuxc: unable to find group for
node hoggrp
The hog pins can no longer be initialized.
Could you take a look, please?
* Fabio Estevam <[email protected]> [170307 09:39]:
> Hi Gary,
>
> On Tue, Mar 7, 2017 at 2:26 PM, Gary Bisson
> <[email protected]> wrote:
>
> > No it isn't because of the use of radix but instead of:
> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=950b0d91dc10
> >
> > It has been discussed here:
> > https://lkml.org/lkml/2017/2/28/140
>
> Thanks for the clarification.
>
> > Tony offered a patch in that thread which works. Tony, have you
> > submitted it yet?
>
> Looking forward to this one :-)
Still waiting to hear back from Linus on what he prefers.
Regards,
Tony
Hi Gary,
On Tue, Mar 7, 2017 at 2:26 PM, Gary Bisson
<[email protected]> wrote:
> No it isn't because of the use of radix but instead of:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=950b0d91dc10
>
> It has been discussed here:
> https://lkml.org/lkml/2017/2/28/140
Thanks for the clarification.
> Tony offered a patch in that thread which works. Tony, have you
> submitted it yet?
Looking forward to this one :-)
Thanks
Hi Fabio,
On Tue, Mar 7, 2017 at 6:19 PM, Fabio Estevam <[email protected]> wrote:
> Hi Gary,
>
> On Mon, Jan 2, 2017 at 4:20 PM, Gary Bisson
> <[email protected]> wrote:
>> Now using group_desc structure instead of imx_pin_group.
>>
>> Also leveraging generic functions to retrieve groups count/name/pins.
>>
>> The imx_free_pingroups function can be removed since it is now handled by
>> the core driver during unregister.
>>
>> Finally the device tree parsing is moved after the pinctrl driver registration
>> since this latter initializes the radix trees.
>>
>> Signed-off-by: Gary Bisson <[email protected]>
>
> This patch is in 4.11-rc1 now and it causes a regression on the hog group:
>
> [ 0.061005] imx6q-pinctrl 20e0000.iomuxc: unable to find group for
> node hoggrp
>
> The hog pins can no longer be initialized.
>
> Could you take a look, please?
No it isn't because of the use of radix but instead of:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=950b0d91dc10
It has been discussed here:
https://lkml.org/lkml/2017/2/28/140
Tony offered a patch in that thread which works. Tony, have you
submitted it yet?
Regards,
Gary
On Tue, Mar 7, 2017 at 6:54 PM, Tony Lindgren <[email protected]> wrote:
> * Fabio Estevam <[email protected]> [170307 09:39]:
>> Hi Gary,
>>
>> On Tue, Mar 7, 2017 at 2:26 PM, Gary Bisson
>> <[email protected]> wrote:
>>
>> > No it isn't because of the use of radix but instead of:
>> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=950b0d91dc10
>> >
>> > It has been discussed here:
>> > https://lkml.org/lkml/2017/2/28/140
>>
>> Thanks for the clarification.
>>
>> > Tony offered a patch in that thread which works. Tony, have you
>> > submitted it yet?
>>
>> Looking forward to this one :-)
>
> Still waiting to hear back from Linus on what he prefers.
I am snowed under by mail and might be missing stuff at the
moment...
If there is some especially urgent fix patch I need to look into
can you please point it out?
Yours,
Linus Walleij
Tony/Linus
On Wed, Mar 15, 2017 at 6:46 AM, Linus Walleij <[email protected]> wrote:
>> Still waiting to hear back from Linus on what he prefers.
>
> I am snowed under by mail and might be missing stuff at the
> moment...
>
> If there is some especially urgent fix patch I need to look into
> can you please point it out?
Has this issue been solved in linux-next? Still seeing this regression
in 4.11-rc4.
Thanks
* Fabio Estevam <[email protected]> [170329 06:36]:
> Tony/Linus
>
> On Wed, Mar 15, 2017 at 6:46 AM, Linus Walleij <[email protected]> wrote:
>
> >> Still waiting to hear back from Linus on what he prefers.
> >
> > I am snowed under by mail and might be missing stuff at the
> > moment...
> >
> > If there is some especially urgent fix patch I need to look into
> > can you please point it out?
>
> Has this issue been solved in linux-next? Still seeing this regression
> in 4.11-rc4.
Yeah I was wondering about that too. We discussed using Mika's patch
[0] but with minor changes [1]. But we have not heard back from Mika,
I wonder if he is travelling or something?
Would be nice to get this regression fixed.
Regards,
Tony
[0] https://lkml.org/lkml/2017/2/28/24
[1] https://lkml.org/lkml/2017/3/16/285
On Wed, Mar 29, 2017 at 3:33 PM, Fabio Estevam <[email protected]> wrote:
> Tony/Linus
>
> On Wed, Mar 15, 2017 at 6:46 AM, Linus Walleij <[email protected]> wrote:
>
>>> Still waiting to hear back from Linus on what he prefers.
>>
>> I am snowed under by mail and might be missing stuff at the
>> moment...
>>
>> If there is some especially urgent fix patch I need to look into
>> can you please point it out?
>
> Has this issue been solved in linux-next? Still seeing this regression
> in 4.11-rc4.
I'm a bit relying on others to test and supply patches here,
if Tony's patch works for you you can send it with your
own Signed-off-by and suggest that I merge it.
Yours,
Linus Walleij
* Linus Walleij <[email protected]> [170330 02:08]:
> On Wed, Mar 29, 2017 at 3:33 PM, Fabio Estevam <[email protected]> wrote:
> > Tony/Linus
> >
> > On Wed, Mar 15, 2017 at 6:46 AM, Linus Walleij <[email protected]> wrote:
> >
> >>> Still waiting to hear back from Linus on what he prefers.
> >>
> >> I am snowed under by mail and might be missing stuff at the
> >> moment...
> >>
> >> If there is some especially urgent fix patch I need to look into
> >> can you please point it out?
> >
> > Has this issue been solved in linux-next? Still seeing this regression
> > in 4.11-rc4.
>
> I'm a bit relying on others to test and supply patches here,
> if Tony's patch works for you you can send it with your
> own Signed-off-by and suggest that I merge it.
I'll send a patch for testing shortly.
Regards,
Tony