2017-12-01 12:03:35

by Riku Voipio

[permalink] [raw]
Subject: Re: [PATCH v3] scripts/package: snap-pkg target

On 29 November 2017 at 19:05, Paolo Pisati <[email protected]> wrote:
> On Wed, Nov 29, 2017 at 8:33 AM, Masahiro Yamada
> <[email protected]> wrote:
>>
>> Worked for me too,
>> after updating snapcraft.
>>
>>
>> Is it really impossible to check the snapcraft version?
>> What is the minimum version? 2.35 ?
>
> The minimum version is 2.35+ - what is about to become 2.36 anytime soon now.

Since you are already patching snapcraft for this, why not embed the
whole support in snapcraft? Eg something like snapcraft --kernel
/path/to/kernel

The key advantage you'll get is being able to support old kernel versions too.

Riku


2017-12-05 11:31:11

by Paolo Pisati

[permalink] [raw]
Subject: Re: [PATCH v3] scripts/package: snap-pkg target

On Fri, Dec 1, 2017 at 1:03 PM, Riku Voipio <[email protected]> wrote:
>
> Since you are already patching snapcraft for this, why not embed the
> whole support in snapcraft? Eg something like snapcraft --kernel
> /path/to/kernel
>
> The key advantage you'll get is being able to support old kernel versions too.

There's a lot more you can do inside a snapcraft.yaml (bundle external
files, override .config options, run pre or post scripts, etc) but by
embedding everything inside the kernel/kbuild plugins
you would loose all these options, and people would loose visibility
of these opportunities.

Besides, snapcraft requires a snapcraft.yaml by design, and i can't
remove that (such a change would never be accepted).
--
bye,
p.