2023-03-19 13:38:29

by Tom Rix

Subject: [PATCH] usb: typec: tipd: remove unused tps6598x_write16,32 functions

clang with W=1 reports
drivers/usb/typec/tipd/core.c:180:19: error: unused function
'tps6598x_write16' [-Werror,-Wunused-function]
static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
^
drivers/usb/typec/tipd/core.c:185:19: error: unused function
'tps6598x_write32' [-Werror,-Wunused-function]
static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
^
These static functions are not used, so remove them.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/usb/typec/tipd/core.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 485b90c13078..af6ecb54b52c 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -177,16 +177,6 @@ static inline int tps6598x_read64(struct tps6598x *tps, u8 reg, u64 *val)
return tps6598x_block_read(tps, reg, val, sizeof(u64));
}

-static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
-{
- return tps6598x_block_write(tps, reg, &val, sizeof(u16));
-}
-
-static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
-{
- return tps6598x_block_write(tps, reg, &val, sizeof(u32));
-}
-
static inline int tps6598x_write64(struct tps6598x *tps, u8 reg, u64 val)
{
return tps6598x_block_write(tps, reg, &val, sizeof(u64));
--
2.27.0

2023-03-20 11:58:45

by Heikki Krogerus

Subject: Re: [PATCH] usb: typec: tipd: remove unused tps6598x_write16,32 functions

On Sun, Mar 19, 2023 at 09:37:32AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/usb/typec/tipd/core.c:180:19: error: unused function
> 'tps6598x_write16' [-Werror,-Wunused-function]
> static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
> ^
> drivers/usb/typec/tipd/core.c:185:19: error: unused function
> 'tps6598x_write32' [-Werror,-Wunused-function]
> static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
> ^
> These static functions are not used, so remove them.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/typec/tipd/core.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 485b90c13078..af6ecb54b52c 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -177,16 +177,6 @@ static inline int tps6598x_read64(struct tps6598x *tps, u8 reg, u64 *val)
> return tps6598x_block_read(tps, reg, val, sizeof(u64));
> }
>
> -static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
> -{
> - return tps6598x_block_write(tps, reg, &val, sizeof(u16));
> -}
> -
> -static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
> -{
> - return tps6598x_block_write(tps, reg, &val, sizeof(u32));
> -}
> -
> static inline int tps6598x_write64(struct tps6598x *tps, u8 reg, u64 val)
> {
> return tps6598x_block_write(tps, reg, &val, sizeof(u64));

thanks,

--
heikki

2023-03-21 07:04:14

by Jun Nie

Subject: Re: [PATCH] usb: typec: tipd: remove unused tps6598x_write16,32 functions

Tom Rix <[email protected]> 于2023年3月19日周日 21:37写道：
>
> clang with W=1 reports
> drivers/usb/typec/tipd/core.c:180:19: error: unused function
> 'tps6598x_write16' [-Werror,-Wunused-function]
> static inline int tps6598x_write16(struct tps6598x *tps, u8 reg, u16 val)
> ^
> drivers/usb/typec/tipd/core.c:185:19: error: unused function
> 'tps6598x_write32' [-Werror,-Wunused-function]
> static inline int tps6598x_write32(struct tps6598x *tps, u8 reg, u32 val)
> ^
> These static functions are not used, so remove them.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/usb/typec/tipd/core.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
Reviewed-by: Jun Nie <[email protected]>