Add ACPI ID for ARM DMA-330 controller to AMBA id list to allow the
probing of the device.
Signed-off-by: Vijayenthiran Subramaniam <[email protected]>
---
drivers/acpi/acpi_amba.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/acpi_amba.c b/drivers/acpi/acpi_amba.c
index ab8a4e0191b1..5574a0a97655 100644
--- a/drivers/acpi/acpi_amba.c
+++ b/drivers/acpi/acpi_amba.c
@@ -21,6 +21,7 @@
static const struct acpi_device_id amba_id_list[] = {
{"ARMH0061", 0}, /* PL061 GPIO Device */
+ {"ARMH0330", 0}, /* ARM AMBA DMA Controller DMA-330 */
{"ARMHC500", 0}, /* ARM CoreSight ETM4x */
{"ARMHC501", 0}, /* ARM CoreSight ETR */
{"ARMHC502", 0}, /* ARM CoreSight STM */
--
2.17.1
On Fri, Sep 16, 2022 at 04:49:12PM +0530, Vijayenthiran Subramaniam wrote:
> Add ACPI ID for ARM DMA-330 controller to AMBA id list to allow the
> probing of the device.
>
$subject pattern is simply wrong and I see this is just copied from the
previous commit which makes no sense here. You can see other commits
and their patterns too.
Use prefix something like:
ACPI / amba:
or
ACPI: amba:
Also "Add .." in the $subject sounds like you are adding the support for
the controller here which is not the case.
Enable support for Arm Primecell PL330 dma controller
Or
Add Arm Primecell PL330 dma controller to the supported list
--
Regards,
Sudeep
Hi Sudeep,
On Fri, Sep 16, 2022 at 1:06 PM Sudeep Holla <[email protected]> wrote:
>
> On Fri, Sep 16, 2022 at 04:49:12PM +0530, Vijayenthiran Subramaniam wrote:
> > Add ACPI ID for ARM DMA-330 controller to AMBA id list to allow the
> > probing of the device.
> >
>
> $subject pattern is simply wrong and I see this is just copied from the
> previous commit which makes no sense here. You can see other commits
> and their patterns too.
>
> Use prefix something like:
> ACPI / amba:
> or
> ACPI: amba:
>
> Also "Add .." in the $subject sounds like you are adding the support for
> the controller here which is not the case.
>
> Enable support for Arm Primecell PL330 dma controller
> Or
> Add Arm Primecell PL330 dma controller to the supported list
Ack.
I have posted v2 with the subject:
[PATCH v2] ACPI: amba: Add Arm DMA-330 controller to the supported list.
>
> --
> Regards,
> Sudeep