2024-01-12 17:57:31

by Alexei Starovoitov

Subject: Re: [PATCH v3 1/2] bpf: Reject variable offset alu on PTR_TO_FLOW_KEYS

On Fri, Jan 12, 2024 at 7:20 AM Hao Sun <[email protected]> wrote:
>
> For PTR_TO_FLOW_KEYS, check_flow_keys_access() only uses fixed off
> for validation. However, variable offset ptr alu is not prohibited
> for this ptr kind. So the variable offset is not checked.

Why resend v3?
What changed from v2?

2024-01-12 18:02:35

by Hao Sun

Subject: Re: [PATCH v3 1/2] bpf: Reject variable offset alu on PTR_TO_FLOW_KEYS

On Fri, Jan 12, 2024 at 6:57 PM Alexei Starovoitov
<[email protected]> wrote:
>
> On Fri, Jan 12, 2024 at 7:20 AM Hao Sun <[email protected]> wrote:
> >
> > For PTR_TO_FLOW_KEYS, check_flow_keys_access() only uses fixed off
> > for validation. However, variable offset ptr alu is not prohibited
> > for this ptr kind. So the variable offset is not checked.
>
> Why resend v3?
> What changed from v2?

Nothing changes in the first patch, the tests in the second patch are
reformatted
with a proper number of tabs after each instruction. Forgot to add changelogs.