2021-12-15 06:06:35

by CGEL

Subject: [PATCH infiniband-next] drivers/infiniband: remove redundant err variable

From: Minghao Chi <[email protected]>

Return value directly instead of taking this
in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
index 2cb810cb890a..f557150bd59a 100644
--- a/drivers/infiniband/sw/rxe/rxe_net.c
+++ b/drivers/infiniband/sw/rxe/rxe_net.c
@@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;

int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)
{
- int err;
unsigned char ll_addr[ETH_ALEN];

ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
- err = dev_mc_add(rxe->ndev, ll_addr);

- return err;
+ return dev_mc_add(rxe->ndev, ll_addr);
}

int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)
{
- int err;
unsigned char ll_addr[ETH_ALEN];

ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
- err = dev_mc_del(rxe->ndev, ll_addr);

- return err;
+ return dev_mc_del(rxe->ndev, ll_addr);
}

static struct dst_entry *rxe_find_route4(struct net_device *ndev,
--
2.25.1

2021-12-15 07:06:07

by Devesh Sharma

Subject: RE: [External] : [PATCH infiniband-next] drivers/infiniband: remove redundant err variable

> -----Original Message-----
> From: [email protected] <[email protected]>
> Sent: Wednesday, December 15, 2021 11:36 AM
> To: [email protected]
> Cc: [email protected]; [email protected]; [email protected]; linux-
> [email protected]; Minghao Chi <[email protected]>; Zeal
> Robot <[email protected]>
> Subject: [External] : [PATCH infiniband-next] drivers/infiniband: remove


Change the subject line
[PATCH for-next] RDMA/rxe: ....

> redundant err variable
>
> From: Minghao Chi <[email protected]>
>
> Return value directly instead of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
> b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
>
> int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid) {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_add(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_add(rxe->ndev, ll_addr);
> }
>
> int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid) {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_del(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_del(rxe->ndev, ll_addr);
> }
>
> static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1

2021-12-15 07:53:13

by CGEL

Subject: [PATCH for-next v2] RDMA/rxe: remove redundant err variable

From: Minghao Chi <[email protected]>

Return value directly instead of taking this
in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
b/drivers/infiniband/sw/rxe/rxe_net.c
index 2cb810cb890a..f557150bd59a 100644
--- a/drivers/infiniband/sw/rxe/rxe_net.c
+++ b/drivers/infiniband/sw/rxe/rxe_net.c
@@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;

int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)
{
- int err;
unsigned char ll_addr[ETH_ALEN];

ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
- err = dev_mc_add(rxe->ndev, ll_addr);

- return err;
+ return dev_mc_add(rxe->ndev, ll_addr);
}

int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)
{
- int err;
unsigned char ll_addr[ETH_ALEN];

ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
- err = dev_mc_del(rxe->ndev, ll_addr);

- return err;
+ return dev_mc_del(rxe->ndev, ll_addr);
}

static struct dst_entry *rxe_find_route4(struct net_device *ndev,
--
2.25.1

2021-12-15 08:41:08

by Devesh Sharma

Subject: RE: [External] : [PATCH for-next v2] RDMA/rxe: remove redundant err variable

> -----Original Message-----
> From: [email protected] <[email protected]>
> Sent: Wednesday, December 15, 2021 1:23 PM
> To: Devesh Sharma <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: [External] : [PATCH for-next v2] RDMA/rxe: remove redundant err
> variable
>
> From: Minghao Chi <[email protected]>
>
> Return value directly instead of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
> b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
>
> int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid) {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_add(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_add(rxe->ndev, ll_addr);
> }
>
> int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid) {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_del(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_del(rxe->ndev, ll_addr);
> }
>
LGTM
Reviewed-by: Devesh Sharma <[email protected]>

> static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1

2021-12-15 12:36:33

by Zhu Yanjun

Subject: Re: [PATCH for-next v2] RDMA/rxe: remove redundant err variable

On Wed, Dec 15, 2021 at 3:53 PM <[email protected]> wrote:
>
> From: Minghao Chi <[email protected]>
>
> Return value directly instead of taking this
> in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>

Thanks.
Acked-by: Zhu Yanjun <[email protected]>

Zhu Yanjun

> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
> b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
>
> int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)
> {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_add(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_add(rxe->ndev, ll_addr);
> }
>
> int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)
> {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_del(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_del(rxe->ndev, ll_addr);
> }
>
> static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1
>

2021-12-16 09:03:44

by Zhu Yanjun

Subject: Re: [PATCH infiniband-next] drivers/infiniband: remove redundant err variable

On Wed, Dec 15, 2021 at 2:06 PM <[email protected]> wrote:
>
> From: Minghao Chi <[email protected]>
>
> Return value directly instead of taking this
> in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>

Thanks.
Acked-by: Zhu Yanjun <[email protected]>

Zhu Yanjun

> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
>
> int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)
> {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_add(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_add(rxe->ndev, ll_addr);
> }
>
> int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)
> {
> - int err;
> unsigned char ll_addr[ETH_ALEN];
>
> ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> - err = dev_mc_del(rxe->ndev, ll_addr);
>
> - return err;
> + return dev_mc_del(rxe->ndev, ll_addr);
> }
>
> static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1
>

2022-01-05 17:55:03

by Jason Gunthorpe

Subject: Re: [PATCH for-next v2] RDMA/rxe: remove redundant err variable

On Wed, Dec 15, 2021 at 07:52:58AM +0000, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Return value directly instead of taking this
> in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)

Applied to for-next, thanks

Jason