2013-07-25 07:06:28

by Murphy Zhou

Subject: [PATCH] staging/lustre: add BLOCK depends in Kconfig

From: Xiong Zhou <[email protected]>

Add BLOCK depends in Kconfig for LUSTRE to fix this:
drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2:
error: implicit declaration of function ?unregister_blkdev?

Signed-off-by: Xiong Zhou <[email protected]>
---
drivers/staging/lustre/lustre/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
index 9ae7fa8..0b45de0 100644
--- a/drivers/staging/lustre/lustre/Kconfig
+++ b/drivers/staging/lustre/lustre/Kconfig
@@ -1,6 +1,6 @@
config LUSTRE_FS
tristate "Lustre file system client support"
- depends on STAGING && INET && m
+ depends on STAGING && INET && BLOCK && m
select LNET
select CRYPTO
select CRYPTO_CRC32

2013-07-25 10:52:27

by Paul Bolle

Subject: Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig

On Thu, 2013-07-25 at 15:06 +0800, Xiong Zhou wrote:
> Add BLOCK depends in Kconfig for LUSTRE to fix this:
> drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2:
> error: implicit declaration of function ‘unregister_blkdev’
>
> Signed-off-by: Xiong Zhou <[email protected]>
> ---
> drivers/staging/lustre/lustre/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
> index 9ae7fa8..0b45de0 100644
> --- a/drivers/staging/lustre/lustre/Kconfig
> +++ b/drivers/staging/lustre/lustre/Kconfig
> @@ -1,6 +1,6 @@
> config LUSTRE_FS
> tristate "Lustre file system client support"
> - depends on STAGING && INET && m
> + depends on STAGING && INET && BLOCK && m

Everything below drivers/staging/lustre/Kconfig is only sourced if
STAGING is set. You can drop the dependency on STAGING.

> select LNET
> select CRYPTO
> select CRYPTO_CRC32


Paul Bolle

2013-07-25 23:17:49

by Dilger, Andreas

Subject: Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig

On 2013/07/25 1:06 AM, "Xiong Zhou" <[email protected]> wrote:

>From: Xiong Zhou <[email protected]>
>
>Add BLOCK depends in Kconfig for LUSTRE to fix this:
>drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2
>:
>error: implicit declaration of function ʽunregister_blkdevʼ
>
>Signed-off-by: Xiong Zhou <[email protected]>
>---
> drivers/staging/lustre/lustre/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/staging/lustre/lustre/Kconfig
>b/drivers/staging/lustre/lustre/Kconfig
>index 9ae7fa8..0b45de0 100644
>--- a/drivers/staging/lustre/lustre/Kconfig
>+++ b/drivers/staging/lustre/lustre/Kconfig
>@@ -1,6 +1,6 @@
> config LUSTRE_FS
> tristate "Lustre file system client support"
>- depends on STAGING && INET && m
>+ depends on STAGING && INET && BLOCK && m
> select LNET
> select CRYPTO
> select CRYPTO_CRC32

The Lustre client does not need a block device - it is a network
filesystem.
The one piece of code that is relevant here relates to a Lustre-optimized
"loop" device that bypasses the VFS, data copying, and DLM locking for use
by swap and such. It would be better instead to make that code conditional
and add a new CONFIG_LUSTRE_LLOOP or similar, and only make that part
dependent
on BLOCK.

Cheers, Andreas
--
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division


????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?

2013-07-26 06:03:08

by Murphy Zhou

Subject: Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig

2013/7/25 Paul Bolle <[email protected]>:
> On Thu, 2013-07-25 at 15:06 +0800, Xiong Zhou wrote:
>> Add BLOCK depends in Kconfig for LUSTRE to fix this:
>> drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2:
>> error: implicit declaration of function ?unregister_blkdev?
>>
>> Signed-off-by: Xiong Zhou <[email protected]>
>> ---
>> drivers/staging/lustre/lustre/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
>> index 9ae7fa8..0b45de0 100644
>> --- a/drivers/staging/lustre/lustre/Kconfig
>> +++ b/drivers/staging/lustre/lustre/Kconfig
>> @@ -1,6 +1,6 @@
>> config LUSTRE_FS
>> tristate "Lustre file system client support"
>> - depends on STAGING && INET && m
>> + depends on STAGING && INET && BLOCK && m
>
> Everything below drivers/staging/lustre/Kconfig is only sourced if
> STAGING is set. You can drop the dependency on STAGING.
>

Yes, it is. Thanks~

>> select LNET
>> select CRYPTO
>> select CRYPTO_CRC32
>
>
> Paul Bolle
>

2013-07-26 06:54:10

by Murphy Zhou

Subject: Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig

2013/7/26 Dilger, Andreas <[email protected]>:
> On 2013/07/25 1:06 AM, "Xiong Zhou" <[email protected]> wrote:
>
>>From: Xiong Zhou <[email protected]>
>>
>>Add BLOCK depends in Kconfig for LUSTRE to fix this:
>>drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2
>>:
>>error: implicit declaration of function ʽunregister_blkdevʼ
>>
>>Signed-off-by: Xiong Zhou <[email protected]>
>>---
>> drivers/staging/lustre/lustre/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/staging/lustre/lustre/Kconfig
>>b/drivers/staging/lustre/lustre/Kconfig
>>index 9ae7fa8..0b45de0 100644
>>--- a/drivers/staging/lustre/lustre/Kconfig
>>+++ b/drivers/staging/lustre/lustre/Kconfig
>>@@ -1,6 +1,6 @@
>> config LUSTRE_FS
>> tristate "Lustre file system client support"
>>- depends on STAGING && INET && m
>>+ depends on STAGING && INET && BLOCK && m
>> select LNET
>> select CRYPTO
>> select CRYPTO_CRC32
>
> The Lustre client does not need a block device - it is a network
> filesystem.
> The one piece of code that is relevant here relates to a Lustre-optimized
> "loop" device that bypasses the VFS, data copying, and DLM locking for use
> by swap and such. It would be better instead to make that code conditional
> and add a new CONFIG_LUSTRE_LLOOP or similar, and only make that part
> dependent
> on BLOCK.
>
> Cheers, Andreas
> --
> Andreas Dilger
>

This makes sence. I noticed that this patch has gone into Greg's tree,
so a coming patch
based on this patch is cool?

> Lustre Software Architect
> Intel High Performance Data Division
>
>

2013-07-26 07:34:11

by Dilger, Andreas

Subject: Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig

On 2013/07/26 12:54 AM, "Xiong Zhou" <[email protected]> wrote:

>2013/7/26 Dilger, Andreas <[email protected]>:
>> On 2013/07/25 1:06 AM, "Xiong Zhou" <[email protected]> wrote:
>>
>>>From: Xiong Zhou <[email protected]>
>>>
>>>Add BLOCK depends in Kconfig for LUSTRE to fix this:
>>>drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117
>>>:2
>>>:
>>>error: implicit declaration of function ʽunregister_blkdevʼ
>>>
>>>Signed-off-by: Xiong Zhou <[email protected]>
>>>---
>>> drivers/staging/lustre/lustre/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>diff --git a/drivers/staging/lustre/lustre/Kconfig
>>>b/drivers/staging/lustre/lustre/Kconfig
>>>index 9ae7fa8..0b45de0 100644
>>>--- a/drivers/staging/lustre/lustre/Kconfig
>>>+++ b/drivers/staging/lustre/lustre/Kconfig
>>>@@ -1,6 +1,6 @@
>>> config LUSTRE_FS
>>> tristate "Lustre file system client support"
>>>- depends on STAGING && INET && m
>>>+ depends on STAGING && INET && BLOCK && m
>>> select LNET
>>> select CRYPTO
>>> select CRYPTO_CRC32
>>
>> The Lustre client does not need a block device - it is a network
>> filesystem.
>> The one piece of code that is relevant here relates to a
>>Lustre-optimized
>> "loop" device that bypasses the VFS, data copying, and DLM locking for
>>use
>> by swap and such. It would be better instead to make that code
>>conditional
>> and add a new CONFIG_LUSTRE_LLOOP or similar, and only make that part
>> dependent on BLOCK.
>
>This makes sence. I noticed that this patch has gone into Greg's tree,
>so a coming patch based on this patch is cool?

That would be fine, thanks.

Cheers, Andreas
--
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division


????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?