2023-08-02 07:13:45

by Ran Sun

Subject: [PATCH] drm/amdgpu/atomfirmware: Clean up errors in amdgpu_atomfirmware.c

Fix the following errors reported by checkpatch:

ERROR: spaces required around that '>=' (ctx:WxV)
ERROR: spaces required around that '!=' (ctx:WxV)
ERROR: code indent should use tabs where possible

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
index 0b7f4c4d58e5..835980e94b9e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
@@ -58,7 +58,7 @@ uint32_t amdgpu_atomfirmware_query_firmware_capability(struct amdgpu_device *ade
if (amdgpu_atom_parse_data_header(adev->mode_info.atom_context,
index, &size, &frev, &crev, &data_offset)) {
/* support firmware_info 3.1 + */
- if ((frev == 3 && crev >=1) || (frev > 3)) {
+ if ((frev == 3 && crev >= 1) || (frev > 3)) {
firmware_info = (union firmware_info *)
(mode_info->atom_context->bios + data_offset);
fw_cap = le32_to_cpu(firmware_info->v31.firmware_capability);
@@ -597,7 +597,7 @@ bool amdgpu_atomfirmware_ras_rom_addr(struct amdgpu_device *adev,
index, &size, &frev, &crev,
&data_offset)) {
/* support firmware_info 3.4 + */
- if ((frev == 3 && crev >=4) || (frev > 3)) {
+ if ((frev == 3 && crev >= 4) || (frev > 3)) {
firmware_info = (union firmware_info *)
(mode_info->atom_context->bios + data_offset);
/* The ras_rom_i2c_slave_addr should ideally
@@ -850,7 +850,7 @@ int amdgpu_atomfirmware_get_fw_reserved_fb_size(struct amdgpu_device *adev)

firmware_info = (union firmware_info *)(ctx->bios + data_offset);

- if (frev !=3)
+ if (frev != 3)
return -EINVAL;

switch (crev) {
@@ -909,7 +909,7 @@ int amdgpu_atomfirmware_asic_init(struct amdgpu_device *adev, bool fb_reset)
}

index = get_index_into_master_table(atom_master_list_of_command_functions_v2_1,
- asic_init);
+ asic_init);
if (amdgpu_atom_parse_cmd_header(mode_info->atom_context, index, &frev, &crev)) {
if (frev == 2 && crev >= 1) {
memset(&asic_init_ps_v2_1, 0, sizeof(asic_init_ps_v2_1));
--
2.17.1

2023-08-07 17:39:12

by Alex Deucher

Subject: Re: [PATCH] drm/amdgpu/atomfirmware: Clean up errors in amdgpu_atomfirmware.c

Applied. Thanks!

On Wed, Aug 2, 2023 at 2:51 AM Ran Sun <[email protected]> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that '>=' (ctx:WxV)
> ERROR: spaces required around that '!=' (ctx:WxV)
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
> index 0b7f4c4d58e5..835980e94b9e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
> @@ -58,7 +58,7 @@ uint32_t amdgpu_atomfirmware_query_firmware_capability(struct amdgpu_device *ade
> if (amdgpu_atom_parse_data_header(adev->mode_info.atom_context,
> index, &size, &frev, &crev, &data_offset)) {
> /* support firmware_info 3.1 + */
> - if ((frev == 3 && crev >=1) || (frev > 3)) {
> + if ((frev == 3 && crev >= 1) || (frev > 3)) {
> firmware_info = (union firmware_info *)
> (mode_info->atom_context->bios + data_offset);
> fw_cap = le32_to_cpu(firmware_info->v31.firmware_capability);
> @@ -597,7 +597,7 @@ bool amdgpu_atomfirmware_ras_rom_addr(struct amdgpu_device *adev,
> index, &size, &frev, &crev,
> &data_offset)) {
> /* support firmware_info 3.4 + */
> - if ((frev == 3 && crev >=4) || (frev > 3)) {
> + if ((frev == 3 && crev >= 4) || (frev > 3)) {
> firmware_info = (union firmware_info *)
> (mode_info->atom_context->bios + data_offset);
> /* The ras_rom_i2c_slave_addr should ideally
> @@ -850,7 +850,7 @@ int amdgpu_atomfirmware_get_fw_reserved_fb_size(struct amdgpu_device *adev)
>
> firmware_info = (union firmware_info *)(ctx->bios + data_offset);
>
> - if (frev !=3)
> + if (frev != 3)
> return -EINVAL;
>
> switch (crev) {
> @@ -909,7 +909,7 @@ int amdgpu_atomfirmware_asic_init(struct amdgpu_device *adev, bool fb_reset)
> }
>
> index = get_index_into_master_table(atom_master_list_of_command_functions_v2_1,
> - asic_init);
> + asic_init);
> if (amdgpu_atom_parse_cmd_header(mode_info->atom_context, index, &frev, &crev)) {
> if (frev == 2 && crev >= 1) {
> memset(&asic_init_ps_v2_1, 0, sizeof(asic_init_ps_v2_1));
> --
> 2.17.1
>