Hi,
while strolling around the different flow handlers, I tried to make sense of
what preflow_handler() was about. Turns out no one uses those anymore, but the
genirq support has remained in place.
Unless we can see another user of those in the near future, this seems like as
good a time as any for a little housecleaning.
- Patch 1 simply deselects the (unexploited) preflow Kconfig for sparc64
- Patch 2 is the actual cleanup
Cheers,
Valentin
Valentin Schneider (2):
sparc64: Deselect IRQ_PREFLOW_FASTEOI
genirq: Remove preflow handler support
arch/sparc/Kconfig | 1 -
include/linux/irqdesc.h | 15 ---------------
include/linux/irqhandler.h | 1 -
kernel/irq/Kconfig | 4 ----
kernel/irq/chip.c | 13 -------------
5 files changed, 34 deletions(-)
--
2.27.0
sparc64 hasn't needed to select this since commit:
ee6a9333fa58 ("sparc64: sparse irq")
which got rid of the calls to __irq_set_preflow_handler() first installed
by commit:
fcd8d4f49869 ("sparc: Use the new genirq functionality")
Deselect this option.
Signed-off-by: Valentin Schneider <[email protected]>
---
arch/sparc/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index da515fdad83d..ed35760043e8 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -81,7 +81,6 @@ config SPARC64
select RTC_DRV_STARFIRE
select HAVE_PERF_EVENTS
select PERF_USE_VMALLOC
- select IRQ_PREFLOW_FASTEOI
select ARCH_HAVE_NMI_SAFE_CMPXCHG
select HAVE_C_RECORDMCOUNT
select HAVE_ARCH_AUDITSYSCALL
--
2.27.0
On Fri, Jul 3, 2020 at 6:58 PM Valentin Schneider
<[email protected]> wrote:
>
> sparc64 hasn't needed to select this since commit:
>
> ee6a9333fa58 ("sparc64: sparse irq")
>
> which got rid of the calls to __irq_set_preflow_handler() first installed
> by commit:
>
> fcd8d4f49869 ("sparc: Use the new genirq functionality")
>
> Deselect this option.
>
> Signed-off-by: Valentin Schneider <[email protected]>
> ---
> arch/sparc/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
> index da515fdad83d..ed35760043e8 100644
> --- a/arch/sparc/Kconfig
> +++ b/arch/sparc/Kconfig
> @@ -81,7 +81,6 @@ config SPARC64
> select RTC_DRV_STARFIRE
> select HAVE_PERF_EVENTS
> select PERF_USE_VMALLOC
> - select IRQ_PREFLOW_FASTEOI
> select ARCH_HAVE_NMI_SAFE_CMPXCHG
> select HAVE_C_RECORDMCOUNT
> select HAVE_ARCH_AUDITSYSCALL
tried/tested this patch on my test sparc64 ldom , boots ok
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 959f53bd90c3ac70e5481199c6159f6314f9f910
Gitweb: https://git.kernel.org/tip/959f53bd90c3ac70e5481199c6159f6314f9f910
Author: Valentin Schneider <[email protected]>
AuthorDate: Fri, 03 Jul 2020 16:56:44 +01:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Sat, 04 Jul 2020 10:02:06 +02:00
sparc64: Deselect IRQ_PREFLOW_FASTEOI
sparc64 hasn't needed to select this since commit:
ee6a9333fa58 ("sparc64: sparse irq")
which got rid of the calls to __irq_set_preflow_handler() first installed
by commit:
fcd8d4f49869 ("sparc: Use the new genirq functionality")
Deselect this option.
Signed-off-by: Valentin Schneider <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Tested-by: Anatoly Pugachev <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
arch/sparc/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 5bf2dc1..76f4078 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -80,7 +80,6 @@ config SPARC64
select RTC_DRV_STARFIRE
select HAVE_PERF_EVENTS
select PERF_USE_VMALLOC
- select IRQ_PREFLOW_FASTEOI
select ARCH_HAVE_NMI_SAFE_CMPXCHG
select HAVE_C_RECORDMCOUNT
select HAVE_ARCH_AUDITSYSCALL
Hi Valentin,
On 2020-07-03 16:56, Valentin Schneider wrote:
> Hi,
>
> while strolling around the different flow handlers, I tried to make
> sense of
> what preflow_handler() was about. Turns out no one uses those anymore,
> but the
> genirq support has remained in place.
If we needed to reintroduce some form of preflow handler, we'd try and
do it using hierarchical irqchips, if at all possible.
>
> Unless we can see another user of those in the near future, this seems
> like as
> good a time as any for a little housecleaning.
>
> - Patch 1 simply deselects the (unexploited) preflow Kconfig for
> sparc64
> - Patch 2 is the actual cleanup
>
> Cheers,
> Valentin
>
> Valentin Schneider (2):
> sparc64: Deselect IRQ_PREFLOW_FASTEOI
> genirq: Remove preflow handler support
>
> arch/sparc/Kconfig | 1 -
> include/linux/irqdesc.h | 15 ---------------
> include/linux/irqhandler.h | 1 -
> kernel/irq/Kconfig | 4 ----
> kernel/irq/chip.c | 13 -------------
> 5 files changed, 34 deletions(-)
For the whole series, and assuming that there is no regression
(can't imagine any for unused code):
Reviewed-by: Marc Zyngier <[email protected]>
Thanks,
M.
--
Jazz is not dead. It just smells funny...
Hi Marc,
On 04/07/20 10:48, Marc Zyngier wrote:
> Hi Valentin,
>
> On 2020-07-03 16:56, Valentin Schneider wrote:
>> Hi,
>>
>> while strolling around the different flow handlers, I tried to make
>> sense of
>> what preflow_handler() was about. Turns out no one uses those anymore,
>> but the
>> genirq support has remained in place.
>
> If we needed to reintroduce some form of preflow handler, we'd try and
> do it using hierarchical irqchips, if at all possible.
Right, that does sound like the most sensible approach. If I got my history
right, the preflow handlers saw the light of day before hierarchical
domains did, which I suppose is a reason why it wasn't done that way back
then.
>
>>
>> Unless we can see another user of those in the near future, this seems
>> like as
>> good a time as any for a little housecleaning.
>>
>> - Patch 1 simply deselects the (unexploited) preflow Kconfig for
>> sparc64
>> - Patch 2 is the actual cleanup
>>
>> Cheers,
>> Valentin
>>
>> Valentin Schneider (2):
>> sparc64: Deselect IRQ_PREFLOW_FASTEOI
>> genirq: Remove preflow handler support
>>
>> arch/sparc/Kconfig | 1 -
>> include/linux/irqdesc.h | 15 ---------------
>> include/linux/irqhandler.h | 1 -
>> kernel/irq/Kconfig | 4 ----
>> kernel/irq/chip.c | 13 -------------
>> 5 files changed, 34 deletions(-)
>
> For the whole series, and assuming that there is no regression
> (can't imagine any for unused code):
>
> Reviewed-by: Marc Zyngier <[email protected]>
>
Thanks!
> Thanks,
>
> M.
From: Valentin Schneider <[email protected]>
Date: Fri, 3 Jul 2020 16:56:44 +0100
> sparc64 hasn't needed to select this since commit:
>
> ee6a9333fa58 ("sparc64: sparse irq")
>
> which got rid of the calls to __irq_set_preflow_handler() first installed
> by commit:
>
> fcd8d4f49869 ("sparc: Use the new genirq functionality")
>
> Deselect this option.
>
> Signed-off-by: Valentin Schneider <[email protected]>
Acked-by: David S. Miller <[email protected]>