2021-03-30 07:07:05

by 王擎

[permalink] [raw]
Subject: [PATCH 0/6] Clean up obsolete TODO files

It is mentioned in the official documents of the Linux Foundation and WIKI
that you can participate in its development according to the TODO files of
each module.

But the TODO files here has not been updated for 15 years, and the function
development described in the file have been implemented or abandoned.

Its existence will mislead developers seeking to view outdated information.

Wang Qing (6):
mips/sgi-ip27: Delete obsolete TODO file
scsi/aacraid: Delete obsolete TODO file
fs/befs: Delete obsolete TODO file
fs/jffs2: Delete obsolete TODO file
net/ax25: Delete obsolete TODO file
net/decnet: Delete obsolete TODO file

arch/mips/sgi-ip27/TODO | 19 -------------------
drivers/scsi/aacraid/TODO | 3 ---
fs/befs/TODO | 14 --------------
fs/jffs2/TODO | 37 -------------------------------------
net/ax25/TODO | 20 --------------------
net/decnet/TODO | 40 ----------------------------------------
6 files changed, 133 deletions(-)
delete mode 100644 arch/mips/sgi-ip27/TODO
delete mode 100644 drivers/scsi/aacraid/TODO
delete mode 100644 fs/befs/TODO
delete mode 100644 fs/jffs2/TODO
delete mode 100644 net/ax25/TODO
delete mode 100644 net/decnet/TODO

--
2.7.4


2021-03-30 07:07:07

by 王擎

[permalink] [raw]
Subject: [PATCH 2/6] scsi/aacraid: Delete obsolete TODO file

The TODO file here has not been updated from 2.6.12 for more than 15 years.
Its existence will mislead developers seeking to view outdated information.

Signed-off-by: Wang Qing <[email protected]>
---
drivers/scsi/aacraid/TODO | 3 ---
1 file changed, 3 deletions(-)
delete mode 100644 drivers/scsi/aacraid/TODO

diff --git a/drivers/scsi/aacraid/TODO b/drivers/scsi/aacraid/TODO
deleted file mode 100644
index 78dc863..0000000
--- a/drivers/scsi/aacraid/TODO
+++ /dev/null
@@ -1,3 +0,0 @@
-o Testing
-o More testing
-o I/O size increase
--
2.7.4

2021-03-30 07:07:18

by 王擎

[permalink] [raw]
Subject: [PATCH 4/6] fs/jffs2: Delete obsolete TODO file

The TODO file here has not been updated for 14 years, and the function
development described in the file have been implemented or abandoned.

Its existence will mislead developers seeking to view outdated information.

Signed-off-by: Wang Qing <[email protected]>
---
fs/jffs2/TODO | 37 -------------------------------------
1 file changed, 37 deletions(-)
delete mode 100644 fs/jffs2/TODO

diff --git a/fs/jffs2/TODO b/fs/jffs2/TODO
deleted file mode 100644
index ca28964..0000000
--- a/fs/jffs2/TODO
+++ /dev/null
@@ -1,37 +0,0 @@
-
- - support asynchronous operation -- add a per-fs 'reserved_space' count,
- let each outstanding write reserve the _maximum_ amount of physical
- space it could take. Let GC flush the outstanding writes because the
- reservations will necessarily be pessimistic. With this we could even
- do shared writable mmap, if we can have a fs hook for do_wp_page() to
- make the reservation.
- - disable compression in commit_write()?
- - fine-tune the allocation / GC thresholds
- - chattr support - turning on/off and tuning compression per-inode
- - checkpointing (do we need this? scan is quite fast)
- - make the scan code populate real inodes so read_inode just after
- mount doesn't have to read the flash twice for large files.
- Make this a per-inode option, changeable with chattr, so you can
- decide which inodes should be in-core immediately after mount.
- - test, test, test
-
- - NAND flash support:
- - almost done :)
- - use bad block check instead of the hardwired byte check
-
- - Optimisations:
- - Split writes so they go to two separate blocks rather than just c->nextblock.
- By writing _new_ nodes to one block, and garbage-collected REF_PRISTINE
- nodes to a different one, we can separate clean nodes from those which
- are likely to become dirty, and end up with blocks which are each far
- closer to 100% or 0% clean, hence speeding up later GC progress dramatically.
- - Stop keeping name in-core with struct jffs2_full_dirent. If we keep the hash in
- the full dirent, we only need to go to the flash in lookup() when we think we've
- got a match, and in readdir().
- - Doubly-linked next_in_ino list to allow us to free obsoleted raw_node_refs immediately?
- - Remove size from jffs2_raw_node_frag.
-
-dedekind:
-1. __jffs2_flush_wbuf() has a strange 'pad' parameter. Eliminate.
-2. get_sb()->build_fs()->scan() path... Why get_sb() removes scan()'s crap in
- case of failure? scan() does not clean everything. Fix.
--
2.7.4

2021-03-30 07:07:19

by 王擎

[permalink] [raw]
Subject: [PATCH 3/6] fs/befs: Delete obsolete TODO file

The TODO file here has not been updated from 2005, and the function
development described in the file have been implemented or abandoned.

Its existence will mislead developers seeking to view outdated information.

Signed-off-by: Wang Qing <[email protected]>
---
fs/befs/TODO | 14 --------------
1 file changed, 14 deletions(-)
delete mode 100644 fs/befs/TODO

diff --git a/fs/befs/TODO b/fs/befs/TODO
deleted file mode 100644
index 3250921..0000000
--- a/fs/befs/TODO
+++ /dev/null
@@ -1,14 +0,0 @@
-TODO
-==========
-
-* Convert comments to the Kernel-Doc format.
-
-* Befs_fs.h has gotten big and messy. No reason not to break it up into
- smaller peices.
-
-* See if Alexander Viro's option parser made it into the kernel tree.
- Use that if we can. (include/linux/parser.h)
-
-* See if we really need separate types for on-disk and in-memory
- representations of the superblock and inode.
-
--
2.7.4

2021-03-30 07:07:28

by 王擎

[permalink] [raw]
Subject: [PATCH 5/6] net/ax25: Delete obsolete TODO file

The TODO file here has not been updated for 13 years, and the function
development described in the file have been implemented or abandoned.

Its existence will mislead developers seeking to view outdated information.

Signed-off-by: Wang Qing <[email protected]>
---
net/ax25/TODO | 20 --------------------
1 file changed, 20 deletions(-)
delete mode 100644 net/ax25/TODO

diff --git a/net/ax25/TODO b/net/ax25/TODO
deleted file mode 100644
index 69fb4e3..0000000
--- a/net/ax25/TODO
+++ /dev/null
@@ -1,20 +0,0 @@
-Do the ax25_list_lock, ax25_dev_lock, linkfail_lockreally, ax25_frag_lock and
-listen_lock have to be bh-safe?
-
-Do the netrom and rose locks have to be bh-safe?
-
-A device might be deleted after lookup in the SIOCADDRT ioctl but before it's
-being used.
-
-Routes to a device being taken down might be deleted by ax25_rt_device_down
-but added by somebody else before the device has been deleted fully.
-
-The ax25_rt_find_route synopsys is pervert but I somehow had to deal with
-the race caused by the static variable in it's previous implementation.
-
-Implement proper socket locking in netrom and rose.
-
-Check socket locking when ax25_rcv is sending to raw sockets. In particular
-ax25_send_to_raw() seems fishy. Heck - ax25_rcv is fishy.
-
-Handle XID and TEST frames properly.
--
2.7.4

2021-03-30 07:09:57

by 王擎

[permalink] [raw]
Subject: [PATCH 6/6] net/decnet: Delete obsolete TODO file

The TODO file here has not been updated from 2005, and the function
development described in the file have been implemented or abandoned.

Its existence will mislead developers seeking to view outdated information.

Signed-off-by: Wang Qing <[email protected]>
---
net/decnet/TODO | 40 ----------------------------------------
1 file changed, 40 deletions(-)
delete mode 100644 net/decnet/TODO

diff --git a/net/decnet/TODO b/net/decnet/TODO
deleted file mode 100644
index 358e9eb..0000000
--- a/net/decnet/TODO
+++ /dev/null
@@ -1,40 +0,0 @@
-Steve's quick list of things that need finishing off:
-[they are in no particular order and range from the trivial to the long winded]
-
- o Proper timeouts on each neighbour (in routing mode) rather than
- just the 60 second On-Ethernet cache value.
-
- o Support for X.25 linklayer
-
- o Support for DDCMP link layer
-
- o The DDCMP device itself
-
- o PPP support (rfc1762)
-
- o Lots of testing with real applications
-
- o Verify errors etc. against POSIX 1003.1g (draft)
-
- o Using send/recvmsg() to get at connect/disconnect data (POSIX 1003.1g)
- [maybe this should be done at socket level... the control data in the
- send/recvmsg() calls should simply be a vector of set/getsockopt()
- calls]
-
- o check MSG_CTRUNC is set where it should be.
-
- o Find all the commonality between DECnet and IPv4 routing code and extract
- it into a small library of routines. [probably a project for 2.7.xx]
-
- o Add perfect socket hashing - an idea suggested by Paul Koning. Currently
- we have a half-way house scheme which seems to work reasonably well, but
- the full scheme is still worth implementing, its not not top of my list
- right now.
-
- o Add session control message flow control
-
- o Add NSP message flow control
-
- o DECnet sendpages() function
-
- o AIO for DECnet
--
2.7.4

2021-03-31 00:01:36

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH 0/6] Clean up obsolete TODO files

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Tue, 30 Mar 2021 15:02:43 +0800 you wrote:
> It is mentioned in the official documents of the Linux Foundation and WIKI
> that you can participate in its development according to the TODO files of
> each module.
>
> But the TODO files here has not been updated for 15 years, and the function
> development described in the file have been implemented or abandoned.
>
> [...]

Here is the summary with links:
- [1/6] mips/sgi-ip27: Delete obsolete TODO file
https://git.kernel.org/netdev/net-next/c/0f1b2a4912b2
- [2/6] scsi/aacraid: Delete obsolete TODO file
https://git.kernel.org/netdev/net-next/c/ef843f261b88
- [3/6] fs/befs: Delete obsolete TODO file
https://git.kernel.org/netdev/net-next/c/22612b4e6039
- [4/6] fs/jffs2: Delete obsolete TODO file
https://git.kernel.org/netdev/net-next/c/ab36ba4f3a81
- [5/6] net/ax25: Delete obsolete TODO file
https://git.kernel.org/netdev/net-next/c/8d9e5bbf5c68
- [6/6] net/decnet: Delete obsolete TODO file
https://git.kernel.org/netdev/net-next/c/b9aa074b896b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html


2021-04-07 22:23:41

by Richard Weinberger

[permalink] [raw]
Subject: Re: [PATCH 4/6] fs/jffs2: Delete obsolete TODO file

On Tue, Mar 30, 2021 at 9:07 AM Wang Qing <[email protected]> wrote:
>
> The TODO file here has not been updated for 14 years, and the function
> development described in the file have been implemented or abandoned.
>
> Its existence will mislead developers seeking to view outdated information.

Did you check whether all items in this list are really outdated?
Nobody shall ever blindly follow a TODO list without checking first which
points are still valid or not.
Removing that file does not magically solve the issues it describes.

--
Thanks,
//richard