When kernel.h is used in the headers it adds a lot into dependency hell,
especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
Signed-off-by: Andy Shevchenko <[email protected]>
---
Andrew, please take it through your tree since KUnit maintainer is non-responsive
by unknown (to me) reasons.
include/kunit/assert.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/kunit/assert.h b/include/kunit/assert.h
index ad889b539ab3..ccbc36c0b02f 100644
--- a/include/kunit/assert.h
+++ b/include/kunit/assert.h
@@ -10,7 +10,7 @@
#define _KUNIT_ASSERT_H
#include <linux/err.h>
-#include <linux/kernel.h>
+#include <linux/printk.h>
struct kunit;
struct string_stream;
--
2.33.0
On Mon, Dec 13, 2021 at 3:44 PM Andy Shevchenko
<[email protected]> wrote:
>
> When kernel.h is used in the headers it adds a lot into dependency hell,
> especially when there are circular dependencies are involved.
>
> Replace kernel.h inclusion with the list of what is really being used.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
Reviewed-by: Brendan Higgins <[email protected]>
Tested-by: Brendan Higgins <[email protected]>
> ---
> Andrew, please take it through your tree since KUnit maintainer is non-responsive
> by unknown (to me) reasons.
Sorry, I did not see the previous version of this patch. But this
looks fine, and does not appear to break any tests.
On Tue, Dec 14, 2021 at 04:56:21PM -0500, Brendan Higgins wrote:
> On Mon, Dec 13, 2021 at 3:44 PM Andy Shevchenko
> <[email protected]> wrote:
> >
> > When kernel.h is used in the headers it adds a lot into dependency hell,
> > especially when there are circular dependencies are involved.
> >
> > Replace kernel.h inclusion with the list of what is really being used.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Reviewed-by: Brendan Higgins <[email protected]>
> Tested-by: Brendan Higgins <[email protected]>
Thanks!
> > Andrew, please take it through your tree since KUnit maintainer is non-responsive
> > by unknown (to me) reasons.
>
> Sorry, I did not see the previous version of this patch.
Maybe you need to check your email settings and your domain MTA?
https://lore.kernel.org/linux-kselftest/[email protected]/T/#u
> But this
> looks fine, and does not appear to break any tests.
--
With Best Regards,
Andy Shevchenko