2021-02-10 02:14:57

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks

Quoting [email protected] (2021-02-08 01:49:45)
> Hi, Michael, Stephen,
>
> Do you plan to take this patch for v5.12?
> If fw_devlink will remain set to ON for v5.12, some of our boards will
> no longer boot without this patch.

Is fw_devlink defaulted to on for v5.12?


2021-02-10 02:15:12

by Saravana Kannan

[permalink] [raw]
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks

On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd <[email protected]> wrote:
>
> Quoting [email protected] (2021-02-08 01:49:45)
> > Hi, Michael, Stephen,
> >
> > Do you plan to take this patch for v5.12?
> > If fw_devlink will remain set to ON for v5.12, some of our boards will
> > no longer boot without this patch.
>
> Is fw_devlink defaulted to on for v5.12?

Yes.

-Saravana

2021-02-10 08:54:30

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks

Hi Saravana,

On Wed, Feb 10, 2021 at 1:57 AM Saravana Kannan <[email protected]> wrote:
> On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd <[email protected]> wrote:
> > Quoting [email protected] (2021-02-08 01:49:45)
> > > Do you plan to take this patch for v5.12?
> > > If fw_devlink will remain set to ON for v5.12, some of our boards will
> > > no longer boot without this patch.
> >
> > Is fw_devlink defaulted to on for v5.12?
>
> Yes.

Have all issues been identified and understood?
Have all issues been fixed, reviewed, and committed?
Have all fixes entered linux-next?
Have all fixes been migrated from submaintainers to maintainers?

We're already at v5.11-rc7.
Yes, we can get fixes into v5.12-rc7. Or v5.12-rc9...

Gr{oetje,eeting}s,

Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2021-02-10 09:13:53

by Saravana Kannan

[permalink] [raw]
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks

On Wed, Feb 10, 2021 at 12:51 AM Geert Uytterhoeven
<[email protected]> wrote:
>
> Hi Saravana,
>
> On Wed, Feb 10, 2021 at 1:57 AM Saravana Kannan <[email protected]> wrote:
> > On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd <[email protected]> wrote:
> > > Quoting [email protected] (2021-02-08 01:49:45)
> > > > Do you plan to take this patch for v5.12?
> > > > If fw_devlink will remain set to ON for v5.12, some of our boards will
> > > > no longer boot without this patch.
> > >
> > > Is fw_devlink defaulted to on for v5.12?
> >
> > Yes.
>
> Have all issues been identified and understood?
> Have all issues been fixed, reviewed, and committed?
> Have all fixes entered linux-next?
> Have all fixes been migrated from submaintainers to maintainers?

I'm hoping Tudor has reported and the fixes that have gone in so far
addressed all his issues. Otherwise, they need to be reported so we
can fix them.

As of now, there's no pending fix that hasn't landed in maintainer
trees. So that's good.

-Saravana

>
> We're already at v5.11-rc7.
> Yes, we can get fixes into v5.12-rc7. Or v5.12-rc9...
>
> Gr{oetje,eeting}s,
>
> Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds

2021-02-10 09:15:38

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks

On Wed, Feb 10, 2021 at 09:51:14AM +0100, Geert Uytterhoeven wrote:
> Hi Saravana,
>
> On Wed, Feb 10, 2021 at 1:57 AM Saravana Kannan <[email protected]> wrote:
> > On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd <[email protected]> wrote:
> > > Quoting [email protected] (2021-02-08 01:49:45)
> > > > Do you plan to take this patch for v5.12?
> > > > If fw_devlink will remain set to ON for v5.12, some of our boards will
> > > > no longer boot without this patch.
> > >
> > > Is fw_devlink defaulted to on for v5.12?
> >
> > Yes.
>
> Have all issues been identified and understood?
> Have all issues been fixed, reviewed, and committed?
> Have all fixes entered linux-next?
> Have all fixes been migrated from submaintainers to maintainers?
>
> We're already at v5.11-rc7.
> Yes, we can get fixes into v5.12-rc7. Or v5.12-rc9...

Yeah, I'm leaning toward not making it the default for 5.12-rc1 because
not everything seems to be working, let's see how the rest of the week
goes...

thanks,

greg k-h

2021-02-10 09:17:17

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks

Hi Saravana,

On Wed, Feb 10, 2021 at 9:57 AM Saravana Kannan <[email protected]> wrote:
> On Wed, Feb 10, 2021 at 12:51 AM Geert Uytterhoeven
> <[email protected]> wrote:
> > On Wed, Feb 10, 2021 at 1:57 AM Saravana Kannan <[email protected]> wrote:
> > > On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd <[email protected]> wrote:
> > > > Quoting [email protected] (2021-02-08 01:49:45)
> > > > > Do you plan to take this patch for v5.12?
> > > > > If fw_devlink will remain set to ON for v5.12, some of our boards will
> > > > > no longer boot without this patch.
> > > >
> > > > Is fw_devlink defaulted to on for v5.12?
> > >
> > > Yes.
> >
> > Have all issues been identified and understood?
> > Have all issues been fixed, reviewed, and committed?
> > Have all fixes entered linux-next?
> > Have all fixes been migrated from submaintainers to maintainers?
>
> I'm hoping Tudor has reported and the fixes that have gone in so far
> addressed all his issues. Otherwise, they need to be reported so we
> can fix them.
>
> As of now, there's no pending fix that hasn't landed in maintainer
> trees. So that's good.

You're talking about driver core fixes.
What about driver fixes? E.g. pull request for (arm-)soc should be
srnt before -rc6.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2021-02-10 16:24:38

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] clk: at91: Fix the declaration of the clocks

On Wed, Feb 10, 2021 at 10:00:14AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 10, 2021 at 09:51:14AM +0100, Geert Uytterhoeven wrote:
> > Hi Saravana,
> >
> > On Wed, Feb 10, 2021 at 1:57 AM Saravana Kannan <[email protected]> wrote:
> > > On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd <[email protected]> wrote:
> > > > Quoting [email protected] (2021-02-08 01:49:45)
> > > > > Do you plan to take this patch for v5.12?
> > > > > If fw_devlink will remain set to ON for v5.12, some of our boards will
> > > > > no longer boot without this patch.
> > > >
> > > > Is fw_devlink defaulted to on for v5.12?
> > >
> > > Yes.
> >
> > Have all issues been identified and understood?
> > Have all issues been fixed, reviewed, and committed?
> > Have all fixes entered linux-next?
> > Have all fixes been migrated from submaintainers to maintainers?

This can never be true for these types of per platform issues. There are
folks that test linux-next Then there are ones that test rc1. And
(unfortunately) so-on ending at testing only LTS releases.

> > We're already at v5.11-rc7.
> > Yes, we can get fixes into v5.12-rc7. Or v5.12-rc9...
>
> Yeah, I'm leaning toward not making it the default for 5.12-rc1 because
> not everything seems to be working, let's see how the rest of the week
> goes...

I think there's some value waiting until after rc1 to turn off if just
to find a few more issues.

Rob