This patchset adds two device-tree based function enhancements to the
Banana Pi M2 Zero board.
PATCH 1 adds the HDMI output. (Note: although the connector type is set
to "c" in the device tree, currently sun8i-dw-hdmi doesn't check it and
still set the type to HDMI-A).
PATCH 2 adds VDD-CPUX regulator, and link it to DVFS.
Icenowy Zheng (2):
ARM: sun8i: h3: enable HDMI output on Banana Pi M2 Zero
ARM: sun8i: h3: add SY8113B regulator on Banana Pi M2 Zero board
.../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 46 +++++++++++++++++++
1 file changed, 46 insertions(+)
--
2.17.1
Banana Pi M2 Zero board has a miniHDMI port connected to the HDMI
controller of Allwinner H3 SoC.
Enable the HDMI output in Banana Pi M2 Zero device tree.
Signed-off-by: Icenowy Zheng <[email protected]>
---
.../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
index 7d01f9322658..eb61dcf32797 100644
--- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
+++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
@@ -26,6 +26,17 @@
stdout-path = "serial0:115200n8";
};
+ hdmi-connector {
+ compatible = "hdmi-connector";
+ type = "c";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi_out_con>;
+ };
+ };
+ };
+
leds {
compatible = "gpio-leds";
pinctrl-names = "default";
@@ -55,10 +66,24 @@
};
};
+&de {
+ status = "okay";
+};
+
&ehci0 {
status = "okay";
};
+&hdmi {
+ status = "okay";
+};
+
+&hdmi_out {
+ hdmi_out_con: endpoint {
+ remote-endpoint = <&hdmi_con_in>;
+ };
+};
+
&mmc0 {
vmmc-supply = <®_vcc3v3>;
bus-width = <4>;
--
2.17.1
Hi,
On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
> Banana Pi M2 Zero board has a miniHDMI port connected to the HDMI
> controller of Allwinner H3 SoC.
>
> Enable the HDMI output in Banana Pi M2 Zero device tree.
>
> Signed-off-by: Icenowy Zheng <[email protected]>
> ---
> .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> index 7d01f9322658..eb61dcf32797 100644
> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> @@ -26,6 +26,17 @@
> stdout-path = "serial0:115200n8";
> };
>
> + hdmi-connector {
> + compatible = "hdmi-connector";
> + type = "c";
This is not one of the connector type declared in DRM, how is it
exposed to the userspace?
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
于 2018年7月11日 GMT+08:00 下午11:05:32, Maxime Ripard <[email protected]> 写到:
>Hi,
>
>On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
>> Banana Pi M2 Zero board has a miniHDMI port connected to the HDMI
>> controller of Allwinner H3 SoC.
>>
>> Enable the HDMI output in Banana Pi M2 Zero device tree.
>>
>> Signed-off-by: Icenowy Zheng <[email protected]>
>> ---
>> .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 25
>+++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> index 7d01f9322658..eb61dcf32797 100644
>> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> @@ -26,6 +26,17 @@
>> stdout-path = "serial0:115200n8";
>> };
>>
>> + hdmi-connector {
>> + compatible = "hdmi-connector";
>> + type = "c";
>
>This is not one of the connector type declared in DRM, how is it
>exposed to the userspace?
So just use "A" here (because of single link)?
>
>Maxime
Dne sreda, 11. julij 2018 ob 17:05:32 CEST je Maxime Ripard napisal(a):
> Hi,
>
> On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
> > Banana Pi M2 Zero board has a miniHDMI port connected to the HDMI
> > controller of Allwinner H3 SoC.
> >
> > Enable the HDMI output in Banana Pi M2 Zero device tree.
> >
> > Signed-off-by: Icenowy Zheng <[email protected]>
> > ---
> >
> > .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 25 +++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> > b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts index
> > 7d01f9322658..eb61dcf32797 100644
> > --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> > +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> > @@ -26,6 +26,17 @@
> >
> > stdout-path = "serial0:115200n8";
> >
> > };
> >
> > + hdmi-connector {
> > + compatible = "hdmi-connector";
> > + type = "c";
>
> This is not one of the connector type declared in DRM, how is it
> exposed to the userspace?
DT binding allows it:
HDMI Connector
==============
Required properties:
- compatible: "hdmi-connector"
- type: the HDMI connector type: "a", "b", "c", "d" or "e"
but DW HDMI bridge driver hardcodes it to type A. Actually, kernel has defines
only for type A and B.
Actually, many HDMI drivers have type A hardcoded...
Best regards,
Jernej
于 2018年7月11日 GMT+08:00 下午11:14:19, "Jernej Škrabec" <[email protected]> 写到:
>Dne sreda, 11. julij 2018 ob 17:05:32 CEST je Maxime Ripard napisal(a):
>> Hi,
>>
>> On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
>> > Banana Pi M2 Zero board has a miniHDMI port connected to the HDMI
>> > controller of Allwinner H3 SoC.
>> >
>> > Enable the HDMI output in Banana Pi M2 Zero device tree.
>> >
>> > Signed-off-by: Icenowy Zheng <[email protected]>
>> > ---
>> >
>> > .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 25
>+++++++++++++++++++
>> > 1 file changed, 25 insertions(+)
>> >
>> > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> > b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts index
>> > 7d01f9322658..eb61dcf32797 100644
>> > --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> > +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> > @@ -26,6 +26,17 @@
>> >
>> > stdout-path = "serial0:115200n8";
>> >
>> > };
>> >
>> > + hdmi-connector {
>> > + compatible = "hdmi-connector";
>> > + type = "c";
>>
>> This is not one of the connector type declared in DRM, how is it
>> exposed to the userspace?
>
>DT binding allows it:
>
>HDMI Connector
>==============
>
>Required properties:
>- compatible: "hdmi-connector"
>- type: the HDMI connector type: "a", "b", "c", "d" or "e"
>
>but DW HDMI bridge driver hardcodes it to type A. Actually, kernel has
>defines
>only for type A and B.
I assume it's for single link/dual link.
>
>Actually, many HDMI drivers have type A hardcoded...
>
>Best regards,
>Jernej
On Wed, Jul 11, 2018 at 11:15:50PM +0800, Icenowy Zheng wrote:
>
>
> 于 2018年7月11日 GMT+08:00 下午11:05:32, Maxime Ripard <[email protected]> 写到:
> >Hi,
> >
> >On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
> >> Banana Pi M2 Zero board has a miniHDMI port connected to the HDMI
> >> controller of Allwinner H3 SoC.
> >>
> >> Enable the HDMI output in Banana Pi M2 Zero device tree.
> >>
> >> Signed-off-by: Icenowy Zheng <[email protected]>
> >> ---
> >> .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 25
> >+++++++++++++++++++
> >> 1 file changed, 25 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> index 7d01f9322658..eb61dcf32797 100644
> >> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> @@ -26,6 +26,17 @@
> >> stdout-path = "serial0:115200n8";
> >> };
> >>
> >> + hdmi-connector {
> >> + compatible = "hdmi-connector";
> >> + type = "c";
> >
> >This is not one of the connector type declared in DRM, how is it
> >exposed to the userspace?
>
> So just use "A" here (because of single link)?
If the connector type is C, it should be C, and DRM / driver adjusted
to handle it.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
于 2018年7月12日 GMT+08:00 下午2:46:01, Maxime Ripard <[email protected]> 写到:
>On Wed, Jul 11, 2018 at 11:15:50PM +0800, Icenowy Zheng wrote:
>>
>>
>> 于 2018年7月11日 GMT+08:00 下午11:05:32, Maxime Ripard
><[email protected]> 写到:
>> >Hi,
>> >
>> >On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
>> >> Banana Pi M2 Zero board has a miniHDMI port connected to the HDMI
>> >> controller of Allwinner H3 SoC.
>> >>
>> >> Enable the HDMI output in Banana Pi M2 Zero device tree.
>> >>
>> >> Signed-off-by: Icenowy Zheng <[email protected]>
>> >> ---
>> >> .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 25
>> >+++++++++++++++++++
>> >> 1 file changed, 25 insertions(+)
>> >>
>> >> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> index 7d01f9322658..eb61dcf32797 100644
>> >> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> @@ -26,6 +26,17 @@
>> >> stdout-path = "serial0:115200n8";
>> >> };
>> >>
>> >> + hdmi-connector {
>> >> + compatible = "hdmi-connector";
>> >> + type = "c";
>> >
>> >This is not one of the connector type declared in DRM, how is it
>> >exposed to the userspace?
>>
>> So just use "A" here (because of single link)?
>
>If the connector type is C, it should be C, and DRM / driver adjusted
>to handle it.
Okay I won't change this property, if there's any further revisions.
For DRM driver, I think it can be an independent patchset.
>
>Maxime
On Thu, Jul 12, 2018 at 03:09:55PM +0800, Icenowy Zheng wrote:
> 于 2018年7月12日 GMT+08:00 下午2:46:01, Maxime Ripard <[email protected]> 写到:
> >On Wed, Jul 11, 2018 at 11:15:50PM +0800, Icenowy Zheng wrote:
> >>
> >>
> >> 于 2018年7月11日 GMT+08:00 下午11:05:32, Maxime Ripard
> ><[email protected]> 写到:
> >> >Hi,
> >> >
> >> >On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
> >> >> Banana Pi M2 Zero board has a miniHDMI port connected to the HDMI
> >> >> controller of Allwinner H3 SoC.
> >> >>
> >> >> Enable the HDMI output in Banana Pi M2 Zero device tree.
> >> >>
> >> >> Signed-off-by: Icenowy Zheng <[email protected]>
> >> >> ---
> >> >> .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 25
> >> >+++++++++++++++++++
> >> >> 1 file changed, 25 insertions(+)
> >> >>
> >> >> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> index 7d01f9322658..eb61dcf32797 100644
> >> >> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> @@ -26,6 +26,17 @@
> >> >> stdout-path = "serial0:115200n8";
> >> >> };
> >> >>
> >> >> + hdmi-connector {
> >> >> + compatible = "hdmi-connector";
> >> >> + type = "c";
> >> >
> >> >This is not one of the connector type declared in DRM, how is it
> >> >exposed to the userspace?
> >>
> >> So just use "A" here (because of single link)?
> >
> >If the connector type is C, it should be C, and DRM / driver adjusted
> >to handle it.
>
> Okay I won't change this property, if there's any further revisions.
>
> For DRM driver, I think it can be an independent patchset.
Not really, since it's going to break userspace as soon as you merge
that other patchset.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
于 2018年7月12日 GMT+08:00 下午10:53:06, Maxime Ripard <[email protected]> 写到:
>On Thu, Jul 12, 2018 at 03:09:55PM +0800, Icenowy Zheng wrote:
>> 于 2018年7月12日 GMT+08:00 下午2:46:01, Maxime Ripard
><[email protected]> 写到:
>> >On Wed, Jul 11, 2018 at 11:15:50PM +0800, Icenowy Zheng wrote:
>> >>
>> >>
>> >> 于 2018年7月11日 GMT+08:00 下午11:05:32, Maxime Ripard
>> ><[email protected]> 写到:
>> >> >Hi,
>> >> >
>> >> >On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
>> >> >> Banana Pi M2 Zero board has a miniHDMI port connected to the
>HDMI
>> >> >> controller of Allwinner H3 SoC.
>> >> >>
>> >> >> Enable the HDMI output in Banana Pi M2 Zero device tree.
>> >> >>
>> >> >> Signed-off-by: Icenowy Zheng <[email protected]>
>> >> >> ---
>> >> >> .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 25
>> >> >+++++++++++++++++++
>> >> >> 1 file changed, 25 insertions(+)
>> >> >>
>> >> >> diff --git
>a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> >b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> >> index 7d01f9322658..eb61dcf32797 100644
>> >> >> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> >> @@ -26,6 +26,17 @@
>> >> >> stdout-path = "serial0:115200n8";
>> >> >> };
>> >> >>
>> >> >> + hdmi-connector {
>> >> >> + compatible = "hdmi-connector";
>> >> >> + type = "c";
>> >> >
>> >> >This is not one of the connector type declared in DRM, how is it
>> >> >exposed to the userspace?
>> >>
>> >> So just use "A" here (because of single link)?
>> >
>> >If the connector type is C, it should be C, and DRM / driver
>adjusted
>> >to handle it.
>>
>> Okay I won't change this property, if there's any further revisions.
>>
>> For DRM driver, I think it can be an independent patchset.
>
>Not really, since it's going to break userspace as soon as you merge
>that other patchset.
Should we bother the DRM maintainer to ask for any advice?
>
>Maxime
>
>--
>Maxime Ripard, Bootlin (formerly Free Electrons)
>Embedded Linux and Kernel engineering
>https://bootlin.com
>
>_______________________________________________
>linux-arm-kernel mailing list
>[email protected]
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Fri, Jul 13, 2018 at 10:28:08AM +0800, Icenowy Zheng wrote:
>
>
> 于 2018年7月12日 GMT+08:00 下午10:53:06, Maxime Ripard <[email protected]> 写到:
> >On Thu, Jul 12, 2018 at 03:09:55PM +0800, Icenowy Zheng wrote:
> >> 于 2018年7月12日 GMT+08:00 下午2:46:01, Maxime Ripard
> ><[email protected]> 写到:
> >> >On Wed, Jul 11, 2018 at 11:15:50PM +0800, Icenowy Zheng wrote:
> >> >>
> >> >>
> >> >> 于 2018年7月11日 GMT+08:00 下午11:05:32, Maxime Ripard
> >> ><[email protected]> 写到:
> >> >> >Hi,
> >> >> >
> >> >> >On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
> >> >> >> Banana Pi M2 Zero board has a miniHDMI port connected to the
> >HDMI
> >> >> >> controller of Allwinner H3 SoC.
> >> >> >>
> >> >> >> Enable the HDMI output in Banana Pi M2 Zero device tree.
> >> >> >>
> >> >> >> Signed-off-by: Icenowy Zheng <[email protected]>
> >> >> >> ---
> >> >> >> .../dts/sun8i-h2-plus-bananapi-m2-zero.dts | 25
> >> >> >+++++++++++++++++++
> >> >> >> 1 file changed, 25 insertions(+)
> >> >> >>
> >> >> >> diff --git
> >a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >> index 7d01f9322658..eb61dcf32797 100644
> >> >> >> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >> @@ -26,6 +26,17 @@
> >> >> >> stdout-path = "serial0:115200n8";
> >> >> >> };
> >> >> >>
> >> >> >> + hdmi-connector {
> >> >> >> + compatible = "hdmi-connector";
> >> >> >> + type = "c";
> >> >> >
> >> >> >This is not one of the connector type declared in DRM, how is it
> >> >> >exposed to the userspace?
> >> >>
> >> >> So just use "A" here (because of single link)?
> >> >
> >> >If the connector type is C, it should be C, and DRM / driver
> >adjusted
> >> >to handle it.
> >>
> >> Okay I won't change this property, if there's any further revisions.
> >>
> >> For DRM driver, I think it can be an independent patchset.
> >
> >Not really, since it's going to break userspace as soon as you merge
> >that other patchset.
>
> Should we bother the DRM maintainer to ask for any advice?
You can if you want.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
Hi Icenowy,
On Wed, Jul 11, 2018 at 11:25 PM Icenowy Zheng <[email protected]> wrote:
>
> Banana Pi M2 Zero board has a miniHDMI port connected to the HDMI
> controller of Allwinner H3 SoC.
>
> Enable the HDMI output in Banana Pi M2 Zero device tree.
>
> Signed-off-by: Icenowy Zheng <[email protected]>
This is identical to the patch I'd cooked up to do this, so this is:
Tested-by: Julian Calaby <[email protected]>
Thanks,
--
Julian Calaby
Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/