2018-01-02 04:03:26

by Wei Yongjun

Subject: [PATCH -next] tee: shm: make local function __tee_shm_alloc() static

Fixes the following sparse warnings:

drivers/tee/tee_shm.c:115:16: warning:
symbol '__tee_shm_alloc' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/tee/tee_shm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
index 04e1b8b..13b4de1 100644
--- a/drivers/tee/tee_shm.c
+++ b/drivers/tee/tee_shm.c
@@ -112,9 +112,9 @@ static int tee_shm_op_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma)
.mmap = tee_shm_op_mmap,
};

-struct tee_shm *__tee_shm_alloc(struct tee_context *ctx,
- struct tee_device *teedev,
- size_t size, u32 flags)
+static struct tee_shm *__tee_shm_alloc(struct tee_context *ctx,
+ struct tee_device *teedev,
+ size_t size, u32 flags)
{
struct tee_shm_pool_mgr *poolm = NULL;
struct tee_shm *shm;

2018-01-02 07:46:33

by Jens Wiklander

Subject: Re: [PATCH -next] tee: shm: make local function __tee_shm_alloc() static

On Tue, Jan 2, 2018 at 5:09 AM, Wei Yongjun <[email protected]> wrote:
> Fixes the following sparse warnings:
>
> drivers/tee/tee_shm.c:115:16: warning:
> symbol '__tee_shm_alloc' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/tee/tee_shm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
> index 04e1b8b..13b4de1 100644
> --- a/drivers/tee/tee_shm.c
> +++ b/drivers/tee/tee_shm.c
> @@ -112,9 +112,9 @@ static int tee_shm_op_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma)
> .mmap = tee_shm_op_mmap,
> };
>
> -struct tee_shm *__tee_shm_alloc(struct tee_context *ctx,
> - struct tee_device *teedev,
> - size_t size, u32 flags)
> +static struct tee_shm *__tee_shm_alloc(struct tee_context *ctx,
> + struct tee_device *teedev,
> + size_t size, u32 flags)
> {
> struct tee_shm_pool_mgr *poolm = NULL;
> struct tee_shm *shm;
>

Thanks, but I've already picked up the same patch from Colin King a
few days ago.

/Jens