2021-11-15 13:44:15

by Johan Hovold

Subject: [PATCH 1/3] serial: liteuart: fix compile testing

Allow the liteuart driver to be compile tested by fixing the broken
Kconfig dependencies.

Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
Cc: [email protected] # 5.11
Cc: Filip Kokosinski <[email protected]>
Cc: Mateusz Holenko <[email protected]>
Cc: Stafford Horne <[email protected]>
Signed-off-by: Johan Hovold <[email protected]>
---
drivers/tty/serial/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 6ff94cfcd9db..67de892e0947 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1531,9 +1531,9 @@ config SERIAL_MILBEAUT_USIO_CONSOLE

config SERIAL_LITEUART
tristate "LiteUART serial port support"
+ depends on LITEX || COMPILE_TEST
depends on HAS_IOMEM
- depends on OF || COMPILE_TEST
- depends on LITEX
+ depends on OF
select SERIAL_CORE
help
This driver is for the FPGA-based LiteUART serial controller from LiteX
--
2.32.0

2021-11-16 00:12:46

by Stafford Horne

Subject: Re: [PATCH 1/3] serial: liteuart: fix compile testing

On Mon, Nov 15, 2021 at 02:37:43PM +0100, Johan Hovold wrote:
> Allow the liteuart driver to be compile tested by fixing the broken
> Kconfig dependencies.
>
> Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
> Cc: [email protected] # 5.11
> Cc: Filip Kokosinski <[email protected]>
> Cc: Mateusz Holenko <[email protected]>
> Cc: Stafford Horne <[email protected]>
> Signed-off-by: Johan Hovold <[email protected]>

Reviewed-by: Stafford Horne <[email protected]>

> ---
> drivers/tty/serial/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 6ff94cfcd9db..67de892e0947 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1531,9 +1531,9 @@ config SERIAL_MILBEAUT_USIO_CONSOLE
>
> config SERIAL_LITEUART
> tristate "LiteUART serial port support"
> + depends on LITEX || COMPILE_TEST
> depends on HAS_IOMEM
> - depends on OF || COMPILE_TEST
> - depends on LITEX
> + depends on OF
> select SERIAL_CORE
> help
> This driver is for the FPGA-based LiteUART serial controller from LiteX
> --
> 2.32.0
>

2021-11-16 15:45:13

by Andy Shevchenko

Subject: Re: [PATCH 1/3] serial: liteuart: fix compile testing

On Mon, Nov 15, 2021 at 3:44 PM Johan Hovold <[email protected]> wrote:
>
> Allow the liteuart driver to be compile tested by fixing the broken
> Kconfig dependencies.

...

> config SERIAL_LITEUART
> tristate "LiteUART serial port support"
> + depends on LITEX || COMPILE_TEST
> depends on HAS_IOMEM
> - depends on OF || COMPILE_TEST
> - depends on LITEX

> + depends on OF

AFAICS this is optional and prevents compile testing in some cases.

> select SERIAL_CORE
> help
> This driver is for the FPGA-based LiteUART serial controller from LiteX


--
With Best Regards,
Andy Shevchenko

2021-11-17 09:07:11

by Johan Hovold

Subject: Re: [PATCH 1/3] serial: liteuart: fix compile testing

On Tue, Nov 16, 2021 at 05:44:14PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 15, 2021 at 3:44 PM Johan Hovold <[email protected]> wrote:
> >
> > Allow the liteuart driver to be compile tested by fixing the broken
> > Kconfig dependencies.
>
> ...
>
> > config SERIAL_LITEUART
> > tristate "LiteUART serial port support"
> > + depends on LITEX || COMPILE_TEST
> > depends on HAS_IOMEM
> > - depends on OF || COMPILE_TEST
> > - depends on LITEX
>
> > + depends on OF
>
> AFAICS this is optional and prevents compile testing in some cases.

Yeah, you're right; that clause should stay. I'll send a v2. Thanks.

> > select SERIAL_CORE
> > help
> > This driver is for the FPGA-based LiteUART serial controller from LiteX

Johan