On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień <[email protected]> wrote:
> Commit 2cfa4b311acc ("platform/x86: intel-hid: Support 5 button array")
> contains some coding style cleanups compared to the code it was based
> on. This patch series "backports" these cleanups to the rest of the
> driver in order to make it more self-consistent and removes a redundant
> set_bit() call as a bonus.
>
> This series was not tested on hardware supported by intel-hid.
Alex, do you have an access to hardware to test? I wouldn't going to
apply this until I get your tag(s) (in the best case
Reviewed-and-tested-by).
--
With Best Regards,
Andy Shevchenko
On Thu, Mar 2, 2017 at 7:03 AM, Andy Shevchenko
<[email protected]> wrote:
> On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień <[email protected]> wrote:
>> Commit 2cfa4b311acc ("platform/x86: intel-hid: Support 5 button array")
>> contains some coding style cleanups compared to the code it was based
>> on. This patch series "backports" these cleanups to the rest of the
>> driver in order to make it more self-consistent and removes a redundant
>> set_bit() call as a bonus.
>>
>> This series was not tested on hardware supported by intel-hid.
>
> Alex, do you have an access to hardware to test? I wouldn't going to
> apply this until I get your tag(s) (in the best case
> Reviewed-and-tested-by).
The patches look good and tested on Latitude 7480
Reviewed-and-tested-by: Alex Hung <[email protected]>
>
> --
> With Best Regards,
> Andy Shevchenko
On Thu, Mar 2, 2017 at 12:17 PM, Alex Hung <[email protected]> wrote:
> On Thu, Mar 2, 2017 at 7:03 AM, Andy Shevchenko
> <[email protected]> wrote:
>> On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień <[email protected]> wrote:
>>> Commit 2cfa4b311acc ("platform/x86: intel-hid: Support 5 button array")
>>> contains some coding style cleanups compared to the code it was based
>>> on. This patch series "backports" these cleanups to the rest of the
>>> driver in order to make it more self-consistent and removes a redundant
>>> set_bit() call as a bonus.
>>>
>>> This series was not tested on hardware supported by intel-hid.
>>
>> Alex, do you have an access to hardware to test? I wouldn't going to
>> apply this until I get your tag(s) (in the best case
>> Reviewed-and-tested-by).
>
> The patches look good and tested on Latitude 7480
>
> Reviewed-and-tested-by: Alex Hung <[email protected]>
Pushed to testing.
Thanks.
--
With Best Regards,
Andy Shevchenko