2015-06-26 19:00:30

by Randy Dunlap

Subject: [PATCH -next] leds: fix aat1290 build errors

From: Randy Dunlap <[email protected]>

Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m
by restricting LEDS_AAT1290 to =m if V4L2_FLASH_LED_CLASS=m.

drivers/built-in.o: In function `aat1290_led_remove':
leds-aat1290.c:(.text+0xe5d77): undefined reference to `v4l2_flash_release'
drivers/built-in.o: In function `aat1290_led_probe':
leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Jacek Anaszewski <[email protected]>
Cc: Bryan Wu <[email protected]>
Cc: Richard Purdie <[email protected]>
---
drivers/leds/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20150626.orig/drivers/leds/Kconfig
+++ linux-next-20150626/drivers/leds/Kconfig
@@ -42,6 +42,7 @@ config LEDS_88PM860X
config LEDS_AAT1290
tristate "LED support for the AAT1290"
depends on LEDS_CLASS_FLASH
+ depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
depends on GPIOLIB
depends on OF
depends on PINCTRL

2015-06-29 14:44:29

by Jacek Anaszewski

Subject: Re: [PATCH -next] leds: fix aat1290 build errors

Hi Randy,

Thanks for the patch.

On 06/26/2015 09:00 PM, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m
> by restricting LEDS_AAT1290 to =m if V4L2_FLASH_LED_CLASS=m.
>
> drivers/built-in.o: In function `aat1290_led_remove':
> leds-aat1290.c:(.text+0xe5d77): undefined reference to `v4l2_flash_release'
> drivers/built-in.o: In function `aat1290_led_probe':
> leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Jacek Anaszewski <[email protected]>
> Cc: Bryan Wu <[email protected]>
> Cc: Richard Purdie <[email protected]>
> ---
> drivers/leds/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20150626.orig/drivers/leds/Kconfig
> +++ linux-next-20150626/drivers/leds/Kconfig
> @@ -42,6 +42,7 @@ config LEDS_88PM860X
> config LEDS_AAT1290
> tristate "LED support for the AAT1290"
> depends on LEDS_CLASS_FLASH
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> depends on GPIOLIB
> depends on OF
> depends on PINCTRL
>

Acked-by: Jacek Anaszewski <[email protected]>

--
Best Regards,
Jacek Anaszewski

2015-06-29 17:09:19

by Bryan Wu

Subject: Re: [PATCH -next] leds: fix aat1290 build errors

On Mon, Jun 29, 2015 at 7:44 AM, Jacek Anaszewski
<[email protected]> wrote:
> Hi Randy,
>
> Thanks for the patch.
>
>
> On 06/26/2015 09:00 PM, Randy Dunlap wrote:
>>
>> From: Randy Dunlap <[email protected]>
>>
>> Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m
>> by restricting LEDS_AAT1290 to =m if V4L2_FLASH_LED_CLASS=m.
>>
>> drivers/built-in.o: In function `aat1290_led_remove':
>> leds-aat1290.c:(.text+0xe5d77): undefined reference to
>> `v4l2_flash_release'
>> drivers/built-in.o: In function `aat1290_led_probe':
>> leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'
>>
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Cc: Jacek Anaszewski <[email protected]>
>> Cc: Bryan Wu <[email protected]>
>> Cc: Richard Purdie <[email protected]>
>> ---
>> drivers/leds/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- linux-next-20150626.orig/drivers/leds/Kconfig
>> +++ linux-next-20150626/drivers/leds/Kconfig
>> @@ -42,6 +42,7 @@ config LEDS_88PM860X
>> config LEDS_AAT1290
>> tristate "LED support for the AAT1290"
>> depends on LEDS_CLASS_FLASH
>> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
>> depends on GPIOLIB
>> depends on OF
>> depends on PINCTRL
>>
>
> Acked-by: Jacek Anaszewski <[email protected]>
>

Good fix. thanks.
I merged into my tree.
-Bryan