2020-07-02 11:12:39

by Paul Menzel

Subject: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`

Running `make savedefconfig` creates by default `defconfig`, which is,
currently, on git’s radar, for example, `git status` lists this file as
untracked.

So, add the file to `.gitignore`, so it’s ignored by git.

Cc: [email protected]
Signed-off-by: Paul Menzel <[email protected]>
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)

diff --git a/.gitignore b/.gitignore
index 87b9dd8a163b..f07500889fba 100644
--- a/.gitignore
+++ b/.gitignore
@@ -143,6 +143,9 @@ x509.genkey
/allrandom.config
/allyes.config

+# Kconfig presets, default savedefconfg output
+/defconfig
+
# Kdevelop4
*.kdev4

--
2.27.0

2020-07-02 11:36:40

by Greg Kroah-Hartman

Subject: Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`

On Thu, Jul 02, 2020 at 01:12:00PM +0200, Paul Menzel wrote:
> Running `make savedefconfig` creates by default `defconfig`, which is,
> currently, on git’s radar, for example, `git status` lists this file as
> untracked.
>
> So, add the file to `.gitignore`, so it’s ignored by git.
>
> Cc: [email protected]
> Signed-off-by: Paul Menzel <[email protected]>

Acked-by: Greg Kroah-Hartman <[email protected]>

2020-07-03 15:52:58

by Masahiro Yamada

Subject: Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`

On Thu, Jul 2, 2020 at 8:12 PM Paul Menzel <[email protected]> wrote:
>
> Running `make savedefconfig` creates by default `defconfig`, which is,
> currently, on git’s radar, for example, `git status` lists this file as
> untracked.
>
> So, add the file to `.gitignore`, so it’s ignored by git.
>
> Cc: [email protected]
> Signed-off-by: Paul Menzel <[email protected]>
> ---
> .gitignore | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 87b9dd8a163b..f07500889fba 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -143,6 +143,9 @@ x509.genkey
> /allrandom.config
> /allyes.config
>
> +# Kconfig presets, default savedefconfg output


I fixed up the typo, then applied to linux-kbuild. Thanks.

"savedefconfg" -> "savedefconfig"

(sorry, it was my typo.)



> +/defconfig
> +
> # Kdevelop4
> *.kdev4
>
> --
> 2.27.0
>


--
Best Regards
Masahiro Yamada

2020-07-05 07:18:36

by Masahiro Yamada

Subject: Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`

On Thu, Jul 2, 2020 at 8:12 PM Paul Menzel <[email protected]> wrote:
>
> Running `make savedefconfig` creates by default `defconfig`, which is,
> currently, on git’s radar, for example, `git status` lists this file as
> untracked.
>
> So, add the file to `.gitignore`, so it’s ignored by git.
>
> Cc: [email protected]
> Signed-off-by: Paul Menzel <[email protected]>
> ---
> .gitignore | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 87b9dd8a163b..f07500889fba 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -143,6 +143,9 @@ x509.genkey
> /allrandom.config
> /allyes.config
>
> +# Kconfig presets, default savedefconfg output


I just noticed this comment is wrong
since 'defconfig' is not a preset.

I will change it to 'Kconfig savedefconfig output'.

Thanks.


> +/defconfig
> +
> # Kdevelop4
> *.kdev4
>
> --
> 2.27.0
>


--
Best Regards
Masahiro Yamada

2020-07-05 07:20:23

by Paul Menzel

Subject: Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`

Dear Masahiro,


Am 05.07.20 um 09:14 schrieb Masahiro Yamada:
> On Thu, Jul 2, 2020 at 8:12 PM Paul Menzel <[email protected]> wrote:
>>
>> Running `make savedefconfig` creates by default `defconfig`, which is,
>> currently, on git’s radar, for example, `git status` lists this file as
>> untracked.
>>
>> So, add the file to `.gitignore`, so it’s ignored by git.
>>
>> Cc: [email protected]
>> Signed-off-by: Paul Menzel <[email protected]>
>> ---
>> .gitignore | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 87b9dd8a163b..f07500889fba 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -143,6 +143,9 @@ x509.genkey
>> /allrandom.config
>> /allyes.config
>>
>> +# Kconfig presets, default savedefconfg output
>
>
> I just noticed this comment is wrong
> since 'defconfig' is not a preset.
>
> I will change it to 'Kconfig savedefconfig output'.

Thank you for finding my error and correcting it.

I couldn’t find out more about *presets*.

$ git grep -i preset scripts/kconfig/
$

Where can I look, so I won’t repeat the same mistake next time?

>> +/defconfig
>> +
>> # Kdevelop4
>> *.kdev4
>>
>> --
>> 2.27.0

Kind regards,

Paul

2020-07-05 15:37:03

by Masahiro Yamada

Subject: Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`

On Sun, Jul 5, 2020 at 4:19 PM Paul Menzel <[email protected]> wrote:
>
> Dear Masahiro,
>
>
> Am 05.07.20 um 09:14 schrieb Masahiro Yamada:
> > On Thu, Jul 2, 2020 at 8:12 PM Paul Menzel <[email protected]> wrote:
> >>
> >> Running `make savedefconfig` creates by default `defconfig`, which is,
> >> currently, on git’s radar, for example, `git status` lists this file as
> >> untracked.
> >>
> >> So, add the file to `.gitignore`, so it’s ignored by git.
> >>
> >> Cc: [email protected]
> >> Signed-off-by: Paul Menzel <[email protected]>
> >> ---
> >> .gitignore | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/.gitignore b/.gitignore
> >> index 87b9dd8a163b..f07500889fba 100644
> >> --- a/.gitignore
> >> +++ b/.gitignore
> >> @@ -143,6 +143,9 @@ x509.genkey
> >> /allrandom.config
> >> /allyes.config
> >>
> >> +# Kconfig presets, default savedefconfg output
> >
> >
> > I just noticed this comment is wrong
> > since 'defconfig' is not a preset.
> >
> > I will change it to 'Kconfig savedefconfig output'.
>
> Thank you for finding my error and correcting it.
>
> I couldn’t find out more about *presets*.
>
> $ git grep -i preset scripts/kconfig/
> $
>
> Where can I look, so I won’t repeat the same mistake next time?


You can find 'preset' in
Documentation/kbuild/kconfig.rst
but it does appear in the source files.






--
Best Regards
Masahiro Yamada