2023-11-30 19:21:35

by Rob Clark

[permalink] [raw]
Subject: [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp

From: Rob Clark <[email protected]>

The UBWC settings need to match between the display and GPU. When we
updated the GPU settings, we forgot to make the corresponding update on
the display side.

Reported-by: Steev Klimaszewski <[email protected]>
Fixes: 07e6de738aa6 ("drm/msm/a690: Fix reg values for a690")
Signed-off-by: Rob Clark <[email protected]>
---
drivers/gpu/drm/msm/msm_mdss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
index 6865db1e3ce8..29bb38f0bb2c 100644
--- a/drivers/gpu/drm/msm/msm_mdss.c
+++ b/drivers/gpu/drm/msm/msm_mdss.c
@@ -545,7 +545,7 @@ static const struct msm_mdss_data sc8280xp_data = {
.ubwc_dec_version = UBWC_4_0,
.ubwc_swizzle = 6,
.ubwc_static = 1,
- .highest_bank_bit = 2,
+ .highest_bank_bit = 3,
.macrotile_mode = 1,
};

--
2.42.0


2023-11-30 21:25:13

by Steev Klimaszewski

[permalink] [raw]
Subject: Re: [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp

On Thu, Nov 30, 2023 at 1:21 PM Rob Clark <[email protected]> wrote:
>
> From: Rob Clark <[email protected]>
>
> The UBWC settings need to match between the display and GPU. When we
> updated the GPU settings, we forgot to make the corresponding update on
> the display side.
>
> Reported-by: Steev Klimaszewski <[email protected]>
> Fixes: 07e6de738aa6 ("drm/msm/a690: Fix reg values for a690")
> Signed-off-by: Rob Clark <[email protected]>
> ---
> drivers/gpu/drm/msm/msm_mdss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
> index 6865db1e3ce8..29bb38f0bb2c 100644
> --- a/drivers/gpu/drm/msm/msm_mdss.c
> +++ b/drivers/gpu/drm/msm/msm_mdss.c
> @@ -545,7 +545,7 @@ static const struct msm_mdss_data sc8280xp_data = {
> .ubwc_dec_version = UBWC_4_0,
> .ubwc_swizzle = 6,
> .ubwc_static = 1,
> - .highest_bank_bit = 2,
> + .highest_bank_bit = 3,
> .macrotile_mode = 1,
> };
>
> --
> 2.42.0
>
Tested on Lenovo Thinkpad X13s
Tested-by: Steev Klimaszewski <[email protected]>

2023-11-30 21:25:57

by Abhinav Kumar

[permalink] [raw]
Subject: Re: [Freedreno] [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp



On 11/30/2023 11:21 AM, Rob Clark wrote:
> From: Rob Clark <[email protected]>
>
> The UBWC settings need to match between the display and GPU. When we
> updated the GPU settings, we forgot to make the corresponding update on
> the display side.
>
> Reported-by: Steev Klimaszewski <[email protected]>
> Fixes: 07e6de738aa6 ("drm/msm/a690: Fix reg values for a690")
> Signed-off-by: Rob Clark <[email protected]>
> ---

Reviewed-by: Abhinav Kumar <[email protected]>

2023-12-03 11:27:18

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp


On Thu, 30 Nov 2023 11:21:18 -0800, Rob Clark wrote:
> The UBWC settings need to match between the display and GPU. When we
> updated the GPU settings, we forgot to make the corresponding update on
> the display side.
>
>

Applied, thanks!

[1/1] drm/msm/dpu: Correct UBWC settings for sc8280xp
https://gitlab.freedesktop.org/lumag/msm/-/commit/0b414c731432

Best regards,
--
Dmitry Baryshkov <[email protected]>