2017-08-21 19:31:49

by Boris Ostrovsky

Subject: Re: [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver

Adding maintainer (Dmitry).

-boris

On 08/21/2017 11:41 AM, Liang Yan wrote:
> Long pressed key could not show right in XEN vncviewer after tigervnc
> client changed the way how to send repeat keys, from "Down Up Down Up
> ..." to "Down Down Dow." By enable EV_REP bit here, XEN keyboard
> device will trigger default auto repeat process from input subsystem,
> and make auto repeat keys work correctly.
>
> Signed-off-by: Liang Yan <[email protected]>
> ---
> drivers/input/misc/xen-kbdfront.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/xen-kbdfront.c
> b/drivers/input/misc/xen-kbdfront.c
> index fa130e7b734c..0dce9830e2f4 100644
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
> kbd->id.product = 0xffff;
>
> __set_bit(EV_KEY, kbd->evbit);
> +__set_bit(EV_REP, kbd->evbit);
> for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
> __set_bit(i, kbd->keybit);
> for (i = KEY_OK; i < KEY_MAX; i++)
> --
> 2.14.0
>

2017-08-21 20:28:07

by Dmitry Torokhov

Subject: Re: [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver

On Mon, Aug 21, 2017 at 12:30 PM, Boris Ostrovsky
<[email protected]> wrote:
>
> Adding maintainer (Dmitry).

I can't seem to find the original in my mailbox nor in patchwork. Can
you please resend?

>
>
> -boris
>
> On 08/21/2017 11:41 AM, Liang Yan wrote:
> > Long pressed key could not show right in XEN vncviewer after tigervnc
> > client changed the way how to send repeat keys, from "Down Up Down Up
> > ..." to "Down Down Dow." By enable EV_REP bit here, XEN keyboard
> > device will trigger default auto repeat process from input subsystem,
> > and make auto repeat keys work correctly.
> >
> > Signed-off-by: Liang Yan <[email protected]>
> > ---
> > drivers/input/misc/xen-kbdfront.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/input/misc/xen-kbdfront.c
> > b/drivers/input/misc/xen-kbdfront.c
> > index fa130e7b734c..0dce9830e2f4 100644
> > --- a/drivers/input/misc/xen-kbdfront.c
> > +++ b/drivers/input/misc/xen-kbdfront.c
> > @@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
> > kbd->id.product = 0xffff;
> >
> > __set_bit(EV_KEY, kbd->evbit);
> > +__set_bit(EV_REP, kbd->evbit);
> > for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
> > __set_bit(i, kbd->keybit);
> > for (i = KEY_OK; i < KEY_MAX; i++)
> > --
> > 2.14.0
> >
>

Thanks.

--
Dmitry