On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu <[email protected]> wrote:
> On 24 May 2017 at 00:40, John Stultz <[email protected]> wrote:
>>
>> This fixes a regression introduced by ebc944613567 ("drm:
>> convert drivers to use drm_of_find_panel_or_bridge") that was
>> recently merged, causing HDMI output to not work.
>>
>> For the kirin driver, the port value should be 1 instead of 0,
>> so this oneline patch fixes it and gets graphics working again.
>>
>> Cc: Rob Herring <[email protected]>
>> Cc: Archit Taneja <[email protected]>
>> Cc: Philipp Zabel <[email protected]>
>> Cc: Maxime Ripard <[email protected]>
>> Cc: Sean Paul <[email protected]>
>> Cc: Dave Airlie <[email protected]>
>> Cc:
>> Xinliang Liu <[email protected]>
>> Fix-suggested-by: Rob Herring <[email protected]>
>> Signed-off-by: John Stultz <[email protected]>
>
>
> Looks good to me. Thanks for the patch.
>
> Reviewed-by:
> Xinliang Liu <[email protected]>
>
Just wanted to check in on this. Is there someone I'm missing from the
cc list on this?
thanks
-john
On Fri, Jun 2, 2017 at 2:00 PM, John Stultz <[email protected]> wrote:
> On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu <[email protected]> wrote:
>> On 24 May 2017 at 00:40, John Stultz <[email protected]> wrote:
>>>
>>> This fixes a regression introduced by ebc944613567 ("drm:
>>> convert drivers to use drm_of_find_panel_or_bridge") that was
>>> recently merged, causing HDMI output to not work.
>>>
>>> For the kirin driver, the port value should be 1 instead of 0,
>>> so this oneline patch fixes it and gets graphics working again.
>>>
>>> Cc: Rob Herring <[email protected]>
>>> Cc: Archit Taneja <[email protected]>
>>> Cc: Philipp Zabel <[email protected]>
>>> Cc: Maxime Ripard <[email protected]>
>>> Cc: Sean Paul <[email protected]>
>>> Cc: Dave Airlie <[email protected]>
>>> Cc:
>>> Xinliang Liu <[email protected]>
>>> Fix-suggested-by: Rob Herring <[email protected]>
>>> Signed-off-by: John Stultz <[email protected]>
>>
>>
>> Looks good to me. Thanks for the patch.
>>
>> Reviewed-by:
>> Xinliang Liu <[email protected]>
>>
>
> Just wanted to check in on this. Is there someone I'm missing from the
> cc list on this?
>
Hi John,
Apologies, I just saw this. Slipped through my cracks because it's not
posted on dri-devel.
The patch looks good. I'll pick it up in drm-misc-fixes if Dave
doesn't take it directly into drm-fixes.
Sean
> thanks
> -john
On Fri, Jun 2, 2017 at 2:52 PM, Sean Paul <[email protected]> wrote:
> On Fri, Jun 2, 2017 at 2:00 PM, John Stultz <[email protected]> wrote:
>> On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu <[email protected]> wrote:
>>> On 24 May 2017 at 00:40, John Stultz <[email protected]> wrote:
>>>>
>>>> This fixes a regression introduced by ebc944613567 ("drm:
>>>> convert drivers to use drm_of_find_panel_or_bridge") that was
>>>> recently merged, causing HDMI output to not work.
>>>>
>>>> For the kirin driver, the port value should be 1 instead of 0,
>>>> so this oneline patch fixes it and gets graphics working again.
>>>>
>>>> Cc: Rob Herring <[email protected]>
>>>> Cc: Archit Taneja <[email protected]>
>>>> Cc: Philipp Zabel <[email protected]>
>>>> Cc: Maxime Ripard <[email protected]>
>>>> Cc: Sean Paul <[email protected]>
>>>> Cc: Dave Airlie <[email protected]>
>>>> Cc:
>>>> Xinliang Liu <[email protected]>
>>>> Fix-suggested-by: Rob Herring <[email protected]>
>>>> Signed-off-by: John Stultz <[email protected]>
>>>
>>>
>>> Looks good to me. Thanks for the patch.
>>>
>>> Reviewed-by:
>>> Xinliang Liu <[email protected]>
>>>
>>
>> Just wanted to check in on this. Is there someone I'm missing from the
>> cc list on this?
>>
>
> Hi John,
> Apologies, I just saw this. Slipped through my cracks because it's not
> posted on dri-devel.
>
> The patch looks good. I'll pick it up in drm-misc-fixes if Dave
> doesn't take it directly into drm-fixes.
>
Hi John,
I've picked this up in drm-misc-fixes.
Thanks again for the patch,
Sean
> Sean
>
>
>> thanks
>> -john