2021-12-02 22:36:17

by Florian Fainelli

Subject: [PATCH] dt-bindings: PCI: brcmstb: compatible is required

The compatible property is required, make sure the binding documents it
as such.

Signed-off-by: Florian Fainelli <[email protected]>
---
Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
index 1fe102743f82..7c24d711b377 100644
--- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
@@ -76,6 +76,7 @@ properties:
maxItems: 3

required:
+ - compatible
- reg
- ranges
- dma-ranges
--
2.25.1

2021-12-02 22:41:31

by Rob Herring

Subject: Re: [PATCH] dt-bindings: PCI: brcmstb: compatible is required

On Thu, Dec 2, 2021 at 4:36 PM Florian Fainelli <[email protected]> wrote:
>
> The compatible property is required, make sure the binding documents it
> as such.

Yes, though if 'compatible' is not present and matching, the schema is
never applied. I'll apply it later, but I wouldn't be too concerned
fixing any others.

> Signed-off-by: Florian Fainelli <[email protected]>
> ---
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 1fe102743f82..7c24d711b377 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -76,6 +76,7 @@ properties:
> maxItems: 3
>
> required:
> + - compatible
> - reg
> - ranges
> - dma-ranges
> --
> 2.25.1
>

2021-12-02 22:53:39

by Florian Fainelli

Subject: Re: [PATCH] dt-bindings: PCI: brcmstb: compatible is required

On 12/2/21 2:41 PM, Rob Herring wrote:
> On Thu, Dec 2, 2021 at 4:36 PM Florian Fainelli <[email protected]> wrote:
>>
>> The compatible property is required, make sure the binding documents it
>> as such.
>
> Yes, though if 'compatible' is not present and matching, the schema is
> never applied. I'll apply it later, but I wouldn't be too concerned
> fixing any others.

OK, just happened to run into that one by accident while converting the
iProc PCIe binding to YAML.
--
Florian

2021-12-08 19:49:47

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: PCI: brcmstb: compatible is required

On Thu, 02 Dec 2021 14:36:09 -0800, Florian Fainelli wrote:
> The compatible property is required, make sure the binding documents it
> as such.
>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Applied, thanks!