2019-03-04 11:30:51

by Paul Menzel

[permalink] [raw]
Subject: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed

Dear Linux folks,


Resuming from ACPI S3 on the Dell XPS 13 9370 with Debian Sid/unstable,
Linux 4.19.20 showed the warning below. It’s not reproducible.

```
[ 0.000000] Linux version 4.19.0-3-amd64 ([email protected]) (gcc version 8.2.0 (Debian 8.2.0-20)) #1 SMP Debian 4.19.20-1 (2019-02-11)
[…]
[ 3018.972060] ath10k_pci 0000:02:00.0: Unknown eventid: 118809
[ 3018.992848] WARNING: CPU: 6 PID: 3953 at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed+0xd2e/0xe70 [ath10k_core]
[ 3018.992849] Modules linked in: ctr ccm fuse snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic arc4 bnep uvcvideo btusb btrtl videobuf2_vmalloc btbcm videobuf2_memops btintel videobuf2_v4l2 videobuf2_common bluetooth videodev media ecdh_generic xfrm_user xfrm4_tunnel tunnel4 ipcomp xfrm_ipcomp esp4 ah4 af_key l2tp_ppp xfrm_algo l2tp_netlink l2tp_core ip6_udp_tunnel udp_tunnel pppox ppp_generic slhc hid_multitouch hid_generic mei_wdt binfmt_misc intel_rapl nls_ascii dell_wmi x86_pkg_temp_thermal intel_powerclamp dell_laptop nls_cp437 rtsx_pci_sdmmc iTCO_wdt dell_smbios rtsx_pci_ms iTCO_vendor_support vfat memstick mmc_core wmi_bmof dcdbas coretemp dell_wmi_descriptor fat joydev kvm_intel kvm ath10k_pci irqbypass snd_soc_skl crct10dif_pclmul snd_soc_skl_ipc ath10k_core crc32_pclmul snd_soc_sst_ipc
[ 3018.992871] snd_soc_sst_dsp snd_hda_ext_core ghash_clmulni_intel ath snd_soc_acpi_intel_match mac80211 snd_soc_acpi intel_cstate snd_soc_core i915 intel_uncore snd_compress cfg80211 snd_hda_intel xhci_pci snd_hda_codec efi_pstore intel_rapl_perf xhci_hcd idma64 rtsx_pci drm_kms_helper snd_hda_core rfkill pcspkr i2c_hid efivars hid usbcore snd_hwdep drm snd_pcm mei_me snd_timer ucsi_acpi processor_thermal_device usb_common i2c_i801 mei typec_ucsi intel_lpss_pci snd intel_soc_dts_iosf typec i2c_algo_bit intel_lpss soundcore intel_pch_thermal wmi battery video int3403_thermal intel_hid int3400_thermal sparse_keymap acpi_thermal_rel acpi_pad int340x_thermal_zone ac button pcc_cpufreq parport_pc ppdev lp parport efivarfs ip_tables x_tables autofs4 ext4 crc16 mbcache jbd2 crc32c_generic fscrypto ecb dm_crypt
[ 3018.992896] dm_mod crc32c_intel nvme aesni_intel aes_x86_64 psmouse crypto_simd cryptd glue_helper evdev serio_raw nvme_core thermal
[ 3018.992902] CPU: 6 PID: 3953 Comm: kworker/u16:30 Not tainted 4.19.0-3-amd64 #1 Debian 4.19.20-1
[ 3018.992903] Hardware name: Dell Inc. XPS 13 9370/0F6P3V, BIOS 1.5.1 08/09/2018
[ 3018.992906] Workqueue: events_unbound async_run_entry_fn
[ 3018.992909] RIP: 0010:ath10k_bss_info_changed+0xd2e/0xe70 [ath10k_core]
[ 3018.992910] Code: 89 c1 89 f2 4c 89 d7 48 c7 c6 38 cd cc c0 4c 89 4c 24 10 89 44 24 08 e8 c0 32 00 00 8b 44 24 08 4c 8b 4c 24 10 e9 a1 f8 ff ff <0f> 0b e9 d5 f5 ff ff 8b b3 58 01 00 00 89 f2 89 c1 48 c7 c6 f8 cc
[ 3018.992911] RSP: 0000:ffffb9dc841ebcc0 EFLAGS: 00010246
[ 3018.992912] RAX: 0000000000000000 RBX: ffff9673015b1380 RCX: 0000000000000000
[ 3018.992912] RDX: ffff96730ed718b8 RSI: 0000000000000212 RDI: 0000000000000212
[ 3018.992913] RBP: 0000000002000000 R08: 0000000000200000 R09: 0000000000000000
[ 3018.992913] R10: ffff9672b00c0a00 R11: 0000000034834800 R12: ffff9673015b1388
[ 3018.992914] R13: ffff96730ed71540 R14: ffff96730ed71540 R15: ffff9673015b14c8
[ 3018.992914] FS: 0000000000000000(0000) GS:ffff96731e580000(0000) knlGS:0000000000000000
[ 3018.992915] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 3018.992916] CR2: 0000000000000000 CR3: 000000013fa0a001 CR4: 00000000003606e0
[ 3018.992916] Call Trace:
[ 3018.992921] ? ath10k_conf_tx+0x7a/0x4b0 [ath10k_core]
[ 3018.992937] ieee80211_bss_info_change_notify+0xab/0x1a0 [mac80211]
[ 3018.992946] ieee80211_reconfig+0x661/0x12a0 [mac80211]
[ 3018.992962] wiphy_resume+0x7f/0x120 [cfg80211]
[ 3018.992969] ? wiphy_suspend+0x270/0x270 [cfg80211]
[ 3018.992971] dpm_run_callback+0x59/0x150
[ 3018.992972] device_resume+0x97/0x190
[ 3018.992973] async_resume+0x19/0x30
[ 3018.992974] async_run_entry_fn+0x39/0x160
[ 3018.992976] process_one_work+0x1a7/0x3a0
[ 3018.992978] worker_thread+0x30/0x390
[ 3018.992979] ? pwq_unbound_release_workfn+0xd0/0xd0
[ 3018.992980] kthread+0x112/0x130
[ 3018.992981] ? kthread_bind+0x30/0x30
[ 3018.992983] ret_from_fork+0x35/0x40
[ 3018.992984] ---[ end trace 3af618ca97bd4a0a ]---
```

Please find all Linux messages attached.


Kind regards,

Paul


Attachments:
=?utf-8?Q?20190304=E2=80=93linux-4=2E19=2E20=E2=80=93dmesg=2Etxt?= (69.72 kB)
smime.p7s (5.05 kB)
S/MIME Cryptographic Signature
Download all attachments

2019-03-04 11:56:30

by Gabriel C

[permalink] [raw]
Subject: Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed

Am Mo., 4. März 2019 um 12:28 Uhr schrieb Paul Menzel <[email protected]>:
>
> Dear Linux folks,
>
>
> Resuming from ACPI S3 on the Dell XPS 13 9370 with Debian Sid/unstable,
> Linux 4.19.20 showed the warning below. It’s not reproducible.
>
> ```
> [ 0.000000] Linux version 4.19.0-3-amd64 ([email protected]) (gcc version 8.2.0 (Debian 8.2.0-20)) #1 SMP Debian 4.19.20-1 (2019-02-11)
> […]
> [ 3018.972060] ath10k_pci 0000:02:00.0: Unknown eventid: 118809
> [ 3018.992848] WARNING: CPU: 6 PID: 3953 at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed+0xd2e/0xe70 [ath10k_core]
> [ 3018.992849] Modules linked in: ctr ccm fuse snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic arc4 bnep uvcvideo btusb btrtl videobuf2_vmalloc btbcm videobuf2_memops btintel videobuf2_v4l2 videobuf2_common bluetooth videodev media ecdh_generic xfrm_user xfrm4_tunnel tunnel4 ipcomp xfrm_ipcomp esp4 ah4 af_key l2tp_ppp xfrm_algo l2tp_netlink l2tp_core ip6_udp_tunnel udp_tunnel pppox ppp_generic slhc hid_multitouch hid_generic mei_wdt binfmt_misc intel_rapl nls_ascii dell_wmi x86_pkg_temp_thermal intel_powerclamp dell_laptop nls_cp437 rtsx_pci_sdmmc iTCO_wdt dell_smbios rtsx_pci_ms iTCO_vendor_support vfat memstick mmc_core wmi_bmof dcdbas coretemp dell_wmi_descriptor fat joydev kvm_intel kvm ath10k_pci irqbypass snd_soc_skl crct10dif_pclmul snd_soc_skl_ipc ath10k_core crc32_pclmul snd_soc_sst_ipc
> [ 3018.992871] snd_soc_sst_dsp snd_hda_ext_core ghash_clmulni_intel ath snd_soc_acpi_intel_match mac80211 snd_soc_acpi intel_cstate snd_soc_core i915 intel_uncore snd_compress cfg80211 snd_hda_intel xhci_pci snd_hda_codec efi_pstore intel_rapl_perf xhci_hcd idma64 rtsx_pci drm_kms_helper snd_hda_core rfkill pcspkr i2c_hid efivars hid usbcore snd_hwdep drm snd_pcm mei_me snd_timer ucsi_acpi processor_thermal_device usb_common i2c_i801 mei typec_ucsi intel_lpss_pci snd intel_soc_dts_iosf typec i2c_algo_bit intel_lpss soundcore intel_pch_thermal wmi battery video int3403_thermal intel_hid int3400_thermal sparse_keymap acpi_thermal_rel acpi_pad int340x_thermal_zone ac button pcc_cpufreq parport_pc ppdev lp parport efivarfs ip_tables x_tables autofs4 ext4 crc16 mbcache jbd2 crc32c_generic fscrypto ecb dm_crypt
> [ 3018.992896] dm_mod crc32c_intel nvme aesni_intel aes_x86_64 psmouse crypto_simd cryptd glue_helper evdev serio_raw nvme_core thermal
> [ 3018.992902] CPU: 6 PID: 3953 Comm: kworker/u16:30 Not tainted 4.19.0-3-amd64 #1 Debian 4.19.20-1
> [ 3018.992903] Hardware name: Dell Inc. XPS 13 9370/0F6P3V, BIOS 1.5.1 08/09/2018
> [ 3018.992906] Workqueue: events_unbound async_run_entry_fn
> [ 3018.992909] RIP: 0010:ath10k_bss_info_changed+0xd2e/0xe70 [ath10k_core]
> [ 3018.992910] Code: 89 c1 89 f2 4c 89 d7 48 c7 c6 38 cd cc c0 4c 89 4c 24 10 89 44 24 08 e8 c0 32 00 00 8b 44 24 08 4c 8b 4c 24 10 e9 a1 f8 ff ff <0f> 0b e9 d5 f5 ff ff 8b b3 58 01 00 00 89 f2 89 c1 48 c7 c6 f8 cc
> [ 3018.992911] RSP: 0000:ffffb9dc841ebcc0 EFLAGS: 00010246
> [ 3018.992912] RAX: 0000000000000000 RBX: ffff9673015b1380 RCX: 0000000000000000
> [ 3018.992912] RDX: ffff96730ed718b8 RSI: 0000000000000212 RDI: 0000000000000212
> [ 3018.992913] RBP: 0000000002000000 R08: 0000000000200000 R09: 0000000000000000
> [ 3018.992913] R10: ffff9672b00c0a00 R11: 0000000034834800 R12: ffff9673015b1388
> [ 3018.992914] R13: ffff96730ed71540 R14: ffff96730ed71540 R15: ffff9673015b14c8
> [ 3018.992914] FS: 0000000000000000(0000) GS:ffff96731e580000(0000) knlGS:0000000000000000
> [ 3018.992915] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 3018.992916] CR2: 0000000000000000 CR3: 000000013fa0a001 CR4: 00000000003606e0
> [ 3018.992916] Call Trace:
> [ 3018.992921] ? ath10k_conf_tx+0x7a/0x4b0 [ath10k_core]
> [ 3018.992937] ieee80211_bss_info_change_notify+0xab/0x1a0 [mac80211]
> [ 3018.992946] ieee80211_reconfig+0x661/0x12a0 [mac80211]
> [ 3018.992962] wiphy_resume+0x7f/0x120 [cfg80211]
> [ 3018.992969] ? wiphy_suspend+0x270/0x270 [cfg80211]
> [ 3018.992971] dpm_run_callback+0x59/0x150
> [ 3018.992972] device_resume+0x97/0x190
> [ 3018.992973] async_resume+0x19/0x30
> [ 3018.992974] async_run_entry_fn+0x39/0x160
> [ 3018.992976] process_one_work+0x1a7/0x3a0
> [ 3018.992978] worker_thread+0x30/0x390
> [ 3018.992979] ? pwq_unbound_release_workfn+0xd0/0xd0
> [ 3018.992980] kthread+0x112/0x130
> [ 3018.992981] ? kthread_bind+0x30/0x30
> [ 3018.992983] ret_from_fork+0x35/0x40
> [ 3018.992984] ---[ end trace 3af618ca97bd4a0a ]---
> ```
>
> Please find all Linux messages attached.

I reported that twice and no one seems to care about.

http://lists.infradead.org/pipermail/ath10k/2018-November/012398.html
http://lists.infradead.org/pipermail/ath10k/2018-December/012658.html

BR,

Gabriel C

2019-03-04 11:59:50

by Kalle Valo

[permalink] [raw]
Subject: Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed

Gabriel C <[email protected]> writes:

> Am Mo., 4. März 2019 um 12:28 Uhr schrieb Paul Menzel <[email protected]>:
>
>> Resuming from ACPI S3 on the Dell XPS 13 9370 with Debian Sid/unstable,
>> Linux 4.19.20 showed the warning below. It’s not reproducible.

[...]

>> [ 3018.992916] Call Trace:
>> [ 3018.992921] ? ath10k_conf_tx+0x7a/0x4b0 [ath10k_core]
>> [ 3018.992937] ieee80211_bss_info_change_notify+0xab/0x1a0 [mac80211]
>> [ 3018.992946] ieee80211_reconfig+0x661/0x12a0 [mac80211]
>> [ 3018.992962] wiphy_resume+0x7f/0x120 [cfg80211]
>> [ 3018.992969] ? wiphy_suspend+0x270/0x270 [cfg80211]
>> [ 3018.992971] dpm_run_callback+0x59/0x150
>> [ 3018.992972] device_resume+0x97/0x190
>> [ 3018.992973] async_resume+0x19/0x30
>> [ 3018.992974] async_run_entry_fn+0x39/0x160
>> [ 3018.992976] process_one_work+0x1a7/0x3a0
>> [ 3018.992978] worker_thread+0x30/0x390
>> [ 3018.992979] ? pwq_unbound_release_workfn+0xd0/0xd0
>> [ 3018.992980] kthread+0x112/0x130
>> [ 3018.992981] ? kthread_bind+0x30/0x30
>> [ 3018.992983] ret_from_fork+0x35/0x40
>> [ 3018.992984] ---[ end trace 3af618ca97bd4a0a ]---
>> ```
>>
>> Please find all Linux messages attached.
>
> I reported that twice and no one seems to care about.
>
> http://lists.infradead.org/pipermail/ath10k/2018-November/012398.html
> http://lists.infradead.org/pipermail/ath10k/2018-December/012658.html

Does this patch help:

ath10k: Drop WARN_ON()s that always trigger during system resume

https://patchwork.kernel.org/patch/10837139/

--
Kalle Valo

2019-03-04 13:08:38

by Gabriel C

[permalink] [raw]
Subject: Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed

Am Mo., 4. März 2019 um 12:59 Uhr schrieb Kalle Valo <[email protected]>:
>
> Gabriel C <[email protected]> writes:
>
> > Am Mo., 4. März 2019 um 12:28 Uhr schrieb Paul Menzel <[email protected]>:
> >
> >> Resuming from ACPI S3 on the Dell XPS 13 9370 with Debian Sid/unstable,
> >> Linux 4.19.20 showed the warning below. It’s not reproducible.
>
> [...]
>
> >> [ 3018.992916] Call Trace:
> >> [ 3018.992921] ? ath10k_conf_tx+0x7a/0x4b0 [ath10k_core]
> >> [ 3018.992937] ieee80211_bss_info_change_notify+0xab/0x1a0 [mac80211]
> >> [ 3018.992946] ieee80211_reconfig+0x661/0x12a0 [mac80211]
> >> [ 3018.992962] wiphy_resume+0x7f/0x120 [cfg80211]
> >> [ 3018.992969] ? wiphy_suspend+0x270/0x270 [cfg80211]
> >> [ 3018.992971] dpm_run_callback+0x59/0x150
> >> [ 3018.992972] device_resume+0x97/0x190
> >> [ 3018.992973] async_resume+0x19/0x30
> >> [ 3018.992974] async_run_entry_fn+0x39/0x160
> >> [ 3018.992976] process_one_work+0x1a7/0x3a0
> >> [ 3018.992978] worker_thread+0x30/0x390
> >> [ 3018.992979] ? pwq_unbound_release_workfn+0xd0/0xd0
> >> [ 3018.992980] kthread+0x112/0x130
> >> [ 3018.992981] ? kthread_bind+0x30/0x30
> >> [ 3018.992983] ret_from_fork+0x35/0x40
> >> [ 3018.992984] ---[ end trace 3af618ca97bd4a0a ]---
> >> ```
> >>
> >> Please find all Linux messages attached.
> >
> > I reported that twice and no one seems to care about.
> >
> > http://lists.infradead.org/pipermail/ath10k/2018-November/012398.html
> > http://lists.infradead.org/pipermail/ath10k/2018-December/012658.html
>
> Does this patch help:
>
> ath10k: Drop WARN_ON()s that always trigger during system resume
>
> https://patchwork.kernel.org/patch/10837139/
>

Without to test this patch I can confirm it will help , I dropped the
WARN_ON()'s in 4.19 already.
If I remember right 4.19 has one WARN_ON() triggers while 4.20 got two.

https://gitweb.frugalware.org/frugalware-current/blob/master/source/base/kernel/ath10k-drop-WARN_ON-added-in-cd93b83ad927b2c7979e0add0343ace59328b461.patch

BR,

Gabriel C

2019-03-08 10:59:05

by Kalle Valo

[permalink] [raw]
Subject: Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed

Gabriel C <[email protected]> writes:

> Am Mo., 4. März 2019 um 12:59 Uhr schrieb Kalle Valo <[email protected]>:
>>
>> Gabriel C <[email protected]> writes:
>>
>> > Am Mo., 4. März 2019 um 12:28 Uhr schrieb Paul Menzel <[email protected]>:
>> >
>> >> Resuming from ACPI S3 on the Dell XPS 13 9370 with Debian Sid/unstable,
>> >> Linux 4.19.20 showed the warning below. It’s not reproducible.
>>
>> [...]
>>
>> >> [ 3018.992916] Call Trace:
>> >> [ 3018.992921] ? ath10k_conf_tx+0x7a/0x4b0 [ath10k_core]
>> >> [ 3018.992937] ieee80211_bss_info_change_notify+0xab/0x1a0 [mac80211]
>> >> [ 3018.992946] ieee80211_reconfig+0x661/0x12a0 [mac80211]
>> >> [ 3018.992962] wiphy_resume+0x7f/0x120 [cfg80211]
>> >> [ 3018.992969] ? wiphy_suspend+0x270/0x270 [cfg80211]
>> >> [ 3018.992971] dpm_run_callback+0x59/0x150
>> >> [ 3018.992972] device_resume+0x97/0x190
>> >> [ 3018.992973] async_resume+0x19/0x30
>> >> [ 3018.992974] async_run_entry_fn+0x39/0x160
>> >> [ 3018.992976] process_one_work+0x1a7/0x3a0
>> >> [ 3018.992978] worker_thread+0x30/0x390
>> >> [ 3018.992979] ? pwq_unbound_release_workfn+0xd0/0xd0
>> >> [ 3018.992980] kthread+0x112/0x130
>> >> [ 3018.992981] ? kthread_bind+0x30/0x30
>> >> [ 3018.992983] ret_from_fork+0x35/0x40
>> >> [ 3018.992984] ---[ end trace 3af618ca97bd4a0a ]---
>> >> ```
>> >>
>> >> Please find all Linux messages attached.
>> >
>> > I reported that twice and no one seems to care about.
>> >
>> > http://lists.infradead.org/pipermail/ath10k/2018-November/012398.html
>> > http://lists.infradead.org/pipermail/ath10k/2018-December/012658.html
>>
>> Does this patch help:
>>
>> ath10k: Drop WARN_ON()s that always trigger during system resume
>>
>> https://patchwork.kernel.org/patch/10837139/
>>
>
> Without to test this patch I can confirm it will help , I dropped the
> WARN_ON()'s in 4.19 already.
> If I remember right 4.19 has one WARN_ON() triggers while 4.20 got two.

Ok, thanks. I'll try to get this patch to 5.1.

--
Kalle Valo

2019-03-25 16:50:16

by Brian Norris

[permalink] [raw]
Subject: Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed

Hi Kalle,

On Fri, Mar 8, 2019 at 2:58 AM Kalle Valo <[email protected]> wrote:
> Gabriel C <[email protected]> writes:
> > Am Mo., 4. März 2019 um 12:59 Uhr schrieb Kalle Valo <[email protected]>:
> >> Gabriel C <[email protected]> writes:
> >> > I reported that twice and no one seems to care about.
> >> >
> >> > http://lists.infradead.org/pipermail/ath10k/2018-November/012398.html
> >> > http://lists.infradead.org/pipermail/ath10k/2018-December/012658.html
> >>
> >> Does this patch help:
> >>
> >> ath10k: Drop WARN_ON()s that always trigger during system resume
> >>
> >> https://patchwork.kernel.org/patch/10837139/
> >>
> >
> > Without to test this patch I can confirm it will help , I dropped the
> > WARN_ON()'s in 4.19 already.
> > If I remember right 4.19 has one WARN_ON() triggers while 4.20 got two.
>
> Ok, thanks. I'll try to get this patch to 5.1.

Ping? Is there any solution queued anywhere? It's kinda sad how long
this has sat here.

Brian

2019-03-26 03:50:05

by Claire Chang

[permalink] [raw]
Subject: Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed

Hi

On Tue, Mar 26, 2019 at 12:49 AM Brian Norris <[email protected]> wrote:
>
> Hi Kalle,
>
> On Fri, Mar 8, 2019 at 2:58 AM Kalle Valo <[email protected]> wrote:
> > Gabriel C <[email protected]> writes:
> > > Am Mo., 4. März 2019 um 12:59 Uhr schrieb Kalle Valo <[email protected]>:
> > >> Gabriel C <[email protected]> writes:
> > >> > I reported that twice and no one seems to care about.
> > >> >
> > >> > http://lists.infradead.org/pipermail/ath10k/2018-November/012398.html
> > >> > http://lists.infradead.org/pipermail/ath10k/2018-December/012658.html
> > >>
> > >> Does this patch help:
> > >>
> > >> ath10k: Drop WARN_ON()s that always trigger during system resume
> > >>
> > >> https://patchwork.kernel.org/patch/10837139/
> > >>
> > >
> > > Without to test this patch I can confirm it will help , I dropped the
> > > WARN_ON()'s in 4.19 already.
> > > If I remember right 4.19 has one WARN_ON() triggers while 4.20 got two.
> >
> > Ok, thanks. I'll try to get this patch to 5.1.
>
> Ping? Is there any solution queued anywhere? It's kinda sad how long
> this has sat here.
>
> Brian

Do we need to set mcast rate and basic rates during/after system resume?
Dropping the WARN_ON() will solve the warning issue, but won't make
those rates set properly.

2019-04-02 23:03:42

by Brian Norris

[permalink] [raw]
Subject: Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed

+ Rafael
+ authors of these bad commits:
cd93b83ad927 ath10k: support for multicast rate control
f279294e9ee2 ath10k: add support for configuring management packet rate

Hi,

On Mon, Mar 25, 2019 at 8:46 PM Claire Chang <[email protected]> wrote:
> On Tue, Mar 26, 2019 at 12:49 AM Brian Norris <[email protected]> wrote:
> > On Fri, Mar 8, 2019 at 2:58 AM Kalle Valo <[email protected]> wrote:
> > > Gabriel C <[email protected]> writes:
> > > > Am Mo., 4. März 2019 um 12:59 Uhr schrieb Kalle Valo <[email protected]>:
> > > >> Gabriel C <[email protected]> writes:
> > > >> > I reported that twice and no one seems to care about.
> > > >> >
> > > >> > http://lists.infradead.org/pipermail/ath10k/2018-November/012398.html
> > > >> > http://lists.infradead.org/pipermail/ath10k/2018-December/012658.html
> > > >>
> > > >> Does this patch help:
> > > >>
> > > >> ath10k: Drop WARN_ON()s that always trigger during system resume
> > > >>
> > > >> https://patchwork.kernel.org/patch/10837139/
> > > >>
> > > >
> > > > Without to test this patch I can confirm it will help , I dropped the
> > > > WARN_ON()'s in 4.19 already.
> > > > If I remember right 4.19 has one WARN_ON() triggers while 4.20 got two.
> > >
> > > Ok, thanks. I'll try to get this patch to 5.1.
> >
> > Ping? Is there any solution queued anywhere? It's kinda sad how long
> > this has sat here.
> >
> > Brian
>
> Do we need to set mcast rate and basic rates during/after system resume?
> Dropping the WARN_ON() will solve the warning issue, but won't make
> those rates set properly.

I don't think there's anything to fix here about the rate info; the
original patches just made mistakes with how this callback is used. In
this case, we're not associated (we're not using WoWLAN), so it's
ieee80211_reconfig() -> ieee80211_bss_info_change_notify(), which
notifies the current association status (not associated), as well as a
few other parameters. There is no rate info to be had, so we should
just exit silently.

I don't see any reason not to take Rafael's patch. I'll respond with
my Reviewed/Tested there.

Brian