2021-04-01 06:27:09

by Jiabing Wan

Subject: [PATCH] tools: perf: util: Remove duplicate struct declaration

struct target is declared twice. One has been declared
at 21st line. Remove the duplicate.

Signed-off-by: Wan Jiabing <[email protected]>
---
tools/perf/util/evsel.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
index 6026487353dd..998e5b806696 100644
--- a/tools/perf/util/evsel.h
+++ b/tools/perf/util/evsel.h
@@ -157,7 +157,6 @@ struct perf_missing_features {
extern struct perf_missing_features perf_missing_features;

struct perf_cpu_map;
-struct target;
struct thread_map;
struct record_opts;

--
2.25.1

2021-04-01 07:23:45

by Namhyung Kim

Subject: Re: [PATCH] tools: perf: util: Remove duplicate struct declaration

Hello,

On Thu, Apr 1, 2021 at 3:25 PM Wan Jiabing <[email protected]> wrote:
>
> struct target is declared twice. One has been declared
> at 21st line. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <[email protected]>

Acked-by: Namhyung Kim <[email protected]>

I think we can move all the forward declarations to the top
(and sort them) as well.

Thanks,
Namhyung


> ---
> tools/perf/util/evsel.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> index 6026487353dd..998e5b806696 100644
> --- a/tools/perf/util/evsel.h
> +++ b/tools/perf/util/evsel.h
> @@ -157,7 +157,6 @@ struct perf_missing_features {
> extern struct perf_missing_features perf_missing_features;
>
> struct perf_cpu_map;
> -struct target;
> struct thread_map;
> struct record_opts;
>
> --
> 2.25.1
>

2021-04-02 13:47:24

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] tools: perf: util: Remove duplicate struct declaration

Em Thu, Apr 01, 2021 at 04:19:38PM +0900, Namhyung Kim escreveu:
> Hello,
>
> On Thu, Apr 1, 2021 at 3:25 PM Wan Jiabing <[email protected]> wrote:
> >
> > struct target is declared twice. One has been declared
> > at 21st line. Remove the duplicate.
> >
> > Signed-off-by: Wan Jiabing <[email protected]>
>
> Acked-by: Namhyung Kim <[email protected]>
>
> I think we can move all the forward declarations to the top
> (and sort them) as well.

Thanks, applied.

- Arnaldo