2022-08-23 06:26:55

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v1] drivers/tty/serial: check the return value of uart_port_check()

On Mon, Aug 22, 2022 at 10:57:39PM -0700, lily wrote:
> uart_port_check() can return NULL pointer. Check its return value
> before dereference it.

Also, how did you find this issue?

>
> Signed-off-by: Li Zhong <[email protected]>

Also, your From: name does not match this one, so I can't take the patch
even if it is ok :(

Please do initial kernel work in drivers/staging/ to get issues like
this fixed up before moving to other portions of the kernel so that
basic email problems do not bother other subsystem maintainers.

thanks,

greg k-h



2022-08-26 08:38:58

by Li Zhong

[permalink] [raw]
Subject: Re: [PATCH v1] drivers/tty/serial: check the return value of uart_port_check()

On Mon, Aug 22, 2022 at 11:22 PM Greg KH <[email protected]> wrote:
>
> On Mon, Aug 22, 2022 at 10:57:39PM -0700, lily wrote:
> > uart_port_check() can return NULL pointer. Check its return value
> > before dereference it.
>
> Also, how did you find this issue?
>
> >
> > Signed-off-by: Li Zhong <[email protected]>
>
> Also, your From: name does not match this one, so I can't take the patch
> even if it is ok :(
>
> Please do initial kernel work in drivers/staging/ to get issues like
> this fixed up before moving to other portions of the kernel so that
> basic email problems do not bother other subsystem maintainers.
>
Thanks for the suggestions! I'll correct the From: in my v2 patch.

> thanks,
>
> greg k-h
>
>