2019-12-09 08:59:13

by Chuhong Yuan

Subject: [PATCH] drm/gma500: add a missed gma_power_end in error path

oaktrail_lvds_mode_set() misses a gma_power_end() in an error path.
Add the call to fix it.

Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/gma500/oaktrail_lvds.c b/drivers/gpu/drm/gma500/oaktrail_lvds.c
index 7390403ea1b7..582e09597500 100644
--- a/drivers/gpu/drm/gma500/oaktrail_lvds.c
+++ b/drivers/gpu/drm/gma500/oaktrail_lvds.c
@@ -117,6 +117,7 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder,

if (!connector) {
DRM_ERROR("Couldn't find connector when setting mode");
+ gma_power_end(dev);
return;
}

--
2.24.0

2019-12-09 20:36:48

by Patrik Jakobsson

Subject: Re: [PATCH] drm/gma500: add a missed gma_power_end in error path

On Mon, Dec 9, 2019 at 9:57 AM Chuhong Yuan <[email protected]> wrote:
>
> oaktrail_lvds_mode_set() misses a gma_power_end() in an error path.
> Add the call to fix it.
>
> Signed-off-by: Chuhong Yuan <[email protected]>

Hi Chuhong, thanks for the patch.

Applied to drm-misc-next

-Patrik

> ---
> drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_lvds.c b/drivers/gpu/drm/gma500/oaktrail_lvds.c
> index 7390403ea1b7..582e09597500 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_lvds.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_lvds.c
> @@ -117,6 +117,7 @@ static void oaktrail_lvds_mode_set(struct drm_encoder *encoder,
>
> if (!connector) {
> DRM_ERROR("Couldn't find connector when setting mode");
> + gma_power_end(dev);
> return;
> }
>
> --
> 2.24.0
>