2020-02-25 10:18:37

by Po-Hsu Lin

Subject: [PATCH] selftests/timers: Turn off timeout setting

Tests in timers especially nsleep-lat, set-timer-lat,
inconsistency-check and raw_skew these 4 tests can take longer than
the default 45 seconds that introduced in commit 852c8cbf
(selftests/kselftest/runner.sh: Add 45 second timeout per test) to run.

Disable the timeout setting for timers instead of looking for an proper
value to make it more general.

Signed-off-by: Po-Hsu Lin <[email protected]>
---
tools/testing/selftests/timers/settings | 1 +
1 file changed, 1 insertion(+)
create mode 100644 tools/testing/selftests/timers/settings

diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
new file mode 100644
index 0000000..e7b9417
--- /dev/null
+++ b/tools/testing/selftests/timers/settings
@@ -0,0 +1 @@
+timeout=0
--
2.7.4

2020-02-25 15:18:31

by Joe Lawrence

Subject: Re: [PATCH] selftests/timers: Turn off timeout setting

On 2/25/20 5:18 AM, Po-Hsu Lin wrote:
> Tests in timers especially nsleep-lat, set-timer-lat,
> inconsistency-check and raw_skew these 4 tests can take longer than
> the default 45 seconds that introduced in commit 852c8cbf
> (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run.
>
> Disable the timeout setting for timers instead of looking for an proper
> value to make it more general.
>
> Signed-off-by: Po-Hsu Lin <[email protected]>
> ---
> tools/testing/selftests/timers/settings | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 tools/testing/selftests/timers/settings
>
> diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> new file mode 100644
> index 0000000..e7b9417
> --- /dev/null
> +++ b/tools/testing/selftests/timers/settings
> @@ -0,0 +1 @@
> +timeout=0
>

Hi,

Michael recently posted a patch that adds the various selftest settings
files to the TEST_FILES list, ensuring that they get copied to the
install directory along with the tests:

https://lore.kernel.org/linux-kselftest/[email protected]/

I think if you add that to the corresponding Makefile, you should be set.

Regards,

-- Joe

2020-02-25 15:31:30

by Shuah Khan

Subject: Re: [PATCH] selftests/timers: Turn off timeout setting

On 2/25/20 3:18 AM, Po-Hsu Lin wrote:
> Tests in timers especially nsleep-lat, set-timer-lat,
> inconsistency-check and raw_skew these 4 tests can take longer than
> the default 45 seconds that introduced in commit 852c8cbf
> (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run.
>
> Disable the timeout setting for timers instead of looking for an proper
> value to make it more general.
>
> Signed-off-by: Po-Hsu Lin <[email protected]>
> ---
> tools/testing/selftests/timers/settings | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 tools/testing/selftests/timers/settings
>
> diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> new file mode 100644
> index 0000000..e7b9417
> --- /dev/null
> +++ b/tools/testing/selftests/timers/settings
> @@ -0,0 +1 @@
> +timeout=0
>

What happens when you disable this and set it to 0? How long does the
rest run in this case? Can you add the details to the change log please.

thanks,
-- Shuah

2020-02-25 16:27:38

by Po-Hsu Lin

Subject: Re: [PATCH] selftests/timers: Turn off timeout setting

Sure,
I will send V2 that include the change for makefile and more detail
about the change.
Thanks for the feedback,

On Tue, Feb 25, 2020 at 11:30 PM shuah <[email protected]> wrote:
>
> On 2/25/20 3:18 AM, Po-Hsu Lin wrote:
> > Tests in timers especially nsleep-lat, set-timer-lat,
> > inconsistency-check and raw_skew these 4 tests can take longer than
> > the default 45 seconds that introduced in commit 852c8cbf
> > (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run.
> >
> > Disable the timeout setting for timers instead of looking for an proper
> > value to make it more general.
> >
> > Signed-off-by: Po-Hsu Lin <[email protected]>
> > ---
> > tools/testing/selftests/timers/settings | 1 +
> > 1 file changed, 1 insertion(+)
> > create mode 100644 tools/testing/selftests/timers/settings
> >
> > diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> > new file mode 100644
> > index 0000000..e7b9417
> > --- /dev/null
> > +++ b/tools/testing/selftests/timers/settings
> > @@ -0,0 +1 @@
> > +timeout=0
> >
>
> What happens when you disable this and set it to 0? How long does the
> rest run in this case? Can you add the details to the change log please.
>
> thanks,
> -- Shuah