2024-06-02 00:07:41

by Dr. David Alan Gilbert

Subject: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

From: "Dr. David Alan Gilbert" <[email protected]>

'hisi_ptt_queue' has been unused since the original
commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
HiSilicon PCIe Trace packet").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
tools/perf/util/hisi-ptt.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
index 52d0ce302ca0..37ea987017f6 100644
--- a/tools/perf/util/hisi-ptt.c
+++ b/tools/perf/util/hisi-ptt.c
@@ -35,11 +35,6 @@ struct hisi_ptt {
u32 pmu_type;
};

-struct hisi_ptt_queue {
- struct hisi_ptt *ptt;
- struct auxtrace_buffer *buffer;
-};
-
static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
{
uint32_t head = *(uint32_t *)buf;
--
2.45.1

2024-06-03 08:34:46

by Jonathan Cameron

Subject: Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

On Sun, 2 Jun 2024 01:07:09 +0100
[email protected] wrote:

> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'hisi_ptt_queue' has been unused since the original
> commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
> HiSilicon PCIe Trace packet").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
LGTM
Minimal
Reviewed-by: Jonathan Cameron <[email protected]>
by which I mean I searched for it and indeed found only this definition.

> ---
> tools/perf/util/hisi-ptt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index 52d0ce302ca0..37ea987017f6 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
> @@ -35,11 +35,6 @@ struct hisi_ptt {
> u32 pmu_type;
> };
>
> -struct hisi_ptt_queue {
> - struct hisi_ptt *ptt;
> - struct auxtrace_buffer *buffer;
> -};
> -
> static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
> {
> uint32_t head = *(uint32_t *)buf;

2024-06-03 16:34:29

by Ian Rogers

Subject: Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

On Sat, Jun 1, 2024 at 5:07 PM <[email protected]> wrote:
>
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'hisi_ptt_queue' has been unused since the original
> commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing
> HiSilicon PCIe Trace packet").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Hi/thanks David,

Reviewed-by: Ian Rogers <[email protected]>

Ian

> ---
> tools/perf/util/hisi-ptt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/hisi-ptt.c b/tools/perf/util/hisi-ptt.c
> index 52d0ce302ca0..37ea987017f6 100644
> --- a/tools/perf/util/hisi-ptt.c
> +++ b/tools/perf/util/hisi-ptt.c
> @@ -35,11 +35,6 @@ struct hisi_ptt {
> u32 pmu_type;
> };
>
> -struct hisi_ptt_queue {
> - struct hisi_ptt *ptt;
> - struct auxtrace_buffer *buffer;
> -};
> -
> static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
> {
> uint32_t head = *(uint32_t *)buf;
> --
> 2.45.1
>

2024-06-06 17:12:01

by Namhyung Kim

Subject: Re: [PATCH] perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

On Sun, 02 Jun 2024 01:07:09 +0100, [email protected] wrote:

Applied to perf-tools-next, thanks!

Best regards,
Namhyung