2024-01-10 21:01:56

by Krzysztof Kozlowski

Subject: Re: [PATCH v22 5/8] arm64: dts: nuvoton: npcm8xx: add clock reset syscon node

On 08/01/2024 14:54, Tomer Maimon wrote:
> Add clock reset syscon node to handle reset and clock registers
> controllers.
>
> Signed-off-by: Tomer Maimon <[email protected]>
> ---
> arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index 9c4df91031e7..7d5956e2c9f3 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -22,6 +22,11 @@ gcr: system-controller@f0800000 {
> reg = <0x0 0xf0800000 0x0 0x1000>;
> };
>
> + clk_rst: syscon@f0801000 {
> + compatible = "nuvoton,npcm845-clk-rst", "syscon", "simple-mfd";

This is not a simple-mfd. No children,

> + reg = <0x0 0xf0801000 0x0 0xC4>;

Use lowercase hex. Please store this feedback in your checklist and do
not repeat the same mistakes in further submissions.

Best regards,
Krzysztof

2024-01-16 19:05:10

by Tomer Maimon

Subject: Re: [PATCH v22 5/8] arm64: dts: nuvoton: npcm8xx: add clock reset syscon node

Hi Krzysztof,

Thanks for your comments.

On Wed, 10 Jan 2024 at 23:01, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 08/01/2024 14:54, Tomer Maimon wrote:
> > Add clock reset syscon node to handle reset and clock registers
> > controllers.
> >
> > Signed-off-by: Tomer Maimon <[email protected]>
> > ---
> > arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > index 9c4df91031e7..7d5956e2c9f3 100644
> > --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > @@ -22,6 +22,11 @@ gcr: system-controller@f0800000 {
> > reg = <0x0 0xf0800000 0x0 0x1000>;
> > };
> >
> > + clk_rst: syscon@f0801000 {
> > + compatible = "nuvoton,npcm845-clk-rst", "syscon", "simple-mfd";
>
> This is not a simple-mfd. No children,
>
> > + reg = <0x0 0xf0801000 0x0 0xC4>;
>
> Use lowercase hex. Please store this feedback in your checklist and do
> not repeat the same mistakes in further submissions.
>
> Best regards,
> Krzysztof
>
will be fixed in the next version.

Best regards,

Tomer