2015-12-01 12:12:43

by Chaotian Jing

Subject: [PATCH] mmc: mediatek: change some dev_err to dev_dbg

there are too many error logs shown when use CMD21/CMD19 to do tune,
and it will appear at each resume time, print out so many logs to the
uart console cost too mush time. so change it to dev_dbg.

Signed-off-by: Chaotian Jing <[email protected]>
---
drivers/mmc/host/mtk-sd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 39568cc..34d23b8 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -972,7 +972,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
if ((events & MSDC_INT_XFER_COMPL) && (!stop || !stop->error)) {
data->bytes_xfered = data->blocks * data->blksz;
} else {
- dev_err(host->dev, "interrupt events: %x\n", events);
+ dev_dbg(host->dev, "interrupt events: %x\n", events);
msdc_reset_hw(host);
host->error |= REQ_DAT_ERR;
data->bytes_xfered = 0;
@@ -982,10 +982,10 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
else if (events & MSDC_INT_DATCRCERR)
data->error = -EILSEQ;

- dev_err(host->dev, "%s: cmd=%d; blocks=%d",
+ dev_dbg(host->dev, "%s: cmd=%d; blocks=%d",
__func__, mrq->cmd->opcode, data->blocks);
- dev_err(host->dev, "data_error=%d xfer_size=%d\n",
- (int)data->error, data->bytes_xfered);
+ dev_dbg(host->dev, "data_error=%d xfer_size=%d\n",
+ (int)data->error, data->bytes_xfered);
}

msdc_data_xfer_next(host, mrq, data);
--
1.8.1.1.dirty

2015-12-04 14:56:52

by Ulf Hansson

Subject: Re: [PATCH] mmc: mediatek: change some dev_err to dev_dbg

On 1 December 2015 at 13:12, Chaotian Jing <[email protected]> wrote:
> there are too many error logs shown when use CMD21/CMD19 to do tune,
> and it will appear at each resume time, print out so many logs to the
> uart console cost too mush time. so change it to dev_dbg.
>
> Signed-off-by: Chaotian Jing <[email protected]>

This one didn't apply to my next branch. Can you please rebase.

Kind regards
Uffe

> ---
> drivers/mmc/host/mtk-sd.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 39568cc..34d23b8 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -972,7 +972,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> if ((events & MSDC_INT_XFER_COMPL) && (!stop || !stop->error)) {
> data->bytes_xfered = data->blocks * data->blksz;
> } else {
> - dev_err(host->dev, "interrupt events: %x\n", events);
> + dev_dbg(host->dev, "interrupt events: %x\n", events);
> msdc_reset_hw(host);
> host->error |= REQ_DAT_ERR;
> data->bytes_xfered = 0;
> @@ -982,10 +982,10 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> else if (events & MSDC_INT_DATCRCERR)
> data->error = -EILSEQ;
>
> - dev_err(host->dev, "%s: cmd=%d; blocks=%d",
> + dev_dbg(host->dev, "%s: cmd=%d; blocks=%d",
> __func__, mrq->cmd->opcode, data->blocks);
> - dev_err(host->dev, "data_error=%d xfer_size=%d\n",
> - (int)data->error, data->bytes_xfered);
> + dev_dbg(host->dev, "data_error=%d xfer_size=%d\n",
> + (int)data->error, data->bytes_xfered);
> }
>
> msdc_data_xfer_next(host, mrq, data);
> --
> 1.8.1.1.dirty
>