2022-09-26 15:45:05

by Daniel Thompson

Subject: Re: [PATCH linux-next] backlight: lp8788: use sysfs_emit() to instead of scnprintf()

On Fri, Sep 23, 2022 at 06:35:33AM +0000, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Replace the open-code with sysfs_emit() to simplify the code.
>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> drivers/video/backlight/lp8788_bl.c | 2 +-

This one has the subject right and is a good change. However I'd still
prefer it as a single patchset that fixes *all* instances of this code
pattern.


Daniel.

2022-09-26 19:03:11

by Jingoo Han

Subject: Re: [PATCH linux-next] backlight: lp8788: use sysfs_emit() to instead of scnprintf()

On Mon, Sep 26, 2022 Daniel Thompson <[email protected]> wrote:
>
> On Fri, Sep 23, 2022 at 06:35:33AM +0000, [email protected] wrote:
> > From: ye xingchen <[email protected]>
> >
> > Replace the open-code with sysfs_emit() to simplify the code.
> >
> > Signed-off-by: ye xingchen <[email protected]>
> > ---
> > drivers/video/backlight/lp8788_bl.c | 2 +-
>
> This one has the subject right and is a good change. However I'd still
> prefer it as a single patchset that fixes *all* instances of this code
> pattern.

Yes, I agree with Daniel's opinion.

Xingchen,
Please make a "Single" patch for including "ALL" fixes
for this pattern in the 'drivers/video/backlight' directory.
Thank you.

Best regards,
Jingoo Han

>
>
> Daniel.