2016-03-29 17:00:55

by Colin King

Subject: [PATCH] qed: initialize return rc to avoid returning garbage

From: Colin Ian King <[email protected]>

in the case where qed_slowpath_irq_req is not called, rc is not
assigned and so qed_int_igu_enable will return a garbage value.
Fix this by initializing rc to 0.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
index ffd0acc..2017b01 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_int.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
@@ -2750,7 +2750,7 @@ void qed_int_igu_enable_int(struct qed_hwfn *p_hwfn,
int qed_int_igu_enable(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt,
enum qed_int_mode int_mode)
{
- int rc;
+ int rc = 0;

/* Configure AEU signal change to produce attentions */
qed_wr(p_hwfn, p_ptt, IGU_REG_ATTENTION_ENABLE, 0);
--
2.7.4

2016-03-29 18:43:29

by Yuval Mintz

Subject: RE: [PATCH] qed: initialize return rc to avoid returning garbage

> From: Colin Ian King <[email protected]>
>
> in the case where qed_slowpath_irq_req is not called, rc is not assigned and so
> qed_int_igu_enable will return a garbage value.
> Fix this by initializing rc to 0.
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks Colin.
Acked-by: Yuval Mintz <[email protected]>

2016-03-30 19:48:45

by David Miller

Subject: Re: [PATCH] qed: initialize return rc to avoid returning garbage

From: Colin King <[email protected]>
Date: Tue, 29 Mar 2016 18:00:50 +0100

> From: Colin Ian King <[email protected]>
>
> in the case where qed_slowpath_irq_req is not called, rc is not
> assigned and so qed_int_igu_enable will return a garbage value.
> Fix this by initializing rc to 0.
>
> Signed-off-by: Colin Ian King <[email protected]>

Applied, thanks.