Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
parameter for mode selection") changed the driver to be disabled by
default, and this can surprise users.
Let users know what happened so they can decide what to do next.
Link: https://bugs.launchpad.net/bugs/2006942
Signed-off-by: Kai-Heng Feng <[email protected]>
---
v2:
- Remove redundancy in pr_info().
- Fix spelling and URL tag.
drivers/cpufreq/amd-pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 45c88894fd8e..f965f54f7ae7 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
* with amd_pstate=passive or other modes in kernel command line
*/
if (cppc_state == AMD_PSTATE_DISABLE) {
- pr_debug("driver load is disabled, boot with specific mode to enable this\n");
+ pr_info("driver load is disabled, boot with specific mode to enable this\n");
return -ENODEV;
}
--
2.34.1
[AMD Official Use Only - General]
> -----Original Message-----
> From: Kai-Heng Feng <[email protected]>
> Sent: Thursday, February 23, 2023 3:03 PM
> To: Huang, Ray <[email protected]>
> Cc: Limonciello, Mario <[email protected]>; Kai-Heng Feng
> <[email protected]>; Rafael J. Wysocki <[email protected]>; Viresh
> Kumar <[email protected]>; [email protected]; linux-
> [email protected]
> Subject: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled
>
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver parameter
> for mode selection") changed the driver to be disabled by default, and this can
> surprise users.
>
> Let users know what happened so they can decide what to do next.
>
> Link: https://bugs.launchpad.net/bugs/2006942
> Signed-off-by: Kai-Heng Feng <[email protected]>
> ---
> v2:
> - Remove redundancy in pr_info().
> - Fix spelling and URL tag.
>
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index
> 45c88894fd8e..f965f54f7ae7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
> * with amd_pstate=passive or other modes in kernel command line
> */
> if (cppc_state == AMD_PSTATE_DISABLE) {
> - pr_debug("driver load is disabled, boot with specific mode to
> enable this\n");
> + pr_info("driver load is disabled, boot with specific mode to
> enable
> +this\n");
> return -ENODEV;
> }
>
> --
> 2.34.1
Thanks for the change.
Reviewed-by : Yuan Perry <[email protected]>
On Thu, Feb 23, 2023 at 03:02:52PM +0800, Kai-Heng Feng wrote:
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
> parameter for mode selection") changed the driver to be disabled by
> default, and this can surprise users.
>
> Let users know what happened so they can decide what to do next.
>
> Link: https://bugs.launchpad.net/bugs/2006942
> Signed-off-by: Kai-Heng Feng <[email protected]>
Please feel free to add my Acked on V2 as well.
Acked-by: Huang Rui <[email protected]>
> ---
> v2:
> - Remove redundancy in pr_info().
> - Fix spelling and URL tag.
>
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 45c88894fd8e..f965f54f7ae7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
> * with amd_pstate=passive or other modes in kernel command line
> */
> if (cppc_state == AMD_PSTATE_DISABLE) {
> - pr_debug("driver load is disabled, boot with specific mode to enable this\n");
> + pr_info("driver load is disabled, boot with specific mode to enable this\n");
> return -ENODEV;
> }
>
> --
> 2.34.1
>
[Public]
> -----Original Message-----
> From: Huang, Ray <[email protected]>
> Sent: Thursday, February 23, 2023 05:38
> To: Kai-Heng Feng <[email protected]>
> Cc: Limonciello, Mario <[email protected]>; Rafael J. Wysocki
> <[email protected]>; Viresh Kumar <[email protected]>; linux-
> [email protected]; [email protected]
> Subject: Re: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is
> disabled
>
> On Thu, Feb 23, 2023 at 03:02:52PM +0800, Kai-Heng Feng wrote:
> > Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
> > parameter for mode selection") changed the driver to be disabled by
> > default, and this can surprise users.
> >
> > Let users know what happened so they can decide what to do next.
> >
> > Link: https://bugs.launchpad.net/bugs/2006942
> > Signed-off-by: Kai-Heng Feng <[email protected]>
>
> Please feel free to add my Acked on V2 as well.
>
> Acked-by: Huang Rui <[email protected]>
Reviewed-by: Mario Limonciello <[email protected]>
>
> > ---
> > v2:
> > - Remove redundancy in pr_info().
> > - Fix spelling and URL tag.
> >
> > drivers/cpufreq/amd-pstate.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > index 45c88894fd8e..f965f54f7ae7 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
> > * with amd_pstate=passive or other modes in kernel command line
> > */
> > if (cppc_state == AMD_PSTATE_DISABLE) {
> > - pr_debug("driver load is disabled, boot with specific mode to
> enable this\n");
> > + pr_info("driver load is disabled, boot with specific mode to
> enable this\n");
> > return -ENODEV;
> > }
> >
> > --
> > 2.34.1
> >
On Thu, Feb 23, 2023 at 8:03 AM Kai-Heng Feng
<[email protected]> wrote:
>
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
> parameter for mode selection") changed the driver to be disabled by
> default, and this can surprise users.
>
> Let users know what happened so they can decide what to do next.
>
> Link: https://bugs.launchpad.net/bugs/2006942
> Signed-off-by: Kai-Heng Feng <[email protected]>
> ---
> v2:
> - Remove redundancy in pr_info().
> - Fix spelling and URL tag.
>
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 45c88894fd8e..f965f54f7ae7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
> * with amd_pstate=passive or other modes in kernel command line
> */
> if (cppc_state == AMD_PSTATE_DISABLE) {
> - pr_debug("driver load is disabled, boot with specific mode to enable this\n");
> + pr_info("driver load is disabled, boot with specific mode to enable this\n");
> return -ENODEV;
> }
>
> --
Applied as 6.3-rc material, thanks!