2020-08-29 08:09:34

by Tianxianting

Subject: [PATCH] scsi: qla2xxx: Fix the return value

A negative error code should be returned.

Signed-off-by: Xianting Tian <[email protected]>
---
drivers/scsi/qla2xxx/qla_target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index fbb80a043..612e001cc 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -3781,7 +3781,7 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd)
"multiple abort. %p transport_state %x, t_state %x, "
"se_cmd_flags %x\n", cmd, cmd->se_cmd.transport_state,
cmd->se_cmd.t_state, cmd->se_cmd.se_cmd_flags);
- return EIO;
+ return -EIO;
}
cmd->aborted = 1;
cmd->trc_flags |= TRC_ABORT;
--
2.17.1

2020-08-31 11:43:13

by Nilesh Javali

Subject: RE: [EXT] [PATCH] scsi: qla2xxx: Fix the return value

Xianting Tian,

Thanks for the patch.

> -----Original Message-----
> From: Xianting Tian <[email protected]>
> Sent: Saturday, August 29, 2020 1:28 PM
> To: Nilesh Javali <[email protected]>; GR-QLogic-Storage-Upstream <GR-
> [email protected]>; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]; Xianting Tian
> <[email protected]>
> Subject: [EXT] [PATCH] scsi: qla2xxx: Fix the return value
>
> External Email
>
> ----------------------------------------------------------------------
> A negative error code should be returned.
>
> Signed-off-by: Xianting Tian <[email protected]>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c
> b/drivers/scsi/qla2xxx/qla_target.c
> index fbb80a043..612e001cc 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -3781,7 +3781,7 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd)
> "multiple abort. %p transport_state %x, t_state %x, "
> "se_cmd_flags %x\n", cmd, cmd->se_cmd.transport_state,
> cmd->se_cmd.t_state, cmd->se_cmd.se_cmd_flags);
> - return EIO;
> + return -EIO;
> }
> cmd->aborted = 1;
> cmd->trc_flags |= TRC_ABORT;
> --
> 2.17.1

Acked-by: Nilesh Javali <[email protected]>

2020-09-09 02:12:35

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qla2xxx: Fix the return value

On Sat, 29 Aug 2020 15:57:46 +0800, Xianting Tian wrote:

> A negative error code should be returned.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Fix the return value
https://git.kernel.org/mkp/scsi/c/e5f48ac42cc9

--
Martin K. Petersen Oracle Linux Engineering