2023-06-22 09:31:49

by Lee, Kah Jing

[permalink] [raw]
Subject: [PATCH 1/2] arch: arm64: boot: dts: Updated QSPI Flash layout for UBIFS

From: Alif Zakuan Yuslaimi <[email protected]>

This patch is to update the QSPI flash layout to support UBIFS in mtd
root partition.

Signed-off-by: Alif Zakuan Yuslaimi <[email protected]>
Signed-off-by: Kah Jing Lee <[email protected]>
---
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 38ae674f2f02..12b960b9183c 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -202,12 +202,12 @@ partitions {

qspi_boot: partition@0 {
label = "Boot and fpga data";
- reg = <0x0 0x03FE0000>;
+ reg = <0x0 0x04200000>;
};

- qspi_rootfs: partition@3FE0000 {
- label = "Root Filesystem - JFFS2";
- reg = <0x03FE0000 0x0C020000>;
+ root: partition@4200000 {
+ label = "Root Filesystem - UBIFS";
+ reg = <0x04200000 0x0BE00000>;
};
};
};
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
index 07c3f8876613..608017e6e36a 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
@@ -128,12 +128,12 @@ partitions {

qspi_boot: partition@0 {
label = "Boot and fpga data";
- reg = <0x0 0x03FE0000>;
+ reg = <0x0 0x04200000>;
};

- qspi_rootfs: partition@3FE0000 {
- label = "Root Filesystem - JFFS2";
- reg = <0x03FE0000 0x0C020000>;
+ root: partition@4200000 {
+ label = "Root Filesystem - UBIFS";
+ reg = <0x04200000 0x0BE00000>;
};
};
};
--
2.25.1



2023-06-22 19:42:00

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 1/2] arch: arm64: boot: dts: Updated QSPI Flash layout for UBIFS

On Thu, Jun 22, 2023 at 04:53:19PM +0800, [email protected] wrote:
> From: Alif Zakuan Yuslaimi <[email protected]>
>
> This patch is to update the QSPI flash layout to support UBIFS in mtd
> root partition.

That much is clear from the diff. Surely it'd be better to explain *why*
this change is being made, no?

Thanks,
Conor.

>
> Signed-off-by: Alif Zakuan Yuslaimi <[email protected]>
> Signed-off-by: Kah Jing Lee <[email protected]>
> ---
> arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
> arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> index 38ae674f2f02..12b960b9183c 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> @@ -202,12 +202,12 @@ partitions {
>
> qspi_boot: partition@0 {
> label = "Boot and fpga data";
> - reg = <0x0 0x03FE0000>;
> + reg = <0x0 0x04200000>;
> };
>
> - qspi_rootfs: partition@3FE0000 {
> - label = "Root Filesystem - JFFS2";
> - reg = <0x03FE0000 0x0C020000>;
> + root: partition@4200000 {
> + label = "Root Filesystem - UBIFS";
> + reg = <0x04200000 0x0BE00000>;
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> index 07c3f8876613..608017e6e36a 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> @@ -128,12 +128,12 @@ partitions {
>
> qspi_boot: partition@0 {
> label = "Boot and fpga data";
> - reg = <0x0 0x03FE0000>;
> + reg = <0x0 0x04200000>;
> };
>
> - qspi_rootfs: partition@3FE0000 {
> - label = "Root Filesystem - JFFS2";
> - reg = <0x03FE0000 0x0C020000>;
> + root: partition@4200000 {
> + label = "Root Filesystem - UBIFS";
> + reg = <0x04200000 0x0BE00000>;
> };
> };
> };
> --
> 2.25.1
>

Attachments:
(No filename) (2.16 kB)
 signature.asc (235.00 B)
 Download all attachments

2023-06-23 10:16:16

by Lee, Kah Jing

[permalink] [raw]
Subject: RE: [PATCH 1/2] arch: arm64: boot: dts: Updated QSPI Flash layout for UBIFS

> -----Original Message-----
> From: Conor Dooley <[email protected]>
> Sent: Friday, 23 June, 2023 3:19 AM
> To: Lee, Kah Jing <[email protected]>
> Cc: Dinh Nguyen <[email protected]>; Rob Herring
> <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; Conor Dooley <[email protected]>;
> Catalin Marinas <[email protected]>; Will Deacon <[email protected]>;
> [email protected]; [email protected]; Yuslaimi, Alif
> Zakuan <[email protected]>
> Subject: Re: [PATCH 1/2] arch: arm64: boot: dts: Updated QSPI Flash layout
> for UBIFS
>
> On Thu, Jun 22, 2023 at 04:53:19PM +0800, [email protected] wrote:
> > From: Alif Zakuan Yuslaimi <[email protected]>
> >
> > This patch is to update the QSPI flash layout to support UBIFS in mtd
> > root partition.
>
> That much is clear from the diff. Surely it'd be better to explain *why* this
> change is being made, no?
Updated in v3 - Commit message:
Update the QSPI flash layout to support UBIFS in mtd root partition.
Flash layout is updated in order to store non-UBIFS related boot and fpga data in
qspi_boot(mtd0) while keep the rootfs with UBIFS in the root partition(mtd1).
>
> Thanks,
> Conor.
>
> >
> > Signed-off-by: Alif Zakuan Yuslaimi <[email protected]>
> > Signed-off-by: Kah Jing Lee <[email protected]>
> > ---
> > arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
> > arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 8 ++++----
> > 2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > index 38ae674f2f02..12b960b9183c 100644
> > --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > @@ -202,12 +202,12 @@ partitions {
> >
> > qspi_boot: partition@0 {
> > label = "Boot and fpga data";
> > - reg = <0x0 0x03FE0000>;
> > + reg = <0x0 0x04200000>;
> > };
> >
> > - qspi_rootfs: partition@3FE0000 {
> > - label = "Root Filesystem - JFFS2";
> > - reg = <0x03FE0000 0x0C020000>;
> > + root: partition@4200000 {
> > + label = "Root Filesystem - UBIFS";
> > + reg = <0x04200000 0x0BE00000>;
> > };
> > };
> > };
> > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > index 07c3f8876613..608017e6e36a 100644
> > --- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > @@ -128,12 +128,12 @@ partitions {
> >
> > qspi_boot: partition@0 {
> > label = "Boot and fpga data";
> > - reg = <0x0 0x03FE0000>;
> > + reg = <0x0 0x04200000>;
> > };
> >
> > - qspi_rootfs: partition@3FE0000 {
> > - label = "Root Filesystem - JFFS2";
> > - reg = <0x03FE0000 0x0C020000>;
> > + root: partition@4200000 {
> > + label = "Root Filesystem - UBIFS";
> > + reg = <0x04200000 0x0BE00000>;
> > };
> > };
> > };
> > --
> > 2.25.1
> >

Thanks.

Regards,
Lee, Kah Jing