2024-04-03 07:45:58

by Guanbing Huang

Subject: [PATCH v4 2/3] serial: 8250_port: Add support of pnp irq to __uart_read_properties()

From: Guanbing Huang <[email protected]>

The function __uart_read_properties doesn't cover pnp devices, so add irq
processing for pnp devices in the branch.

Signed-off-by: Guanbing Huang <[email protected]>
Reviewed-by: Bing Fan <[email protected]>
Tested-by: Linheng Du <[email protected]>
---
drivers/tty/serial/serial_port.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/serial_port.c b/drivers/tty/serial/serial_port.c
index 22b9eeb23e68..6ed072d61b88 100644
--- a/drivers/tty/serial/serial_port.c
+++ b/drivers/tty/serial/serial_port.c
@@ -14,6 +14,7 @@
#include <linux/property.h>
#include <linux/serial_core.h>
#include <linux/spinlock.h>
+#include <linux/pnp.h>

#include "serial_base.h"

@@ -221,7 +222,11 @@ static int __uart_read_properties(struct uart_port *port, bool use_defaults)

if (dev_is_platform(dev))
ret = platform_get_irq(to_platform_device(dev), 0);
- else
+ else if (dev_is_pnp(dev)) {
+ ret = pnp_irq(to_pnp_dev(dev), 0);
+ if (ret < 0)
+ ret = -ENXIO;
+ } else
ret = fwnode_irq_get(dev_fwnode(dev), 0);
if (ret == -EPROBE_DEFER)
return ret;
--
2.17.1

2024-04-03 10:09:32

by Andy Shevchenko

Subject: Re: [PATCH v4 2/3] serial: 8250_port: Add support of pnp irq to __uart_read_properties()

On Wed, Apr 03, 2024 at 12:54:19PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 03, 2024 at 03:41:29PM +0800, Guanbing Huang wrote:


One more thing, the Subject should start with "serial: port: ..."
And also should have PNP IRQ (capitalized).

> > The function __uart_read_properties doesn't cover pnp devices, so add irq
>
> __uart_read_properties()
>
> PNP
> IRQ
>
> > processing for pnp devices in the branch.
>
> PNP
>
> ...
>
> > #include <linux/property.h>
> > #include <linux/serial_core.h>
> > #include <linux/spinlock.h>
> > +#include <linux/pnp.h>
>
> Keep it ordered (in this context it should go before property.h).

--
With Best Regards,
Andy Shevchenko

2024-04-03 10:25:20

by Andy Shevchenko

Subject: Re: [PATCH v4 2/3] serial: 8250_port: Add support of pnp irq to __uart_read_properties()

On Wed, Apr 03, 2024 at 03:41:29PM +0800, Guanbing Huang wrote:
> From: Guanbing Huang <[email protected]>
>
> The function __uart_read_properties doesn't cover pnp devices, so add irq

__uart_read_properties()

PNP
IRQ

> processing for pnp devices in the branch.

PNP

..

> #include <linux/property.h>
> #include <linux/serial_core.h>
> #include <linux/spinlock.h>
> +#include <linux/pnp.h>

Keep it ordered (in this context it should go before property.h).

--
With Best Regards,
Andy Shevchenko