2019-10-21 10:20:05

by Peng Fan

Subject: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

From: Peng Fan <[email protected]>

We should not rely on bootloader to configure the phy reset.
So introduce phy-reset-gpios property to let Linux handle phy reset
itself.

Signed-off-by: Peng Fan <[email protected]>
Reviewed-by: Marco Felsch <[email protected]>
---

V2:
U-Boot->bootloader
Add R-b tag

arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
index faefb7182af1..e4d66f7db09d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
@@ -80,6 +80,7 @@
pinctrl-0 = <&pinctrl_fec1>;
phy-mode = "rgmii-id";
phy-handle = <&ethphy0>;
+ phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
fsl,magic-packet;
status = "okay";

--
2.16.4

2019-10-21 10:20:33

by Peng Fan

Subject: [PATCH V2 2/2] arm64: dts: imx8mn-ddr4-evk: add phy-reset-gpios for fec1

From: Peng Fan <[email protected]>

We should not rely on bootloader to configure the phy reset.
So introduce phy-reset-gpios property to let Linux handle phy reset
itself.

Signed-off-by: Peng Fan <[email protected]>
---

V2:
U-Boot->bootloader

arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
index 1b90faace1d3..761ba0b5d271 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
@@ -48,6 +48,7 @@
pinctrl-0 = <&pinctrl_fec1>;
phy-mode = "rgmii-id";
phy-handle = <&ethphy0>;
+ phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
fsl,magic-packet;
status = "okay";

--
2.16.4

2019-10-28 15:55:48

by Shawn Guo

Subject: Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

On Mon, Oct 21, 2019 at 10:19:17AM +0000, Peng Fan wrote:
> From: Peng Fan <[email protected]>
>
> We should not rely on bootloader to configure the phy reset.
> So introduce phy-reset-gpios property to let Linux handle phy reset
> itself.
>
> Signed-off-by: Peng Fan <[email protected]>
> Reviewed-by: Marco Felsch <[email protected]>

Applied both, thanks.

2019-10-31 19:03:22

by Leonard Crestez

Subject: Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

On 21.10.2019 13:19, Peng Fan wrote:
> From: Peng Fan <[email protected]>
>
> We should not rely on bootloader to configure the phy reset.
> So introduce phy-reset-gpios property to let Linux handle phy reset
> itself.
>
> Signed-off-by: Peng Fan <[email protected]>
> Reviewed-by: Marco Felsch <[email protected]>

This broke NFS boot for me in next-20191031: board now hangs on DHCP.

It can be fixed by reverting this DT patch or by setting
CONFIG_AT803X_PHY to y instead of m.

Needing a phy module is not a bug but everybody will need to either
adjust .config or build modules into an initramfs somehow.

> ---
>
> V2:
> U-Boot->bootloader
> Add R-b tag
>
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index faefb7182af1..e4d66f7db09d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -80,6 +80,7 @@
> pinctrl-0 = <&pinctrl_fec1>;
> phy-mode = "rgmii-id";
> phy-handle = <&ethphy0>;
> + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
> fsl,magic-packet;
> status = "okay";

2019-11-01 01:43:20

by Peng Fan

Subject: RE: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

> Subject: Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for
> fec1
>
> On 21.10.2019 13:19, Peng Fan wrote:
> > From: Peng Fan <[email protected]>
> >
> > We should not rely on bootloader to configure the phy reset.
> > So introduce phy-reset-gpios property to let Linux handle phy reset
> > itself.
> >
> > Signed-off-by: Peng Fan <[email protected]>
> > Reviewed-by: Marco Felsch <[email protected]>
>
> This broke NFS boot for me in next-20191031: board now hangs on DHCP.
>

Sorry for this. I not use sdcard when I did the test.

> It can be fixed by reverting this DT patch or by setting CONFIG_AT803X_PHY
> to y instead of m.

I prefer setting CONFIG_AT803X_PHY.

Thanks,
Peng.

>
> Needing a phy module is not a bug but everybody will need to either
> adjust .config or build modules into an initramfs somehow.
>
> > ---
> >
> > V2:
> > U-Boot->bootloader
> > Add R-b tag
> >
> > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > index faefb7182af1..e4d66f7db09d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> > @@ -80,6 +80,7 @@
> > pinctrl-0 = <&pinctrl_fec1>;
> > phy-mode = "rgmii-id";
> > phy-handle = <&ethphy0>;
> > + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
> > fsl,magic-packet;
> > status = "okay";

2019-11-04 00:52:57

by Shawn Guo

Subject: Re: [PATCH V2 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

On Thu, Oct 31, 2019 at 06:59:51PM +0000, Leonard Crestez wrote:
> On 21.10.2019 13:19, Peng Fan wrote:
> > From: Peng Fan <[email protected]>
> >
> > We should not rely on bootloader to configure the phy reset.
> > So introduce phy-reset-gpios property to let Linux handle phy reset
> > itself.
> >
> > Signed-off-by: Peng Fan <[email protected]>
> > Reviewed-by: Marco Felsch <[email protected]>
>
> This broke NFS boot for me in next-20191031: board now hangs on DHCP.

I dropped both patches for now.

Shawn

>
> It can be fixed by reverting this DT patch or by setting
> CONFIG_AT803X_PHY to y instead of m.
>
> Needing a phy module is not a bug but everybody will need to either
> adjust .config or build modules into an initramfs somehow.