On Tue, Nov 28, 2017 at 11:49:30AM +0200, [email protected] wrote:
> From: Yossef Efraim <[email protected]>
>
> This patch adds ESN support to IPsec device offload.
> Adding new xfrm device operation to synchronize device ESN.
>
> Signed-off-by: Yossef Efraim <[email protected]>
> ---
> include/linux/netdevice.h | 1 +
> include/net/xfrm.h | 12 ++++++++++++
> net/xfrm/xfrm_device.c | 4 ++--
> net/xfrm/xfrm_replay.c | 2 ++
> 4 files changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 7de7656..d4e9198 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -825,6 +825,7 @@ struct xfrmdev_ops {
> void (*xdo_dev_state_free) (struct xfrm_state *x);
> bool (*xdo_dev_offload_ok) (struct sk_buff *skb,
> struct xfrm_state *x);
> + void (*xdo_dev_state_advance_esn) (struct xfrm_state *x);
We now have a documentation for the xfrm offloadin API in the
ipsec-next tree. Please document the new device operation
there and resubmit.
Thanks!
On 11/30/2017 10:23 PM, Steffen Klassert wrote:
> On Tue, Nov 28, 2017 at 11:49:30AM +0200, [email protected] wrote:
>> From: Yossef Efraim <[email protected]>
>>
>> This patch adds ESN support to IPsec device offload.
>> Adding new xfrm device operation to synchronize device ESN.
>>
>> Signed-off-by: Yossef Efraim <[email protected]>
>> ---
>> include/linux/netdevice.h | 1 +
>> include/net/xfrm.h | 12 ++++++++++++
>> net/xfrm/xfrm_device.c | 4 ++--
>> net/xfrm/xfrm_replay.c | 2 ++
>> 4 files changed, 17 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index 7de7656..d4e9198 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -825,6 +825,7 @@ struct xfrmdev_ops {
>> void (*xdo_dev_state_free) (struct xfrm_state *x);
>> bool (*xdo_dev_offload_ok) (struct sk_buff *skb,
>> struct xfrm_state *x);
>> + void (*xdo_dev_state_advance_esn) (struct xfrm_state *x);
>
> We now have a documentation for the xfrm offloadin API in the
> ipsec-next tree. Please document the new device operation
> there and resubmit.
Please be sure to specify what the offloading driver is expected to do
with this.
sln
>
> Thanks!
>
Ok
Doc updated.
Sending this patch again with all the fixes.
Thanks!
> -----Original Message-----
> From: Steffen Klassert [mailto:[email protected]]
> Sent: Friday, December 01, 2017 8:23 AM
> To: Yossef Efraim <[email protected]>
> Cc: David S. Miller <[email protected]>; Herbert Xu
> <[email protected]>; [email protected]; linux-
> [email protected]; Boris Pismenny <[email protected]>; Yevgeny
> Kliteynik <[email protected]>; Yossi Kuperman <[email protected]>
> Subject: Re: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload
>
> On Tue, Nov 28, 2017 at 11:49:30AM +0200, [email protected] wrote:
> > From: Yossef Efraim <[email protected]>
> >
> > This patch adds ESN support to IPsec device offload.
> > Adding new xfrm device operation to synchronize device ESN.
> >
> > Signed-off-by: Yossef Efraim <[email protected]>
> > ---
> > include/linux/netdevice.h | 1 +
> > include/net/xfrm.h | 12 ++++++++++++
> > net/xfrm/xfrm_device.c | 4 ++--
> > net/xfrm/xfrm_replay.c | 2 ++
> > 4 files changed, 17 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > index 7de7656..d4e9198 100644
> > --- a/include/linux/netdevice.h
> > +++ b/include/linux/netdevice.h
> > @@ -825,6 +825,7 @@ struct xfrmdev_ops {
> > void (*xdo_dev_state_free) (struct xfrm_state *x);
> > bool (*xdo_dev_offload_ok) (struct sk_buff *skb,
> > struct xfrm_state *x);
> > + void (*xdo_dev_state_advance_esn) (struct xfrm_state *x);
>
> We now have a documentation for the xfrm offloadin API in the ipsec-next tree.
> Please document the new device operation there and resubmit.
>
> Thanks!