2022-11-10 03:58:31

by Pengfei Xu

[permalink] [raw]
Subject: [Syzkaller] There is inet_csk_get_port WARNING in v6.1-rc4 kernel

Hi Joanne Koong and net developer,

Greeting!

Soft remind: "WARNING inet_csk_get_port" is found in v6.1-rc4 kernel.

And first bad commit is: 28044fc1d4953b07acec0da4d2fc4784c57ea6fb
"net: Add a bhash2 table hashed by port and address"

Reproduce code from syzkaller, kconfig and bisect info are in attached.
Full information is in the link:
https://github.com/xupengfe/syzkaller_logs/tree/main/221108_215733_inet_csk_get_port

Thanks!
BR.

Attachments:
(No filename) (456.00 B)
 bisect_info.log (3.18 kB)
 repro.c (1.24 kB)
 kconfig (283.75 kB)
 Download all attachments

2022-11-10 19:04:49

by Joanne Koong

[permalink] [raw]
Subject: Re: [Syzkaller] There is inet_csk_get_port WARNING in v6.1-rc4 kernel

On Wed, Nov 9, 2022 at 7:38 PM Pengfei Xu <[email protected]> wrote:
>
> Hi Joanne Koong and net developer,
>
> Greeting!
>
> Soft remind: "WARNING inet_csk_get_port" is found in v6.1-rc4 kernel.
>
> And first bad commit is: 28044fc1d4953b07acec0da4d2fc4784c57ea6fb
> "net: Add a bhash2 table hashed by port and address"
>
> Reproduce code from syzkaller, kconfig and bisect info are in attached.
> Full information is in the link:
> https://github.com/xupengfe/syzkaller_logs/tree/main/221108_215733_inet_csk_get_port
>
> Thanks!
> BR.

Thanks for your email. This has the same root cause (handling the
error case when connect() fails) as the issue discussed in this thread
https://lore.kernel.org/netdev/[email protected]/.
After consensus is reached in this thread, I'll submit a follow-up
fix; I'm hoping to submit it by the end of next week at the latest.

2022-11-11 06:16:03

by Pengfei Xu

[permalink] [raw]
Subject: Re: [Syzkaller] There is inet_csk_get_port WARNING in v6.1-rc4 kernel

Hi Joanne Koong,

On 2022-11-10 at 10:37:36 -0800, Joanne Koong wrote:
> On Wed, Nov 9, 2022 at 7:38 PM Pengfei Xu <[email protected]> wrote:
> >
> > Hi Joanne Koong and net developer,
> >
> > Greeting!
> >
> > Soft remind: "WARNING inet_csk_get_port" is found in v6.1-rc4 kernel.
> >
> > And first bad commit is: 28044fc1d4953b07acec0da4d2fc4784c57ea6fb
> > "net: Add a bhash2 table hashed by port and address"
> >
> > Reproduce code from syzkaller, kconfig and bisect info are in attached.
> > Full information is in the link:
> > https://github.com/xupengfe/syzkaller_logs/tree/main/221108_215733_inet_csk_get_port
> >
> > Thanks!
> > BR.
>
> Thanks for your email. This has the same root cause (handling the
> error case when connect() fails) as the issue discussed in this thread
> https://lore.kernel.org/netdev/[email protected]/.
> After consensus is reached in this thread, I'll submit a follow-up
> fix; I'm hoping to submit it by the end of next week at the latest.

Great! Thanks for your link!
And hope the repro.c and above info is helpful.

Thanks!
BR.