2022-12-09 13:27:01

by Horatiu Vultur

Subject: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask

Fix the following smatch warning:

smatch warnings:
drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c:103 vcap_debugfs_show_rule_keyfield() error: uninitialized symbol 'value'.
drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c:106 vcap_debugfs_show_rule_keyfield() error: uninitialized symbol 'mask'.

In case the vcap field was VCAP_FIELD_U128 and the key was different
than IP6_S/DIP then the value and mask were not initialized, therefore
initialize them.

Fixes: 610c32b2ce66 ("net: microchip: vcap: Add vcap_get_rule")
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Horatiu Vultur <[email protected]>
---
drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c b/drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c
index 895bfff550d23..1237601ac9dc1 100644
--- a/drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c
+++ b/drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c
@@ -83,6 +83,8 @@ static void vcap_debugfs_show_rule_keyfield(struct vcap_control *vctrl,
hex = true;
break;
case VCAP_FIELD_U128:
+ value = data->u128.value;
+ mask = data->u128.value;
if (key == VCAP_KF_L3_IP6_SIP || key == VCAP_KF_L3_IP6_DIP) {
u8 nvalue[16], nmask[16];

--
2.38.0

2022-12-09 23:25:27

by Saeed Mahameed

Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask

On 09 Dec 13:07, Horatiu Vultur wrote:
>Fix the following smatch warning:
>
>smatch warnings:
>drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c:103 vcap_debugfs_show_rule_keyfield() error: uninitialized symbol 'value'.
>drivers/net/ethernet/microchip/vcap/vcap_api_debugfs.c:106 vcap_debugfs_show_rule_keyfield() error: uninitialized symbol 'mask'.
>
>In case the vcap field was VCAP_FIELD_U128 and the key was different
>than IP6_S/DIP then the value and mask were not initialized, therefore
>initialize them.
>
>Fixes: 610c32b2ce66 ("net: microchip: vcap: Add vcap_get_rule")
>Reported-by: kernel test robot <[email protected]>
>Reported-by: Dan Carpenter <[email protected]>
>Signed-off-by: Horatiu Vultur <[email protected]>

Reviewed-by: Saeed Mahameed <[email protected]>

2022-12-12 21:49:55

by Jakub Kicinski

Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask

On Fri, 9 Dec 2022 13:07:01 +0100 Horatiu Vultur wrote:
> case VCAP_FIELD_U128:
> + value = data->u128.value;
> + mask = data->u128.value;

If setting both to value is intentional - please mention in the commit
message. Otherwise this looks odd.

2022-12-13 07:42:42

by Horatiu Vultur

Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask

The 12/12/2022 13:02, Jakub Kicinski wrote:
>
> On Fri, 9 Dec 2022 13:07:01 +0100 Horatiu Vultur wrote:
> > case VCAP_FIELD_U128:
> > + value = data->u128.value;
> > + mask = data->u128.value;
>
> If setting both to value is intentional - please mention in the commit
> message. Otherwise this looks odd.

It should not be both set to value. Will fix this in th next version.

--
/Horatiu