2023-01-23 15:07:17

by Dan Carpenter

Subject: [PATCH] firmware: arm_scmi: Clean up a return statement

The comments say "enabled" where "disabled" is intended. Also it's
cleaner to return zero explicitly instead of ret.

Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/firmware/arm_scmi/driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index d21c7eafd641..703f16ef3953 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)
if (ret)
goto clear_dev_req_notifier;

- /* Bail out anyway when coex enabled */
- return ret;
+ /* Bail out anyway when coex disabled. */
+ return 0;
}

/* Coex enabled, carry on in any case. */
--
2.35.1

2023-01-24 09:21:28

by Cristian Marussi

Subject: Re: [PATCH] firmware: arm_scmi: Clean up a return statement

On Mon, Jan 23, 2023 at 06:07:07PM +0300, Dan Carpenter wrote:
> The comments say "enabled" where "disabled" is intended. Also it's
> cleaner to return zero explicitly instead of ret.
>
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> drivers/firmware/arm_scmi/driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index d21c7eafd641..703f16ef3953 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)
> if (ret)
> goto clear_dev_req_notifier;
>
> - /* Bail out anyway when coex enabled */
> - return ret;
> + /* Bail out anyway when coex disabled. */
> + return 0;
> }
>
> /* Coex enabled, carry on in any case. */
> --

Indeed.

Thanks,
Cristian

2023-03-09 14:12:11

by Sudeep Holla

Subject: Re: [PATCH] firmware: arm_scmi: Clean up a return statement

On Mon, 23 Jan 2023 18:07:07 +0300, Dan Carpenter wrote:
> The comments say "enabled" where "disabled" is intended. Also it's
> cleaner to return zero explicitly instead of ret.
>
>

Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks!

[1/1] firmware: arm_scmi: Clean up a return statement
https://git.kernel.org/sudeep.holla/c/8ab5059dc4f4
--
Regards,
Sudeep