Remove NULL check. NULL check before freeing function is not needed.
Correct the indentation.
Signed-off-by: Saurav Girepunje <[email protected]>
---
ChangeLog V4:
- Add Change log below --- line
ChangeLog V3:
- Add change log.
ChangeLog V2:
- Correct the indentation.
drivers/staging/r8188eu/core/rtw_sta_mgt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
index f6dffed53a60..c3600cb1790a 100644
--- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
+++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
@@ -155,9 +155,8 @@ u32 _rtw_free_sta_priv(struct sta_priv *pstapriv)
spin_unlock_bh(&pstapriv->sta_hash_lock);
/*===============================*/
- if (pstapriv->pallocated_stainfo_buf)
- vfree(pstapriv->pallocated_stainfo_buf);
- }
+ vfree(pstapriv->pallocated_stainfo_buf);
+ }
return _SUCCESS;
}
--
2.32.0
On Sun, Aug 29, 2021 at 10:30:09PM +0530, Saurav Girepunje wrote:
> Remove NULL check. NULL check before freeing function is not needed.
> Correct the indentation.
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
>
> ChangeLog V4:
> - Add Change log below --- line
>
> ChangeLog V3:
> - Add change log.
>
> ChangeLog V2:
> - Correct the indentation.
You need "---" here also. So everything what is between
---
here
---
will be ignored when you apply patch. This is good place to write
changelog, if you have tested this with real hardware, if you have any
guestions about your own implementation etc.
>
> drivers/staging/r8188eu/core/rtw_sta_mgt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
> index f6dffed53a60..c3600cb1790a 100644
> --- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
> @@ -155,9 +155,8 @@ u32 _rtw_free_sta_priv(struct sta_priv *pstapriv)
> spin_unlock_bh(&pstapriv->sta_hash_lock);
> /*===============================*/
>
> - if (pstapriv->pallocated_stainfo_buf)
> - vfree(pstapriv->pallocated_stainfo_buf);
> - }
> + vfree(pstapriv->pallocated_stainfo_buf);
> + }
>
> return _SUCCESS;
> }
> --
> 2.32.0
>
On Sun, Aug 29, 2021 at 08:13:51PM +0300, Kari Argillander wrote:
> On Sun, Aug 29, 2021 at 10:30:09PM +0530, Saurav Girepunje wrote:
> > Remove NULL check. NULL check before freeing function is not needed.
> > Correct the indentation.
> >
> > Signed-off-by: Saurav Girepunje <[email protected]>
> > ---
> >
> > ChangeLog V4:
> > - Add Change log below --- line
> >
> > ChangeLog V3:
> > - Add change log.
> >
> > ChangeLog V2:
> > - Correct the indentation.
>
> You need "---" here also.
>
No. It works fine. I applied it myself with `git am` just to be 100%
sure in case I was missing something.
regards,
dan carpenter
On Sun, Aug 29, 2021 at 10:30:09PM +0530, Saurav Girepunje wrote:
> Remove NULL check. NULL check before freeing function is not needed.
> Correct the indentation.
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
Looks good. Thanks!
Reviewed-by: Dan Carpenter <[email protected]>
regards,
dan carpenter
On 8/29/21 19:00, Saurav Girepunje wrote:
> Remove NULL check. NULL check before freeing function is not needed.
> Correct the indentation.
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
>
Acked-by: Michael Straube <[email protected]>
Thanks,
Michael
On 30 Aug 2021 14:09, Michael Straube wrote:
> On 8/29/21 19:00, Saurav Girepunje wrote:
> > Remove NULL check. NULL check before freeing function is not needed.
> > Correct the indentation.
> >
> > Signed-off-by: Saurav Girepunje <[email protected]>
> > ---
> >
>
> Acked-by: Michael Straube <[email protected]>
>
> Thanks,
> Michael
Thanks for Review Michael
Saurav
On 30 Aug 2021 14:25, Dan Carpenter wrote:
> On Sun, Aug 29, 2021 at 10:30:09PM +0530, Saurav Girepunje wrote:
> > Remove NULL check. NULL check before freeing function is not needed.
> > Correct the indentation.
> >
> > Signed-off-by: Saurav Girepunje <[email protected]>
> > ---
>
> Looks good. Thanks!
>
> Reviewed-by: Dan Carpenter <[email protected]>
>
> regards,
> dan carpenter
>
Thanks for review Dan,
Saurav