2021-09-04 13:06:04

by Saurav Girepunje

Subject: [PATCH] staging: r8188eu: core: remove condition never execute

Remove condition which never get execute.
as pattrib->mdata is always zero before if condition check.

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 4178b3c1ff57..f314f55997bf 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16
else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
SetToDs(fctrl);

- if (pattrib->mdata)
- SetMData(fctrl);
-
qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);

SetPriority(qc, tid);
--
2.32.0

2021-09-04 18:03:03

by Phillip Potter

Subject: Re: [PATCH] staging: r8188eu: core: remove condition never execute

On Sat, 4 Sept 2021 at 13:50, Saurav Girepunje
<[email protected]> wrote:
>
> Remove condition which never get execute.
> as pattrib->mdata is always zero before if condition check.
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 4178b3c1ff57..f314f55997bf 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16
> else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
> SetToDs(fctrl);
>
> - if (pattrib->mdata)
> - SetMData(fctrl);
> -
> qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
>
> SetPriority(qc, tid);
> --
> 2.32.0
>

Thanks for this.

Acked-by: Phillip Potter <[email protected]>

Regards,
Phil

2021-09-05 07:58:40

by Michael Straube

Subject: Re: [PATCH] staging: r8188eu: core: remove condition never execute

On 9/4/21 14:50, Saurav Girepunje wrote:
> Remove condition which never get execute.
> as pattrib->mdata is always zero before if condition check.
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index 4178b3c1ff57..f314f55997bf 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16
> else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE)
> SetToDs(fctrl);
>
> - if (pattrib->mdata)
> - SetMData(fctrl);
> -
> qc = (unsigned short *)(pframe + pattrib->hdrlen - 2);
>
> SetPriority(qc, tid);
> --
> 2.32.0
>

Looks good to me.

Acked-by: Michael Straube <[email protected]>

Thanks,
Michael