2023-07-18 09:18:06

by Sukrut Bellary

Subject: [PATCH] firmware: arm_scmi: Fix signed error return values handling

Handle signed error return values returned by simple_write_to_buffer().
In case of an error, return the error code.

Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support")
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Sukrut Bellary <[email protected]>
---
This is based on static analysis. Compilation tested.
---
drivers/firmware/arm_scmi/raw_mode.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/raw_mode.c b/drivers/firmware/arm_scmi/raw_mode.c
index 6971dcf72fb9..0493aa3c12bf 100644
--- a/drivers/firmware/arm_scmi/raw_mode.c
+++ b/drivers/firmware/arm_scmi/raw_mode.c
@@ -818,10 +818,13 @@ static ssize_t scmi_dbg_raw_mode_common_write(struct file *filp,
* before sending it with a single RAW xfer.
*/
if (rd->tx_size < rd->tx_req_size) {
- size_t cnt;
+ ssize_t cnt;

cnt = simple_write_to_buffer(rd->tx.buf, rd->tx.len, ppos,
buf, count);
+ if (cnt < 0)
+ return cnt;
+
rd->tx_size += cnt;
if (cnt < count)
return cnt;
--
2.34.1

2023-07-18 09:44:30

by Dan Carpenter

Subject: Re: [PATCH] firmware: arm_scmi: Fix signed error return values handling

On Tue, Jul 18, 2023 at 01:55:29AM -0700, Sukrut Bellary wrote:
> Handle signed error return values returned by simple_write_to_buffer().
> In case of an error, return the error code.
>
> Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support")
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Sukrut Bellary <[email protected]>
> ---

Thanks!

Reviewed-by: Dan Carpenter <[email protected]>

regards,
dan carpenter

2023-07-18 10:11:34

by Cristian Marussi

Subject: Re: [PATCH] firmware: arm_scmi: Fix signed error return values handling

On Tue, Jul 18, 2023 at 01:55:29AM -0700, Sukrut Bellary wrote:
> Handle signed error return values returned by simple_write_to_buffer().
> In case of an error, return the error code.
>
> Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support")
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Sukrut Bellary <[email protected]>
> ---
> This is based on static analysis. Compilation tested.
> ---

Hi Sukrut,

thanks for this.

Reviewed-by: Cristian Marussi <[email protected]>
Tested-by: Cristian Marussi <[email protected]>

Thanks,
Cristian

2023-07-19 10:18:55

by Sudeep Holla

Subject: Re: [PATCH] firmware: arm_scmi: Fix signed error return values handling

On Tue, 18 Jul 2023 01:55:29 -0700, Sukrut Bellary wrote:
> Handle signed error return values returned by simple_write_to_buffer().
> In case of an error, return the error code.
>

Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks!


[1/1] firmware: arm_scmi: Fix signed error return values handling
https://git.kernel.org/sudeep.holla/c/81b233b8dd72
--
Regards,
Sudeep