2023-07-27 01:17:48

by Yang Li

Subject: [PATCH net-next] team: Remove NULL check before dev_{put, hold}

The call netdev_{put, hold} of dev_{put, hold} will check NULL,
so there is no need to check before using dev_{put, hold},
remove it to silence the warning:

./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/team/team.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index d3dc22509ea5..bc50fc3f6913 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -2321,8 +2321,7 @@ static struct team *team_nl_team_get(struct genl_info *info)
ifindex = nla_get_u32(info->attrs[TEAM_ATTR_TEAM_IFINDEX]);
dev = dev_get_by_index(net, ifindex);
if (!dev || dev->netdev_ops != &team_netdev_ops) {
- if (dev)
- dev_put(dev);
+ dev_put(dev);
return NULL;
}

--
2.20.1.7.g153144c

2023-07-29 12:07:01

by Simon Horman

Subject: Re: [PATCH net-next] team: Remove NULL check before dev_{put, hold}

On Thu, Jul 27, 2023 at 08:57:41AM +0800, Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning:
>
> ./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2023-07-29 18:16:51

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] team: Remove NULL check before dev_{put, hold}

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Thu, 27 Jul 2023 08:57:41 +0800 you wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning:
>
> ./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991
> Signed-off-by: Yang Li <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] team: Remove NULL check before dev_{put, hold}
https://git.kernel.org/netdev/net-next/c/64a37272fa5f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2023-07-31 05:01:30

by Hangbin Liu

Subject: Re: [PATCH net-next] team: Remove NULL check before dev_{put, hold}

On Thu, Jul 27, 2023 at 08:57:41AM +0800, Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning:
>
> ./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991
> Signed-off-by: Yang Li <[email protected]>

Acked-by: Hangbin Liu <[email protected]>

> ---
> drivers/net/team/team.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
> index d3dc22509ea5..bc50fc3f6913 100644
> --- a/drivers/net/team/team.c
> +++ b/drivers/net/team/team.c
> @@ -2321,8 +2321,7 @@ static struct team *team_nl_team_get(struct genl_info *info)
> ifindex = nla_get_u32(info->attrs[TEAM_ATTR_TEAM_IFINDEX]);
> dev = dev_get_by_index(net, ifindex);
> if (!dev || dev->netdev_ops != &team_netdev_ops) {
> - if (dev)
> - dev_put(dev);
> + dev_put(dev);
> return NULL;
> }
>
> --
> 2.20.1.7.g153144c
>