2023-10-05 16:58:55

by Akihiko Odaki

Subject: [PATCH] bpf: Fix the comment for bpf_restore_data_end()

The comment used to say:
> Restore data saved by bpf_compute_data_pointers().

But bpf_compute_data_pointers() does not save the data;
bpf_compute_and_save_data_end() does.

Signed-off-by: Akihiko Odaki <[email protected]>
---
include/linux/filter.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/filter.h b/include/linux/filter.h
index 761af6b3cf2b..bf7ad887943c 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -694,7 +694,7 @@ static inline void bpf_compute_and_save_data_end(
cb->data_end = skb->data + skb_headlen(skb);
}

-/* Restore data saved by bpf_compute_data_pointers(). */
+/* Restore data saved by bpf_compute_and_save_data_end(). */
static inline void bpf_restore_data_end(
struct sk_buff *skb, void *saved_data_end)
{
--
2.42.0

2023-10-05 17:10:04

by Stanislav Fomichev

Subject: Re: [PATCH] bpf: Fix the comment for bpf_restore_data_end()

On 10/05, Akihiko Odaki wrote:
> The comment used to say:
> > Restore data saved by bpf_compute_data_pointers().
>
> But bpf_compute_data_pointers() does not save the data;
> bpf_compute_and_save_data_end() does.
>
> Signed-off-by: Akihiko Odaki <[email protected]>

Please use [PATCH bpf-next] (or bpf, depending on the tree) for bpf
patches in the future.

Acked-by: Stanislav Fomichev <[email protected]>

2023-10-06 05:40:44

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] bpf: Fix the comment for bpf_restore_data_end()

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <[email protected]>:

On Thu, 5 Oct 2023 16:21:36 +0900 you wrote:
> The comment used to say:
> > Restore data saved by bpf_compute_data_pointers().
>
> But bpf_compute_data_pointers() does not save the data;
> bpf_compute_and_save_data_end() does.
>
> Signed-off-by: Akihiko Odaki <[email protected]>
>
> [...]

Here is the summary with links:
- bpf: Fix the comment for bpf_restore_data_end()
https://git.kernel.org/bpf/bpf-next/c/9c8c3fa3a52b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html