LinuxLists.cc - [PATCH] netlink: fix typo

2024-03-22 07:26:07

Subject: [PATCH] netlink: fix typo

Add missing colon in coalesce_reply_cb

Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)
Signed-off-by: gaoxingwang <[email protected]>

Signed-off-by: gaoxingwang <[email protected]>
---
netlink/coalesce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netlink/coalesce.c b/netlink/coalesce.c
index bc34d3d..bb93f9b 100644
--- a/netlink/coalesce.c
+++ b/netlink/coalesce.c
@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
- show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
+ show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
show_cr();

--
2.27.0

2024-03-22 07:59:37

by Jason Xing

[permalink] [raw]

Subject: Re: [PATCH] netlink: fix typo

On Fri, Mar 22, 2024 at 3:26 PM gaoxingwang <[email protected]> wrote:
>
> Add missing colon in coalesce_reply_cb
>
> Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)

This commit cannot be found in net/net-next tree...

> Signed-off-by: gaoxingwang <[email protected]>
>
> Signed-off-by: gaoxingwang <[email protected]>

nit: two duplicated SoB

> ---
> netlink/coalesce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c

Where is this file? I suspect you're not using the standard mainline?

> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
> show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> - show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> + show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
> show_cr();
>
> --
> 2.27.0
>
>

2024-03-22 08:50:02

by Michal Kubecek

[permalink] [raw]

Subject: Re: [PATCH] netlink: fix typo

On Fri, Mar 22, 2024 at 09:13:53AM +0100, Jiri Pirko wrote:
> Please make clear indication which project/tree you target with your
> patch by putting appropriate name in the [patch NAME] brackets

In this case, it should be "[PATCH ethtool]".

Michal

Attachments:

(No filename) (258.00 B)
signature.asc (499.00 B)
Download all attachments

2024-03-22 09:29:37

by Jiri Pirko

[permalink] [raw]

Subject: Re: [PATCH] netlink: fix typo

Fri, Mar 22, 2024 at 08:24:56AM CET, [email protected] wrote:
>Add missing colon in coalesce_reply_cb
>
>Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)
>Signed-off-by: gaoxingwang <[email protected]>
>
>Signed-off-by: gaoxingwang <[email protected]>
>---
> netlink/coalesce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/netlink/coalesce.c b/netlink/coalesce.c
>index bc34d3d..bb93f9b 100644
>--- a/netlink/coalesce.c
>+++ b/netlink/coalesce.c

Please make clear indication which project/tree you target with your
patch by putting appropriate name in the [patch NAME] brackets

>@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
> show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
>- show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
>+ show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
> show_cr();
>
>--
>2.27.0
>
>

2024-03-22 12:18:43

by Jiri Pirko

[permalink] [raw]

Subject: Re: [PATCH] netlink: fix typo

Fri, Mar 22, 2024 at 08:24:56AM CET, [email protected] wrote:
>Add missing colon in coalesce_reply_cb
>
>Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)
>Signed-off-by: gaoxingwang <[email protected]>
>
>Signed-off-by: gaoxingwang <[email protected]>

Also, please make sure your name is properly formatted. "gaoxingwang"
certainly is not.

>---
> netlink/coalesce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/netlink/coalesce.c b/netlink/coalesce.c
>index bc34d3d..bb93f9b 100644
>--- a/netlink/coalesce.c
>+++ b/netlink/coalesce.c
>@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
> show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
>- show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
>+ show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
> show_cr();
>
>--
>2.27.0
>
>

2024-03-22 15:07:39

by Jakub Kicinski

[permalink] [raw]

Subject: Re: [PATCH] netlink: fix typo

On Fri, 22 Mar 2024 09:14:39 +0100 Jiri Pirko wrote:
> "gaoxingwang" certainly is not.

According to what rules? Honest question, I don't know much about
transliteration of what I guess is a Chinese name.

2024-03-23 07:17:23

by gaoxingwang

[permalink] [raw]

Subject: Re: [PATCH] netlink: fix typo

>> Please make clear indication which project/tree you target with your
>> patch by putting appropriate name in the [patch NAME] brackets
>
>In this case, it should be "[PATCH ethtool]".
>
>Michal
Yes, this is a commit for the ethtool project. First time contributing a patch to this project, not familiar with it yet.
Thank you all or your guidance. I'll resubmit the patch later.

2024-03-23 07:27:58

by gaoxingwang

[permalink] [raw]

Subject: [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()

Add missing colon in coalesce_reply_cb()

Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
Signed-off-by: Gao Xingwang <[email protected]>
---
netlink/coalesce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netlink/coalesce.c b/netlink/coalesce.c
index bc34d3d..bb93f9b 100644
--- a/netlink/coalesce.c
+++ b/netlink/coalesce.c
@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
- show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
+ show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
show_cr();

--
2.27.0

2024-04-02 11:17:12

by Jiri Pirko

[permalink] [raw]

Subject: Re: [PATCH] netlink: fix typo

Fri, Mar 22, 2024 at 04:07:27PM CET, [email protected] wrote:
>On Fri, 22 Mar 2024 09:14:39 +0100 Jiri Pirko wrote:
>> "gaoxingwang" certainly is not.
>
>According to what rules? Honest question, I don't know much about
>transliteration of what I guess is a Chinese name.

At least capital letter would be nice :) But "Wang" looks like a surname
and therefore a space would be appropriate too.

2024-04-02 12:17:09

by gaoxingwang

[permalink] [raw]

Subject: [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()

2024-04-02 12:20:52

by Heng Qi

[permalink] [raw]

Subject: Re: [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()

在 2024/4/2 下午8:16, gaoxingwang 写道:
> Add missing colon in coalesce_reply_cb()
>
> Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
> Signed-off-by: Gao Xingwang <[email protected]>
> ---
> netlink/coalesce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c
> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
> show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> - show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> + show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
> show_cr();
>

Reviewed-by: Heng Qi <[email protected]>